flux reports: crafting grass crops into seed ... #4047

New Issue

yourland-report · 2023-03-22T04:01:09Z

yourland-report commented

2023-03-22 04:01:09 +00:00

flux reports a bug:

crafting grass crops into seeds should be 4 -> 1 seed, to balance the flour recipes

Player position:

{
	x = 1302.6049804688,
	y = 60.5,
	z = 577.92199707031
}

Player look:

{
	x = 0.11576046794653,
	y = 0.64158350229263,
	z = 0.75826781988144
}

Player information:

{
	formspec_version = 6,
	lang_code = "",
	ip_version = 6,
	min_rtt = 0.16799999773502,
	avg_rtt = 0.17499999701977,
	max_rtt = 17.207000732422,
	max_jitter = 17.008001327515,
	avg_jitter = 0.0020000040531158,
	connection_uptime = 45094,
	serialization_version = 29,
	patch = 0,
	minor = 7,
	state = "Active",
	min_jitter = 0,
	major = 5,
	version_string = "5.7.0-dev-88a71f6bd-dirty",
	protocol_version = 41
}

Player meta:

{
	fields = {
		crafted = "107006",
		punch_count = "198799",
		inflicted_damage = "3772288",
		["petz:werewolf_clan_idx"] = "1",
		yl_commons_thankyou = "225",
		["stamina:level"] = "13",
		bitten = "0",
		xp = "1784614",
		["petz:werewolf"] = "1",
		["stamina:exhaustion"] = "109.5",
		["petz:lycanthropy"] = "1",
		["stamina:poisoned"] = "no",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		played_time = "32525108",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 11342\", \"3d_armor:leggings_rainbow 1 11342\", \"3d_armor:chestplate_rainbow 1 11342\", \"shields:shield_rainbow 1 11342\", \"nether_mobs:dragon_boots 1 2740\", \"\"}",
		yl_commons_player_joined = "1679412607",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		["petz:werewolf_vignette_id"] = "20",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		yl_commons_player_created = "1615351173",
		jointime = "1615351173",
		yl_church = "return {[\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"y\"] = 47, [\"z\"] = 429, [\"x\"] = 2733}, [\"last_death_portal\"] = 1678914871}",
		["signslib:pos"] = "(1268,49,608)",
		digged_nodes = "1420408",
		placed_nodes = "417256",
		died = "86",
		repellant = "0"
	}
}

Log identifier


[MOD] yl_report log identifier = GORqxGmtHPznkdDmwsQgYU4QKnqB23Qz

Profiler save:

profile-20230322T040109.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 9h 51min 52s | max lag: 2.67s | clients (17/52): AliasAlreadyTaken, Azelf, Bailiff, daydream, Dirac, Ernesto, flux, jackofthebean000, Lupercus, mrminer, niceride, Nicka_, noface, rheo, Service, shanish3, valikz

Teleport command:

/teleport xyz 1303 61 578

Compass command:

/give_compass Construction GORqxGmtHPznkdDmwsQgYU4QKnqB23Qz D2691E 1303 61 578

flux reports a bug: > crafting grass crops into seeds should be 4 -> 1 seed, to balance the flour recipes Player position: ``` { x = 1302.6049804688, y = 60.5, z = 577.92199707031 } ``` Player look: ``` { x = 0.11576046794653, y = 0.64158350229263, z = 0.75826781988144 } ``` Player information: ``` { formspec_version = 6, lang_code = "", ip_version = 6, min_rtt = 0.16799999773502, avg_rtt = 0.17499999701977, max_rtt = 17.207000732422, max_jitter = 17.008001327515, avg_jitter = 0.0020000040531158, connection_uptime = 45094, serialization_version = 29, patch = 0, minor = 7, state = "Active", min_jitter = 0, major = 5, version_string = "5.7.0-dev-88a71f6bd-dirty", protocol_version = 41 } ``` Player meta: ``` { fields = { crafted = "107006", punch_count = "198799", inflicted_damage = "3772288", ["petz:werewolf_clan_idx"] = "1", yl_commons_thankyou = "225", ["stamina:level"] = "13", bitten = "0", xp = "1784614", ["petz:werewolf"] = "1", ["stamina:exhaustion"] = "109.5", ["petz:lycanthropy"] = "1", ["stamina:poisoned"] = "no", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", played_time = "32525108", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 11342\", \"3d_armor:leggings_rainbow 1 11342\", \"3d_armor:chestplate_rainbow 1 11342\", \"shields:shield_rainbow 1 11342\", \"nether_mobs:dragon_boots 1 2740\", \"\"}", yl_commons_player_joined = "1679412607", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", ["petz:werewolf_vignette_id"] = "20", hud_state = "on", arenalib_infobox_arenaID = "0", yl_commons_player_created = "1615351173", jointime = "1615351173", yl_church = "return {[\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"y\"] = 47, [\"z\"] = 429, [\"x\"] = 2733}, [\"last_death_portal\"] = 1678914871}", ["signslib:pos"] = "(1268,49,608)", digged_nodes = "1420408", placed_nodes = "417256", died = "86", repellant = "0" } } ``` Log identifier ``` [MOD] yl_report log identifier = GORqxGmtHPznkdDmwsQgYU4QKnqB23Qz ``` Profiler save: ``` profile-20230322T040109.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 1d 9h 51min 52s | max lag: 2.67s | clients (17/52): AliasAlreadyTaken, Azelf, Bailiff, daydream, Dirac, Ernesto, flux, jackofthebean000, Lupercus, mrminer, niceride, Nicka_, noface, rheo, Service, shanish3, valikz ``` Teleport command: ``` /teleport xyz 1303 61 578 ``` Compass command: ``` /give_compass Construction GORqxGmtHPznkdDmwsQgYU4QKnqB23Qz D2691E 1303 61 578 ```

AliasAlreadyTaken was assigned by yourland-report

2023-03-22 04:01:09 +00:00

flux added the

1. kind/balancing

label 2023-03-22 15:17:52 +00:00

flux commented

2023-03-22 15:18:22 +00:00

and to make the "threshing floor" have a meaningful use

AliasAlreadyTaken commented

2023-03-22 15:41:13 +00:00

Sounds like this crafting recipe should - for balancing reasons - rather require a couple more grass?

flux commented

2023-03-22 15:53:58 +00:00

fixed in c7f3dce41b - i've removed the crafting of grains into grain seeds entirely.

fixed in https://gitea.your-land.de/your-land/yl_commons/commit/c7f3dce41b6ba28724374f14f003efee7a2a7a9d - i've removed the crafting of grains into grain seeds entirely.

flux commented

2023-03-22 15:57:05 +00:00

grains currently don't have a ton of uses, but the cottages update will help by making the threshing floor and handmill work on all of them.

grains currently don't have a *ton* of uses, but the cottages update will help by making the threshing floor and handmill work on all of them.

flux added the

4. step/ready to QA test

label 2023-03-22 15:59:45 +00:00

AliasAlreadyTaken commented

2023-03-22 16:55:45 +00:00

i've removed the crafting of grains into grain seeds entirely.

I don't understand the connection?

Was it meant to say "crafting of grains into grain seeds" ?

If so: I'd rather not remove this entirely. Isn't it the only way to get grain seeds when in the wilderness?

> i've removed the crafting of grains into grain seeds entirely. I don't understand the connection? Was it meant to say "crafting of grains into grain seeds" ? If so: I'd rather not remove this entirely. Isn't it the only way to get grain seeds when in the wilderness?

flux commented

2023-03-22 17:42:33 +00:00

i've removed the crafting of grains into grain seeds entirely.

I don't understand the connection?

Was it meant to say "crafting of grains into grain seeds" ?

If so: I'd rather not remove this entirely. Isn't it the only way to get grain seeds when in the wilderness?

i've removed the ability to craft farming:wheat into farming:wheat_seed (and the same for oat, barley, and rye), which was something that was accidentally added by unified crops because i didn't think about it. you will still get seeds from breaking "wild" grass, and from breaking wheat crops.

> > i've removed the crafting of grains into grain seeds entirely. > > I don't understand the connection? > > Was it meant to say "crafting of grains into grain seeds" ? > > If so: I'd rather not remove this entirely. Isn't it the only way to get grain seeds when in the wilderness? i've removed the ability to craft `farming:wheat` into `farming:wheat_seed` (and the same for oat, barley, and rye), which was something that was accidentally *added* by unified crops because i didn't think about it. you will still get seeds from breaking "wild" grass, and from breaking wheat crops.

👍 1

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-03-22 18:04:31 +00:00

AliasAlreadyTaken commented

2023-04-13 20:32:55 +00:00

QA

Not sure if those are ok?

farming:seed_cotton -> farming:seed_cotton

cucina_vegana:flax -> cucina_vegana:flax_seed

farming:lettuce -> cucina_vegana:lettuce_seed

farming:garlic -> 8x farming:garlic_clove
8x farming:garlic_clove -> farming:garlic

farming:hemp_leaf -> farming:seed_hemp

QA Not sure if those are ok? farming:seed_cotton -> farming:seed_cotton cucina_vegana:flax -> cucina_vegana:flax_seed farming:lettuce -> cucina_vegana:lettuce_seed farming:garlic -> 8x farming:garlic_clove 8x farming:garlic_clove -> farming:garlic farming:hemp_leaf -> farming:seed_hemp

AliasAlreadyTaken added the

ugh/QA NOK

label 2023-04-13 20:33:05 +00:00

flux commented

2023-04-14 19:06:39 +00:00

the garlic recipes are the original ones from farming redo, and are necessary to replant garlic. the recipe cloves -> head doesn't seem to cause balancing issues.

the cotton, flax, and hemp are superfluous, as the seeds also drop when harvesting the crops. i don't see a major balancing issue w/ these, though they do permit getting even more oil from those crops. if you say so, i'll disable those recipes.

the lettuce one is necessary at this point, as harvesting lettuce does not currently drop seeds, and you need the seeds to replant.

the garlic recipes are the original ones from farming redo, and are necessary to replant garlic. the recipe cloves -> head doesn't seem to cause balancing issues. the cotton, flax, and hemp are superfluous, as the seeds also drop when harvesting the crops. i don't see a major balancing issue w/ these, though they do permit getting even more oil from those crops. if you say so, i'll disable those recipes. the lettuce one is necessary at this point, as harvesting lettuce does not currently drop seeds, and you need the seeds to replant.

AliasAlreadyTaken commented

2023-04-15 06:43:43 +00:00

lettuce and garlic are ok, but we should disable the seed recipes for cotton, flax and hemp for consistency if we inserted them. If they came "naturally" from upstream, we can keep them.

flux commented

2023-04-15 16:19:02 +00:00

they didn't come naturally from upstream. disabled them here: 6961547dbf

they didn't come naturally from upstream. disabled them here: https://gitea.your-land.de/your-land/yl_commons/commit/6961547dbf73ad2b5099aefaf2f933036ce3b5e6

👍 1

AliasAlreadyTaken commented

2023-04-16 03:56:09 +00:00

QA

Looks good now.

QA Looks good now.

AliasAlreadyTaken added

ugh/QA OK

and removed

ugh/QA NOK

labels 2023-04-16 03:56:17 +00:00

flux added