Commands for the bailiff #3921

New Issue

AliasAlreadyTaken · 2023-03-03T16:43:37Z

AliasAlreadyTaken commented

2023-03-03 16:43:37 +00:00

Let's make a single command for the bailiff and also let the users ask the bailiff what he is doing

/bailiff

-come

--here : Teleports the bailiff near you

--to player A: Teleports the bailiff to player A

--to A: Teleports the bailiff to location A

--to xyz abc: Teleports the bailiff to coordinates abc

--help: Tells the user what he can do with this command.

-look :

--here : Looks at the position where you are

--at me : Looks and keeps looking at you

--at a : Looks and keeps looking player a

--at xyz abc: Looks at the position abc

--help : Tells the user what he can do with this command.

-report

--me : Tells you what the bailiff is doing

--to a : Tells a player what the bailiff is doing

-patrol: Bailiff resumes his patrol

-next: Bailiff goes to the next station

Let's make a single command for the bailiff and also let the users ask the bailiff what he is doing /bailiff -come --here : Teleports the bailiff near you --to player A: Teleports the bailiff to player A --to A: Teleports the bailiff to location A --to xyz abc: Teleports the bailiff to coordinates abc --help: Tells the user what he can do with this command. -look : --here : Looks at the position where you are --at me : Looks and keeps looking at you --at a : Looks and keeps looking player a --at xyz abc: Looks at the position abc --help : Tells the user what he can do with this command. -report --me : Tells you what the bailiff is doing --to a : Tells a player what the bailiff is doing -patrol: Bailiff resumes his patrol -next: Bailiff goes to the next station

👍 1

AliasAlreadyTaken added the

1. kind/enhancement

2. prio/good first issue

labels 2023-03-03 16:43:46 +00:00

AliasAlreadyTaken self-assigned this 2023-03-09 22:08:36 +00:00

AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-20 16:01:34 +00:00

AliasAlreadyTaken commented

2023-04-20 16:03:19 +00:00

Findings so far:

/stream come 500000 does teleport the bailiff to this very location:

commands need logging added to them
I managed to hang the server like in an infinite loop, but cannot reproduce it for now. I was testing /stream come here combinations. This is purely informational until we can reproduce somehow or whiteboxing yields a clue.
Nice: /stream come to p Bailiff : Teleport Bailiff to Bailiff? Huh?
/stream come to pos 1 2 3 4 leads to pos x=1,y=2,z=3
/stream come to pos 1 2 3 4 leads to pos x=1,y=2,z=99999999999999 actually sends the bailiff to this position. Boom! That causes the server hang like in 3.
Should a /stream look here keep looking at the position even after a /stream come here or similar? Or does the latter overwrite the former?
Should /stream look at p AliasAlreadyTaken resume after logout of AliasAlreadyTaken ?
Should /stream look at p AliasAlreadyTaken toggle toggle watching the person?
For sanity reasons we should have /stream look at pos 1 -999900000000000000000000000000000000000000000000000000000000000 3 return an error and only allow positions within the map.
Love the morph command! Is there an unmorph? /stream morph to p AliasAlreadyTaken
While the stream is morphed into me, should /stream report patrol send the bailiff back to patrol? Seems like this command toggles the patrol instead of report the next patrol station?
Likewise, /stream report next sends the bailiff to the next station, instead of reporting their next station. If that is intended, maybe not use "report", but "patrol" instead?
Would be good to have commands that do not immediately result in an action like /stream set interval teleport 9 return some comment to the issuer
Would be good if the "set" commands revealed the current setting when sent without parameter, like so /stream set interval reload

Findings so far: 1. `/stream come 500000` does teleport the bailiff to this very location: ![image](/attachments/86f0cb4c-1c88-4c94-b332-03dc6e8c741e) 2. commands need logging added to them 3. I managed to hang the server like in an infinite loop, but cannot reproduce it for now. I was testing /stream come here combinations. This is purely informational until we can reproduce somehow or whiteboxing yields a clue. 4. Nice: `/stream come to p Bailiff` : `Teleport Bailiff to Bailiff? Huh?` 5. `/stream come to pos 1 2 3 4` leads to pos x=1,y=2,z=3 6. `/stream come to pos 1 2 3 4` leads to pos x=1,y=2,z=99999999999999 actually sends the bailiff to this position. Boom! That causes the server hang like in 3. 7. Should a `/stream look here` keep looking at the position even after a `/stream come here` or similar? Or does the latter overwrite the former? 8. Should `/stream look at p AliasAlreadyTaken` resume after logout of AliasAlreadyTaken ? 9. Should `/stream look at p AliasAlreadyTaken toggle` toggle watching the person? 10. For sanity reasons we should have `/stream look at pos 1 -999900000000000000000000000000000000000000000000000000000000000 3` return an error and only allow positions within the map. 11. Love the morph command! Is there an unmorph? `/stream morph to p AliasAlreadyTaken` 12. While the stream is morphed into me, should `/stream report patrol` send the bailiff back to patrol? Seems like this command toggles the patrol instead of report the next patrol station? 13. Likewise, `/stream report next` sends the bailiff to the next station, instead of reporting their next station. If that is intended, maybe not use "report", but "patrol" instead? 14. Would be good to have commands that do not immediately result in an action like `/stream set interval teleport 9` return some comment to the issuer 15. Would be good if the "set" commands revealed the current setting when sent without parameter, like so `/stream set interval reload`

image.png

6.6 KiB

TheTrueBeginner commented

2023-04-23 14:03:41 +00:00

I don't see where the problem is... Is there one?
I'll add that
Thanks :D I added that to prevent an infinite loop like "/stream come to p Bailiff 2 toggle". Is that what you meant with 3?

5./6. Where is the difference? I don't understand.

"/stream look here" only sets the camera/player rotation once, it doesn't effect Bailiff's position at all.
No, Bailiff's state will be reset after log out, see l.221ff. (register_globalstep)
Yes, I don't have a better name for that :P
I'll add that as well
There is no real unmorph command, but "/stream come here" does the same thing
Oh my bad, I read your message wrong, thought it would be "/stream report patrol" instead of "stream patrol"
Same as 12
Eh... I don't understand...
"/stream report me" outputs all settings, but I can add that as well.

1. I don't see where the problem is... Is there one? 2. I'll add that 4. Thanks :D I added that to prevent an infinite loop like "/stream come to p Bailiff 2 toggle". Is that what you meant with 3? 5./6. Where is the difference? I don't understand. 7. "/stream look here" only sets the camera/player rotation once, it doesn't effect Bailiff's position at all. 8. No, Bailiff's state will be reset after log out, see l.221ff. (register_globalstep) 9. Yes, I don't have a better name for that :P 10. I'll add that as well 11. There is no real unmorph command, but "/stream come here" does the same thing 12. Oh my bad, I read your message wrong, thought it would be "/stream report patrol" instead of "stream patrol" 13. Same as 12 14. Eh... I don't understand... 15. "/stream report me" outputs all settings, but I can add that as well.

Bla commented

2023-04-23 17:22:42 +00:00

Alias:

/stream come 500000 does teleport the bailiff to this very location:

TheTrueBeginner:

I don't see where the problem is... Is there one?

check the screenshot, thats way way way outside world boundaries

> Alias: > > 1. `/stream come 500000` does teleport the bailiff to this very location: > > ![image](/attachments/86f0cb4c-1c88-4c94-b332-03dc6e8c741e) > >> TheTrueBeginner: >> 1. I don't see where the problem is... Is there one? check the screenshot, thats way way way outside world boundaries

flux commented

2023-04-23 17:49:50 +00:00

i'm surprised the bailiff's client didn't crash out there, that used to be a thing

AliasAlreadyTaken commented

2023-04-23 18:03:12 +00:00

That did crash us the testserver, see 3.

AliasAlreadyTaken modified the milestone from 1.1.118 to 1.1.119

2023-04-25 07:23:32 +00:00

AliasAlreadyTaken referenced this issue

2023-05-06 21:25:09 +00:00

1.1.119 #4181

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-05-07 19:50:49 +00:00

AliasAlreadyTaken commented

2023-05-09 13:11:25 +00:00

I don't see where the problem is... Is there one?

Yes, the server crashes when the bailiff is teleported far outside the map. Is there a way to allow only positions inside the map?

We made a similar function here:

https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/util/pos.lua#L27

I'll add that

👍

Thanks :D I added that to prevent an infinite loop like "/stream come to p Bailiff 2 toggle". Is that what you meant with 3?

No actionable item, just a "well done" 👍

This means that when by accident an additional number is given, the command still works. Not sure but it's "more clean" if in this case we tell the sender of the command he made some mistake, instead of silently executing a semi-wrong command.

Where is the difference? I don't understand.

This means that the bailiff could be teleported outside the map, this crashes the server like in 3. Same solution like for 1: check the target position whether it is legal and inside the map

"/stream look here" only sets the camera/player rotation once, it doesn't effect Bailiff's position at all.

👍

No, Bailiff's state will be reset after log out, see l.221ff. (register_globalstep)

👍

Yes, I don't have a better name for that :P

👍

I'll add that as well

👍 You could use the same function as in 1.

There is no real unmorph command, but "/stream come here" does the same thing

Would be less guessing if there was an unmorph command, it certainly can do the same as /stream come here

Oh my bad, I read your message wrong, thought it would be "/stream report patrol" instead of "stream patrol"

👍

Same as 12

👍

Eh... I don't understand...

If a command immediately results in an action, the person who sends the command can observe the action. If a command does not result in an observable action, it might be a good idea to tell the user what the bailiff did. Liek in the Example, the bailiff could say "I set this key to that value"

"/stream report me" outputs all settings, but I can add that as well.

👍

> 1. I don't see where the problem is... Is there one? Yes, the server crashes when the bailiff is teleported far outside the map. Is there a way to allow only positions inside the map? We made a similar function here: https://gitea.your-land.de/your-land/yl_commons/src/branch/yl_stable/util/pos.lua#L27 > 2. I'll add that 👍 > 4. Thanks :D I added that to prevent an infinite loop like "/stream come to p Bailiff 2 toggle". Is that what you meant with 3? No actionable item, just a "well done" 👍 > 5. This means that when by accident an additional number is given, the command still works. Not sure but it's "more clean" if in this case we tell the sender of the command he made some mistake, instead of silently executing a semi-wrong command. > 6. Where is the difference? I don't understand. This means that the bailiff could be teleported outside the map, this crashes the server like in 3. Same solution like for 1: check the target position whether it is legal and inside the map > 7. "/stream look here" only sets the camera/player rotation once, it doesn't effect Bailiff's position at all. 👍 > 8. No, Bailiff's state will be reset after log out, see l.221ff. (register_globalstep) 👍 > 9. Yes, I don't have a better name for that :P 👍 > 10. I'll add that as well 👍 You could use the same function as in 1. > 11. There is no real unmorph command, but "/stream come here" does the same thing Would be less guessing if there was an unmorph command, it certainly can do the same as /stream come here > 12. Oh my bad, I read your message wrong, thought it would be "/stream report patrol" instead of "stream patrol" 👍 > 13. Same as 12 👍 > 14. Eh... I don't understand... If a command immediately results in an action, the person who sends the command can observe the action. If a command does not result in an observable action, it might be a good idea to tell the user what the bailiff did. Liek in the Example, the bailiff could say "I set this key to that value" > 15. "/stream report me" outputs all settings, but I can add that as well. 👍

AliasAlreadyTaken commented

2023-05-14 18:25:05 +00:00

QA

happy QA noises

QA *happy QA noises*

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-14 18:25:10 +00:00

flux commented

2023-05-18 19:23:34 +00:00

i didn't test all the features, but this is live.

flux closed this issue