daydream reports: could Coralfish be cookable in ... #3866

New Issue

yourland-report · 2023-02-22T08:25:36Z

yourland-report commented

2023-02-22 08:25:36 +00:00

daydream reports a bug:

could Coralfish be cookable in furnace like other fish?

Player position:

{
	y = 2.5,
	z = -9718.2060546875,
	x = -7765.9140625
}

Player look:

{
	y = -0.21303038299084,
	z = 0.20963987708092,
	x = -0.95428991317749
}

Player information:

{
	max_rtt = 2.2639999389648,
	lang_code = "",
	formspec_version = 6,
	protocol_version = 41,
	major = 5,
	version_string = "5.7.0-56d2567b5-56d2567b5",
	minor = 7,
	ip_version = 6,
	min_rtt = 0.15899999439716,
	avg_rtt = 0.17299999296665,
	min_jitter = 0,
	max_jitter = 2.0920000076294,
	avg_jitter = 0.0040000081062317,
	connection_uptime = 7271,
	serialization_version = 29,
	patch = 0,
	state = "Active"
}

Player meta:

{
	fields = {
		died = "228",
		jointime = "1650064821",
		xp = "1252854",
		played_time = "15565699",
		digged_nodes = "1515926",
		xp_redo_hud_color = "0xFFC001",
		["stamina:poisoned"] = "no",
		["petz:werewolf"] = "0",
		crafted = "2547",
		bitten = "0",
		repellant = "0",
		yl_church = "return {[\"last_death_portal\"] = 1676832674, [\"last_death\"] = {[\"y\"] = 72, [\"z\"] = 704, [\"x\"] = 2978}, [\"last_heal\"] = 1673944229}",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 240\", \"shields:shield_rainbow 1 96\", \"3d_armor:chestplate_crystal 1 240\", \"3d_armor:leggings_crystal 1 240\", \"3d_armor:boots_crystal 1 240\", \"\"}",
		["petz:lycanthropy"] = "0",
		hud_state = "on",
		["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}",
		punch_count = "83506",
		["stamina:exhaustion"] = "54.5",
		inflicted_damage = "1690848",
		["petz:werewolf_vignette_id"] = "19",
		yl_commons_player_created = "1650064821",
		yl_commons_player_joined = "1677047099",
		["stamina:level"] = "9",
		yl_commons_thankyou = "273",
		["petz:werewolf_clan_idx"] = "1",
		placed_nodes = "220973",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["signslib:pos"] = "(-7737,9,-9718)",
		partychat = "party",
		["ocean_build.last_warning"] = "1.65235e+09",
		arenalib_infobox_arenaID = "0",
		["ocean_build.ocean_built"] = "8"
	}
}

Log identifier


[MOD] yl_report log identifier = v7jHVXGQUJW2EGYunMPuqEhkKcDpdp05

Profiler save:

profile-20230222T082536.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 4h 8min 36s | max lag: 2.93s | clients (22/52): 9T9, AliasAlreadyTaken, Aliza, Azelf, Bailiff, Chazz, daydream, Diorx, Ernesto, flux, fraanXD765, johanlegend, labrat, Mentaloid, Murmel, niceride, richelles, Robledo, Scarabey_Skif, Service, SkylerHunt, tagtraum

Teleport command:

/teleport xyz -7766 3 -9718

Compass command:

/give_compass Construction v7jHVXGQUJW2EGYunMPuqEhkKcDpdp05 D2691E -7766 3 -9718

daydream reports a bug: > could Coralfish be cookable in furnace like other fish? Player position: ``` { y = 2.5, z = -9718.2060546875, x = -7765.9140625 } ``` Player look: ``` { y = -0.21303038299084, z = 0.20963987708092, x = -0.95428991317749 } ``` Player information: ``` { max_rtt = 2.2639999389648, lang_code = "", formspec_version = 6, protocol_version = 41, major = 5, version_string = "5.7.0-56d2567b5-56d2567b5", minor = 7, ip_version = 6, min_rtt = 0.15899999439716, avg_rtt = 0.17299999296665, min_jitter = 0, max_jitter = 2.0920000076294, avg_jitter = 0.0040000081062317, connection_uptime = 7271, serialization_version = 29, patch = 0, state = "Active" } ``` Player meta: ``` { fields = { died = "228", jointime = "1650064821", xp = "1252854", played_time = "15565699", digged_nodes = "1515926", xp_redo_hud_color = "0xFFC001", ["stamina:poisoned"] = "no", ["petz:werewolf"] = "0", crafted = "2547", bitten = "0", repellant = "0", yl_church = "return {[\"last_death_portal\"] = 1676832674, [\"last_death\"] = {[\"y\"] = 72, [\"z\"] = 704, [\"x\"] = 2978}, [\"last_heal\"] = 1673944229}", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 240\", \"shields:shield_rainbow 1 96\", \"3d_armor:chestplate_crystal 1 240\", \"3d_armor:leggings_crystal 1 240\", \"3d_armor:boots_crystal 1 240\", \"\"}", ["petz:lycanthropy"] = "0", hud_state = "on", ["petz:old_override_table"] = "return {[\"speed\"] = 2, [\"sneak\"] = true, [\"jump\"] = 1.5, [\"gravity\"] = 1, [\"new_move\"] = true, [\"sneak_glitch\"] = false}", punch_count = "83506", ["stamina:exhaustion"] = "54.5", inflicted_damage = "1690848", ["petz:werewolf_vignette_id"] = "19", yl_commons_player_created = "1650064821", yl_commons_player_joined = "1677047099", ["stamina:level"] = "9", yl_commons_thankyou = "273", ["petz:werewolf_clan_idx"] = "1", placed_nodes = "220973", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["signslib:pos"] = "(-7737,9,-9718)", partychat = "party", ["ocean_build.last_warning"] = "1.65235e+09", arenalib_infobox_arenaID = "0", ["ocean_build.ocean_built"] = "8" } } ``` Log identifier ``` [MOD] yl_report log identifier = v7jHVXGQUJW2EGYunMPuqEhkKcDpdp05 ``` Profiler save: ``` profile-20230222T082536.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 4h 8min 36s | max lag: 2.93s | clients (22/52): 9T9, AliasAlreadyTaken, Aliza, Azelf, Bailiff, Chazz, daydream, Diorx, Ernesto, flux, fraanXD765, johanlegend, labrat, Mentaloid, Murmel, niceride, richelles, Robledo, Scarabey_Skif, Service, SkylerHunt, tagtraum ``` Teleport command: ``` /teleport xyz -7766 3 -9718 ``` Compass command: ``` /give_compass Construction v7jHVXGQUJW2EGYunMPuqEhkKcDpdp05 D2691E -7766 3 -9718 ```

AliasAlreadyTaken was assigned by yourland-report

2023-02-22 08:25:36 +00:00

flux added the

1. kind/enhancement

2. prio/good first issue

labels 2023-02-22 20:20:08 +00:00

Ghost commented

2023-05-08 16:24:16 +00:00

Is this issue finished?

flux commented

2023-05-09 18:51:36 +00:00

currently, cooked fish is made of anything in group:ethereal_fish. more reasonably, it should probably be made from anything in group:food_fish_raw, but several things need to be removed from that group then: jellyfish, urchins, and possibly imitation fish.

currently, cooked fish is made of anything in `group:ethereal_fish`. more reasonably, it should probably be made from anything in `group:food_fish_raw`, but several things need to be removed from that group then: jellyfish, urchins, and possibly imitation fish.

Ghost commented

2023-05-09 19:25:03 +00:00

I adapted the code to the Water_life mod api and it's ready for testing. I thought that this mod is the scaffolding

AliasAlreadyTaken commented

2023-05-10 05:33:27 +00:00

@Syslog Where can we see that code?

flux commented

2023-05-10 21:03:21 +00:00

there's another kink in this - a recipe conflict w/ the cooked salmon and cooked trout from sandwiches...

flux added the

3. source/integration

label 2023-05-10 21:03:31 +00:00

flux added the

4. step/ready to QA test

label 2023-05-10 21:43:55 +00:00

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-10 23:21:55 +00:00

flux commented

2023-05-11 21:55:13 +00:00

turned the cooked salmon/trout into smoked salmon/trout:

5b7db50368

turned the cooked salmon/trout into smoked salmon/trout: https://gitea.your-land.de/your-land/yl_commons/commit/5b7db5036831f86f81477a1c695230e313a94261

👍 1

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-13 15:07:45 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-05-18 19:21:01 +00:00

flux commented

2023-05-18 19:21:57 +00:00

forgot to link the commit w/ the fixes to fish groups, here it is: 7ed238e143

this is live.

forgot to link the commit w/ the fixes to fish groups, here it is: https://gitea.your-land.de/your-land/yl_commons/commit/7ed238e143b266a33fe55f7c9857c1815d2da68d this is live.

flux closed this issue

2023-05-18 19:21:57 +00:00

AliasAlreadyTaken was unassigned by flux

2023-05-18 19:22:13 +00:00

Sign in to join this conversation.