Laylem reports: breaking a petz:fishtank leads ... #3733

Closed
opened 2023-02-05 09:15:47 +00:00 by yourland-report · 6 comments

Laylem reports a bug:

breaking a petz:fishtank leads to fish falling out as an animal. Can it drop as an item so it won't immediately expire?

Player position:

{
	y = 12.5,
	z = 1617.6999511719,
	x = 2233.8000488281
}

Player look:

{
	y = -0.56870543956757,
	z = 0.38260599970818,
	x = -0.72813928127289
}

Player information:

{
	ip_version = 6,
	min_rtt = 0.16200000047684,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	max_jitter = 2.0880000591278,
	lang_code = "",
	connection_uptime = 802,
	serialization_version = 29,
	patch = 1,
	max_rtt = 2.2569999694824,
	version_string = "5.6.1",
	state = "Active",
	avg_jitter = 0.0019999891519547,
	formspec_version = 6,
	protocol_version = 41,
	minor = 6,
	major = 5
}

Player meta:

{
	fields = {
		repellant = "0",
		["stamina:level"] = "11",
		crafted = "77579",
		["ocean_build.last_warning"] = "1.66072e+09",
		inflicted_damage = "548562",
		["ocean_build.ocean_built"] = "11",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27625\", \"shields:shield_rainbow 1 19176\", \"3d_armor:chestplate_crystal 1 27625\", \"3d_armor:boots_crystal 1 27625\", \"3d_armor:leggings_crystal 1 27625\", \"\"}",
		yl_commons_player_created = "1659420654",
		yl_commons_player_joined = "1675587775",
		partychat = "main",
		punch_count = "26330",
		["stamina:exhaustion"] = "82",
		yl_commons_thankyou = "69",
		bitten = "0",
		["signslib:pos"] = "(2227,13,1625)",
		xp = "347955",
		yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1659420654",
		played_time = "2223173",
		digged_nodes = "330917",
		placed_nodes = "96871",
		died = "45",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		["stamina:poisoned"] = "no"
	}
}

Log identifier


[MOD] yl_report log identifier = MGdpLzJalUu7skuQesVNE5INTAUW0fJK

Profiler save:

profile-20230205T091547.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 21h 38min 27s | max lag: 2.57s | clients (21/52): 9T9, AliasAlreadyTaken, Arsten, Azelf, Bailiff, CaramelPlant, daydream, evil123, flux, karlbrock, labrat, Laylem, niceride, omer2133, Penelopee, phillip, Service, SkyArt, Tundra, Xonon, yo_hi

Teleport command:

/teleport xyz 2234 13 1618

Compass command:

/give_compass Construction MGdpLzJalUu7skuQesVNE5INTAUW0fJK D2691E 2234 13 1618
Laylem reports a bug: > breaking a petz:fishtank leads to fish falling out as an animal. Can it drop as an item so it won't immediately expire? Player position: ``` { y = 12.5, z = 1617.6999511719, x = 2233.8000488281 } ``` Player look: ``` { y = -0.56870543956757, z = 0.38260599970818, x = -0.72813928127289 } ``` Player information: ``` { ip_version = 6, min_rtt = 0.16200000047684, avg_rtt = 0.17200000584126, min_jitter = 0, max_jitter = 2.0880000591278, lang_code = "", connection_uptime = 802, serialization_version = 29, patch = 1, max_rtt = 2.2569999694824, version_string = "5.6.1", state = "Active", avg_jitter = 0.0019999891519547, formspec_version = 6, protocol_version = 41, minor = 6, major = 5 } ``` Player meta: ``` { fields = { repellant = "0", ["stamina:level"] = "11", crafted = "77579", ["ocean_build.last_warning"] = "1.66072e+09", inflicted_damage = "548562", ["ocean_build.ocean_built"] = "11", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27625\", \"shields:shield_rainbow 1 19176\", \"3d_armor:chestplate_crystal 1 27625\", \"3d_armor:boots_crystal 1 27625\", \"3d_armor:leggings_crystal 1 27625\", \"\"}", yl_commons_player_created = "1659420654", yl_commons_player_joined = "1675587775", partychat = "main", punch_count = "26330", ["stamina:exhaustion"] = "82", yl_commons_thankyou = "69", bitten = "0", ["signslib:pos"] = "(2227,13,1625)", xp = "347955", yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1659420654", played_time = "2223173", digged_nodes = "330917", placed_nodes = "96871", died = "45", hud_state = "on", arenalib_infobox_arenaID = "0", ["stamina:poisoned"] = "no" } } ``` Log identifier ``` [MOD] yl_report log identifier = MGdpLzJalUu7skuQesVNE5INTAUW0fJK ``` Profiler save: ``` profile-20230205T091547.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 21h 38min 27s | max lag: 2.57s | clients (21/52): 9T9, AliasAlreadyTaken, Arsten, Azelf, Bailiff, CaramelPlant, daydream, evil123, flux, karlbrock, labrat, Laylem, niceride, omer2133, Penelopee, phillip, Service, SkyArt, Tundra, Xonon, yo_hi ``` Teleport command: ``` /teleport xyz 2234 13 1618 ``` Compass command: ``` /give_compass Construction MGdpLzJalUu7skuQesVNE5INTAUW0fJK D2691E 2234 13 1618 ```
AliasAlreadyTaken was assigned by yourland-report 2023-02-05 09:15:47 +00:00
AliasAlreadyTaken added the
1. kind/bug
label 2023-02-05 09:19:15 +00:00
Member

probably you should take the fish out of the tank before breaking it? use a net.

probably you should take the fish out of the tank before breaking it? use a net.
flux added the
1. kind/documentation
label 2023-02-05 16:41:22 +00:00

Hmm... I wasn't aware I could use a net on the block. Maybe this could be explained somewhere...

Hmm... I wasn't aware I could use a net on the block. Maybe this could be explained somewhere...
Member

i've created some code that adds infotext to the tank to explain the usage:

823c1959a9

i've created some code that adds infotext to the tank to explain the usage: https://gitea.your-land.de/your-land/yl_commons/commit/823c1959a9e71ba8b49e193fdb17e0d8dca33d4d
flux added the
4. step/ready to QA test
label 2023-02-06 18:17:29 +00:00
AliasAlreadyTaken added this to the 1.1.117.1 milestone 2023-02-09 18:54:09 +00:00
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 2023-02-12 14:30:00 +00:00

QA

I can place the clownfish, but I can't place the tropical fish in.

The clownfish can be caught with the red net and the text says how to do it.

Since the tropicalfish cannot be placed in 1.1.118 as well, this is OK, but I opened an issue #4182 to get the tropical fish into the fishtank as well.

Please note, the initial request to drop the fish as an item was NOT implemented on purpose.

QA I can place the clownfish, but I can't place the tropical fish in. The clownfish can be caught with the red net and the text says how to do it. Since the tropicalfish cannot be placed in 1.1.118 as well, this is OK, but I opened an issue #4182 to get the tropical fish into the fishtank as well. Please note, the initial request to drop the fish as an item was NOT implemented on purpose.
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-13 22:02:31 +00:00
Member

I can place the clownfish, but I can't place the tropical fish in.

herp derp, i munged the item name in the filter, fixed this in e5358c34ed

> I can place the clownfish, but I can't place the tropical fish in. herp derp, i munged the item name in the filter, fixed this in https://gitea.your-land.de/your-land/yl_commons/commit/e5358c34ed7f75537816745c1c16a4e8670be308
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-25 19:47:11 +00:00
AliasAlreadyTaken was unassigned by flux 2023-04-25 19:47:16 +00:00
Member

this is live, including the correct filter.

this is live, including the correct filter.
flux closed this issue 2023-04-25 19:47:29 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3733
No description provided.