Laylem reports: Can we have ability to fill cu ... #3716

New Issue

yourland-report · 2023-02-04T00:10:47Z

yourland-report commented

2023-02-04 00:10:47 +00:00

Laylem reports a bug:

Can we have ability to fill cups directly with river water by clicking, instead of using bucket of river water?

Player position:

{
	z = -1990.3779296875,
	x = -955.00500488281,
	y = 1.625
}

Player look:

{
	z = 0.92518377304077,
	x = 0.017118284478784,
	y = -0.37913319468498
}

Player information:

{
	major = 5,
	version_string = "5.6.1",
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.16099999845028,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	lang_code = "",
	avg_jitter = 0.0020000040531158,
	connection_uptime = 11761,
	serialization_version = 29,
	patch = 1,
	minor = 6,
	state = "Active",
	max_rtt = 1.6169999837875,
	formspec_version = 6,
	max_jitter = 1.4500000476837
}

Player meta:

{
	fields = {
		jointime = "1659420654",
		bitten = "0",
		["signslib:pos"] = "(2227,13,1625)",
		arenalib_infobox_arenaID = "0",
		yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}",
		yl_commons_thankyou = "69",
		xp = "347442",
		punch_count = "26247",
		played_time = "2214873",
		digged_nodes = "330731",
		placed_nodes = "96742",
		died = "45",
		partychat = "main",
		crafted = "77444",
		["stamina:exhaustion"] = "43.5",
		["stamina:level"] = "4",
		hud_state = "on",
		["stamina:poisoned"] = "no",
		["ocean_build.last_warning"] = "1.66072e+09",
		inflicted_damage = "546746",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27185\", \"shields:shield_rainbow 1 19000\", \"3d_armor:chestplate_crystal 1 27185\", \"3d_armor:boots_crystal 1 27185\", \"3d_armor:leggings_crystal 1 27185\", \"\"}",
		["ocean_build.ocean_built"] = "11",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		repellant = "0",
		yl_commons_player_created = "1659420654",
		yl_commons_player_joined = "1675457713"
	}
}

Log identifier


[MOD] yl_report log identifier = DKWuhFcFPFadoo2F9h2j0CFDQHyo5ubp

Profiler save:

profile-20230204T001047.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 2h 21min 4s | max lag: 5.23s | clients (33/52): 9T9, afonsan, AliasAlreadyTaken, Aliza, annah, Arsten, AspireMint, Azelf, Bailiff, CaramelPlant, Chache, Chazz, daydream, Ecklair, Elias, flux, HorusDamocles, Hydra, icecreamkek, itaca94, karlbrock, labrat, Laylem, legoman1990, Mentaloid, niceride, Oakenshield, Parrish, rewired_X, rheo, Service, Sokomine, Sysmatic

Teleport command:

/teleport xyz -955 2 -1990

Compass command:

/give_compass Construction DKWuhFcFPFadoo2F9h2j0CFDQHyo5ubp D2691E -955 2 -1990

Laylem reports a bug: > Can we have ability to fill cups directly with river water by clicking, instead of using bucket of river water? Player position: ``` { z = -1990.3779296875, x = -955.00500488281, y = 1.625 } ``` Player look: ``` { z = 0.92518377304077, x = 0.017118284478784, y = -0.37913319468498 } ``` Player information: ``` { major = 5, version_string = "5.6.1", protocol_version = 41, ip_version = 6, min_rtt = 0.16099999845028, avg_rtt = 0.17200000584126, min_jitter = 0, lang_code = "", avg_jitter = 0.0020000040531158, connection_uptime = 11761, serialization_version = 29, patch = 1, minor = 6, state = "Active", max_rtt = 1.6169999837875, formspec_version = 6, max_jitter = 1.4500000476837 } ``` Player meta: ``` { fields = { jointime = "1659420654", bitten = "0", ["signslib:pos"] = "(2227,13,1625)", arenalib_infobox_arenaID = "0", yl_church = "return {[\"last_death_portal\"] = 1673847554, [\"last_death\"] = {[\"y\"] = 60, [\"z\"] = 5, [\"x\"] = 2636}, [\"last_heal\"] = 1673778297}", yl_commons_thankyou = "69", xp = "347442", punch_count = "26247", played_time = "2214873", digged_nodes = "330731", placed_nodes = "96742", died = "45", partychat = "main", crafted = "77444", ["stamina:exhaustion"] = "43.5", ["stamina:level"] = "4", hud_state = "on", ["stamina:poisoned"] = "no", ["ocean_build.last_warning"] = "1.66072e+09", inflicted_damage = "546746", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 27185\", \"shields:shield_rainbow 1 19000\", \"3d_armor:chestplate_crystal 1 27185\", \"3d_armor:boots_crystal 1 27185\", \"3d_armor:leggings_crystal 1 27185\", \"\"}", ["ocean_build.ocean_built"] = "11", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", repellant = "0", yl_commons_player_created = "1659420654", yl_commons_player_joined = "1675457713" } } ``` Log identifier ``` [MOD] yl_report log identifier = DKWuhFcFPFadoo2F9h2j0CFDQHyo5ubp ``` Profiler save: ``` profile-20230204T001047.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 5d 2h 21min 4s | max lag: 5.23s | clients (33/52): 9T9, afonsan, AliasAlreadyTaken, Aliza, annah, Arsten, AspireMint, Azelf, Bailiff, CaramelPlant, Chache, Chazz, daydream, Ecklair, Elias, flux, HorusDamocles, Hydra, icecreamkek, itaca94, karlbrock, labrat, Laylem, legoman1990, Mentaloid, niceride, Oakenshield, Parrish, rewired_X, rheo, Service, Sokomine, Sysmatic ``` Teleport command: ``` /teleport xyz -955 2 -1990 ``` Compass command: ``` /give_compass Construction DKWuhFcFPFadoo2F9h2j0CFDQHyo5ubp D2691E -955 2 -1990 ```

👍 4

AliasAlreadyTaken was assigned by yourland-report

2023-02-04 00:10:47 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2023-02-04 00:29:32 +00:00

flux commented

2023-02-04 00:42:19 +00:00

i support this. however, balancing - cups of water stack, whereas buckets do not.

flux added the

1. kind/balancing

label 2023-02-04 00:42:46 +00:00

flux added this to the flux's TODO list project 2023-02-25 21:48:01 +00:00

flux added the

4. step/want approval

2. prio/good first issue

labels 2023-02-25 21:48:21 +00:00

flux referenced this issue

2023-05-16 19:16:53 +00:00

Chache reports: Suggestion: when you're holdin ... #4504

whosit referenced this issue

2023-05-30 17:22:06 +00:00

Ravise reports: glass of water: allow vessels: ... #4638

flux commented

2023-05-30 20:40:50 +00:00

i wrote some code to do this, still waiting for approval:

if not (yl_commons.has.farming and yl_commons.has.vessels) then
	return
end

minetest.override_item("vessels:drinking_glass", {
	liquids_pointable = true,
	on_use = function(itemstack, user, pointed_thing)
		if pointed_thing.type == "node" then
			local pos = pointed_thing.under
			local node = minetest.get_node(pos)
			if node.name == "default:river_water_source" then
				itemstack:take_item()
				local inv = user:get_inventory()
				local remainder = inv:add_item("main", "farming:glass_water")
				if not remainder:is_empty() then
					minetest.add_item(user:get_pos(), remainder)
				end
				return itemstack
			end
		end
	end,
})

i wrote some code to do this, still waiting for approval: ```lua if not (yl_commons.has.farming and yl_commons.has.vessels) then return end minetest.override_item("vessels:drinking_glass", { liquids_pointable = true, on_use = function(itemstack, user, pointed_thing) if pointed_thing.type == "node" then local pos = pointed_thing.under local node = minetest.get_node(pos) if node.name == "default:river_water_source" then itemstack:take_item() local inv = user:get_inventory() local remainder = inv:add_item("main", "farming:glass_water") if not remainder:is_empty() then minetest.add_item(user:get_pos(), remainder) end return itemstack end end end, }) ```

AliasAlreadyTaken commented

2023-05-30 23:29:49 +00:00

This is an infinity mechanic, right?

Much like the "ever-replenishing ocean water source"?

This is an infinity mechanic, right? Much like the "ever-replenishing ocean water source"?

flux commented

2023-05-30 23:48:10 +00:00

This is an infinity mechanic, right?

Much like the "ever-replenishing ocean water source"?

river water also replenishes infinitely, this would just provide a simpler way of filling up a bunch of water glasses.

> This is an infinity mechanic, right? > > Much like the "ever-replenishing ocean water source"? river water also replenishes infinitely, this would just provide a simpler way of filling up a bunch of water glasses.

👍 2

AliasAlreadyTaken commented

2023-05-31 01:35:47 +00:00

Still, this would make the crafting recipe obsolete, right?

flux commented

2023-05-31 03:54:40 +00:00

Still, this would make the crafting recipe obsolete, right?

the crafting recipe allows you to set up a pipeworks machine. i'm not certain that this change would enable similar automation.

> Still, this would make the crafting recipe obsolete, right? the crafting recipe allows you to set up a pipeworks machine. i'm not certain that this change would enable similar automation.

Sign in to join this conversation.