debiankaios reports: the old gold apple texture fit ... #3622

New Issue

yourland-report · 2023-01-25T17:48:47Z

yourland-report commented

2023-01-25 17:48:47 +00:00

debiankaios reports a bug:

the old gold apple texture fit more and shouldn't replaced

Player position:

{
	x = 1018.617980957,
	y = 50.5,
	z = 817.8740234375
}

Player look:

{
	x = 0.36068820953369,
	y = -0.89625430107117,
	z = -0.25813218951225
}

Player information:

{
	version_string = "5.7.0-dev-6377ce9-dirty",
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.014000000432134,
	avg_rtt = 0.020999999716878,
	min_jitter = 0,
	max_jitter = 0.79699999094009,
	avg_jitter = 0.0010000001639128,
	connection_uptime = 464,
	serialization_version = 29,
	patch = 0,
	minor = 7,
	lang_code = "de",
	max_rtt = 0.81400001049042,
	state = "Active",
	formspec_version = 6,
	major = 5
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		yl_commons_player_created = "1618169882",
		yl_commons_player_joined = "1674668474",
		played_time = "3950989",
		yl_commons_thankyou = "83",
		bitten = "0",
		punch_count = "56503",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1618169882",
		xp = "183293",
		hud_state = "on",
		placed_nodes = "91664",
		yl_church = "return {[\"last_death\"] = {[\"x\"] = 2041, [\"y\"] = 28838, [\"z\"] = 1515}, [\"last_heal\"] = 1674589936, [\"last_death_portal\"] = 1674422499}",
		["stamina:exhaustion"] = "104",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 28595\", \"shields:shield_crystal 1 28595\", \"3d_armor:boots_crystal 1 29220\", \"3d_armor:leggings_crystal 1 28595\", \"3d_armor:chestplate_crystal 1 28595\", \"\"}",
		arenalib_infobox_arenaID = "0",
		["signslib:pos"] = "(1020,49,817)",
		digged_nodes = "230618",
		died = "394",
		inflicted_damage = "1100372",
		partychat = "party",
		crafted = "3490",
		repellant = "0",
		["stamina:level"] = "18"
	}
}

Log identifier


[MOD] yl_report log identifier = HUc2RjWFq8BjpzqS0mS9wcKKc5bM6O65

Profiler save:

profile-20230125T174847.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 16h 29min 12s | max lag: 4.83s | clients (25/42): AliasAlreadyTaken, AspireMint, Bailiff, BibaBoba, CaramelPlant, daydream, debiankaios, drgn, flux, flux_testing, jakob, michi16bit, niceride, OSSAMA, Papi, Parrish, Pllfvkvkfv, Pocrom, rheo, Service, shanish2, shanish3, Silfr, Sysmatic, yo_hi

Teleport command:

/teleport xyz 1019 51 818

Compass command:

/give_compass Construction HUc2RjWFq8BjpzqS0mS9wcKKc5bM6O65 D2691E 1019 51 818

debiankaios reports a bug: > the old gold apple texture fit more and shouldn't replaced Player position: ``` { x = 1018.617980957, y = 50.5, z = 817.8740234375 } ``` Player look: ``` { x = 0.36068820953369, y = -0.89625430107117, z = -0.25813218951225 } ``` Player information: ``` { version_string = "5.7.0-dev-6377ce9-dirty", protocol_version = 41, ip_version = 6, min_rtt = 0.014000000432134, avg_rtt = 0.020999999716878, min_jitter = 0, max_jitter = 0.79699999094009, avg_jitter = 0.0010000001639128, connection_uptime = 464, serialization_version = 29, patch = 0, minor = 7, lang_code = "de", max_rtt = 0.81400001049042, state = "Active", formspec_version = 6, major = 5 } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", yl_commons_player_created = "1618169882", yl_commons_player_joined = "1674668474", played_time = "3950989", yl_commons_thankyou = "83", bitten = "0", punch_count = "56503", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1618169882", xp = "183293", hud_state = "on", placed_nodes = "91664", yl_church = "return {[\"last_death\"] = {[\"x\"] = 2041, [\"y\"] = 28838, [\"z\"] = 1515}, [\"last_heal\"] = 1674589936, [\"last_death_portal\"] = 1674422499}", ["stamina:exhaustion"] = "104", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_nether 1 28595\", \"shields:shield_crystal 1 28595\", \"3d_armor:boots_crystal 1 29220\", \"3d_armor:leggings_crystal 1 28595\", \"3d_armor:chestplate_crystal 1 28595\", \"\"}", arenalib_infobox_arenaID = "0", ["signslib:pos"] = "(1020,49,817)", digged_nodes = "230618", died = "394", inflicted_damage = "1100372", partychat = "party", crafted = "3490", repellant = "0", ["stamina:level"] = "18" } } ``` Log identifier ``` [MOD] yl_report log identifier = HUc2RjWFq8BjpzqS0mS9wcKKc5bM6O65 ``` Profiler save: ``` profile-20230125T174847.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 16h 29min 12s | max lag: 4.83s | clients (25/42): AliasAlreadyTaken, AspireMint, Bailiff, BibaBoba, CaramelPlant, daydream, debiankaios, drgn, flux, flux_testing, jakob, michi16bit, niceride, OSSAMA, Papi, Parrish, Pllfvkvkfv, Pocrom, rheo, Service, shanish2, shanish3, Silfr, Sysmatic, yo_hi ``` Teleport command: ``` /teleport xyz 1019 51 818 ``` Compass command: ``` /give_compass Construction HUc2RjWFq8BjpzqS0mS9wcKKc5bM6O65 D2691E 1019 51 818 ```

AliasAlreadyTaken was assigned by yourland-report

2023-01-25 17:48:47 +00:00

flux added the

1. kind/balancing

3. source/art

labels 2023-01-26 18:34:48 +00:00

flux commented

2023-01-26 18:35:25 +00:00

i like the new texture, though i don't have a strong opinion either way.

AliasAlreadyTaken commented

2023-01-26 21:23:43 +00:00

The old texture was replaced due to licensing issues, we cannot use it without running into the same licensing issues.

👍 1

niceride commented

2023-01-27 08:22:16 +00:00

Can we make the new texture with a better contrast against the healing tree? Previously the healing tree (yellowtree) looked so beautiful with contrasting yellow gold apples. Now it kind of looks like oranges and blends in. Not mad at the texture change but it really does alter the aesthetic of healing trees in-game.

AliasAlreadyTaken commented

2023-01-27 18:42:53 +00:00

We'll gladly take texture suggestions.

flux added

1. kind/other

and removed

1. kind/balancing

labels 2023-03-19 18:26:04 +00:00

whosit commented

2023-07-09 06:35:46 +00:00

My attempt to make gold yellow again X)

Just color shifted original, so license is this I suppose:

Created by XSSheep (CC BY-SA 4.0 - https://minecraft.curseforge.com/projects/pixel-perfection-freshly-updated) / Color corrected
  default_apple_gold.png

Leaf fits too :p
Maybe it's a bit too bright :) (yeah, they may look like they glow too much... Could be toned back down. Btw: maybe apple nodes should give off light too, like leaves do?)

My attempt to make gold yellow again X) Just color shifted original, so license is this I suppose: ``` Created by XSSheep (CC BY-SA 4.0 - https://minecraft.curseforge.com/projects/pixel-perfection-freshly-updated) / Color corrected default_apple_gold.png ``` Leaf fits too :p Maybe it's a bit too bright :) (yeah, they may look like they glow too much... Could be toned back down. Btw: maybe apple nodes should give off light too, like leaves do?)

default_apple_gold_yellow.png

4.5 KiB

gapple_comparison.png

709 KiB

flux commented

2023-07-09 21:16:12 +00:00

My attempt to make gold yellow again X)

looks fine to me. i guess you could PR yl_texturepack?

> My attempt to make gold yellow again X) looks fine to me. i guess you could PR yl_texturepack?

whosit commented

2023-07-09 22:03:49 +00:00

I'll do it, maybe after more people will approve this?

flux commented

2023-07-10 01:44:16 +00:00

I'll do it, maybe after more people will approve this?

maybe, but this is the sort of thing where we'll only hear gripes after its done =D if there's a lot, we can always revert.

> I'll do it, maybe after more people will approve this? maybe, but this is the sort of thing where we'll only hear gripes after its done =D if there's a lot, we can always revert.

flux referenced this issue from a commit

2023-07-10 16:13:53 +00:00

add modified default_apple_gold.png and license for it (#3)

niceride commented

2023-07-10 18:26:19 +00:00

...
Maybe it's a bit too bright :) (yeah, they may look like they glow too much... Could be toned back down. Btw: maybe apple nodes should give off light too, like leaves do?)

It does look a bit odd. The texture it is colour-corrected from was too reddish-brown (like what you would do if you took the shadows and shaded areas from polished gold and then made that the surface material). Having it be the brightest thing on the inventory bar is not too bad of a situation, considering how important it is in the balance of gameplay.

Attached: it is not a "peach" so that dark highlight is softened

> ... > Maybe it's a bit too bright :) (yeah, they may look like they glow too much... Could be toned back down. Btw: maybe apple nodes should give off light too, like leaves do?) It does look a bit odd. The texture it is colour-corrected from was too reddish-brown (like what you would do if you took the shadows and shaded areas from polished gold and then made that the surface material). Having it be the brightest thing on the inventory bar is not too bad of a situation, considering how important it is in the balance of gameplay. Attached: it is not a "peach" so that dark highlight is softened

apple_adjust.png

4.6 KiB

apple_adjust_compare.png

56 KiB

whosit commented

2023-07-10 18:53:17 +00:00

That dark highlight kinda makes it look "shiny", not just "glowing" like without it. But I agree it's probably could be improved too. Also, this is the commited version, I think it's slightly darker too:

default_apple_gold.png

4.9 KiB

Sign in to join this conversation.