rheo reports: feeding animals to heal ... #3616

Closed
opened 2023-01-25 04:01:05 +00:00 by yourland-report · 6 comments

rheo reports a bug:

[possible dupe] feeding animals to heal them still displays the wrong health value - it shows what they were at before the heal

Player position:

{
	x = 2093.3520507813,
	y = 1.5,
	z = 364.00900268555
}

Player look:

{
	x = -0.66011422872543,
	y = -0.45134481787682,
	z = -0.6004473567009
}

Player information:

{
	version_string = "5.7.0-dev-f6b3d0f5a-dirty",
	protocol_version = 41,
	ip_version = 6,
	min_rtt = 0.16099999845028,
	avg_rtt = 0.1710000038147,
	min_jitter = 0,
	max_jitter = 4.1409997940063,
	avg_jitter = 0,
	connection_uptime = 7353,
	lang_code = "",
	max_rtt = 4.3109998703003,
	state = "Active",
	serialization_version = 29,
	formspec_version = 6,
	patch = 0,
	minor = 7,
	major = 5
}

Player meta:

{
	fields = {
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		yl_commons_player_created = "1644205752",
		yl_commons_player_joined = "1674611938",
		played_time = "3300509",
		digged_nodes = "10447",
		bitten = "0",
		punch_count = "1019",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}",
		died = "2",
		yl_commons_thankyou = "33",
		["stamina:level"] = "0",
		["stamina:poisoned"] = "no",
		repellant = "0",
		hud_state = "off",
		["ocean_build.last_warning"] = "1.66814e+09",
		["stamina:exhaustion"] = "159",
		jointime = "1644205752",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"3d_armor:helmet_party\", \"\", \"\", \"\", \"\"}",
		arenalib_infobox_arenaID = "0",
		["signslib:pos"] = "(1954,17,1137)",
		inflicted_damage = "236550",
		["ocean_build.ocean_built"] = "6",
		crafted = "1470",
		partychat = "party",
		placed_nodes = "15870",
		xp = "0",
		["ethereal:fly_timer"] = "-99"
	}
}

Log identifier


[MOD] yl_report log identifier = hBUONOVl5x2zdL3LsVQZJKiO5yGZIQgP

Profiler save:

profile-20230125T040105.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 2h 44min 4s | max lag: 2.83s | clients (21/42): 9T9, AliasAlreadyTaken, Badmj, Bailiff, CaramelPlant, daydream, EnokiM, Flatulenator, flux, gorexx, HorusDamocles, niceride, paneg, Parrish, Penelopee, rheo, Service, shanish2, shanish3, Sokomine, sparrow

Teleport command:

/teleport xyz 2093 2 364

Compass command:

/give_compass Construction hBUONOVl5x2zdL3LsVQZJKiO5yGZIQgP D2691E 2093 2 364
rheo reports a bug: > [possible dupe] feeding animals to heal them still displays the wrong health value - it shows what they were at before the heal Player position: ``` { x = 2093.3520507813, y = 1.5, z = 364.00900268555 } ``` Player look: ``` { x = -0.66011422872543, y = -0.45134481787682, z = -0.6004473567009 } ``` Player information: ``` { version_string = "5.7.0-dev-f6b3d0f5a-dirty", protocol_version = 41, ip_version = 6, min_rtt = 0.16099999845028, avg_rtt = 0.1710000038147, min_jitter = 0, max_jitter = 4.1409997940063, avg_jitter = 0, connection_uptime = 7353, lang_code = "", max_rtt = 4.3109998703003, state = "Active", serialization_version = 29, formspec_version = 6, patch = 0, minor = 7, major = 5 } ``` Player meta: ``` { fields = { yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", yl_commons_player_created = "1644205752", yl_commons_player_joined = "1674611938", played_time = "3300509", digged_nodes = "10447", bitten = "0", punch_count = "1019", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}", died = "2", yl_commons_thankyou = "33", ["stamina:level"] = "0", ["stamina:poisoned"] = "no", repellant = "0", hud_state = "off", ["ocean_build.last_warning"] = "1.66814e+09", ["stamina:exhaustion"] = "159", jointime = "1644205752", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"3d_armor:helmet_party\", \"\", \"\", \"\", \"\"}", arenalib_infobox_arenaID = "0", ["signslib:pos"] = "(1954,17,1137)", inflicted_damage = "236550", ["ocean_build.ocean_built"] = "6", crafted = "1470", partychat = "party", placed_nodes = "15870", xp = "0", ["ethereal:fly_timer"] = "-99" } } ``` Log identifier ``` [MOD] yl_report log identifier = hBUONOVl5x2zdL3LsVQZJKiO5yGZIQgP ``` Profiler save: ``` profile-20230125T040105.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 2h 44min 4s | max lag: 2.83s | clients (21/42): 9T9, AliasAlreadyTaken, Badmj, Bailiff, CaramelPlant, daydream, EnokiM, Flatulenator, flux, gorexx, HorusDamocles, niceride, paneg, Parrish, Penelopee, rheo, Service, shanish2, shanish3, Sokomine, sparrow ``` Teleport command: ``` /teleport xyz 2093 2 364 ``` Compass command: ``` /give_compass Construction hBUONOVl5x2zdL3LsVQZJKiO5yGZIQgP D2691E 2093 2 364 ```
AliasAlreadyTaken was assigned by yourland-report 2023-01-25 04:01:05 +00:00
flux added the
1. kind/bug
3. source/mod upstream
ugh/petz
labels 2023-01-26 16:57:36 +00:00
Member
upstream issue: https://github.com/runsy/petz/issues/149
Member

upstream is fixed

upstream is fixed
flux added the
4. step/ready to QA test
label 2023-01-27 22:22:35 +00:00
Member

this was a regression of #24

this was a regression of #24
AliasAlreadyTaken added this to the 1.1.117.1 milestone 2023-01-27 23:04:49 +00:00
flux changed title from rheo reports: [dupe] feeding animals to heal ... to rheo reports: feeding animals to heal ... 2023-02-01 16:42:08 +00:00
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 2023-02-12 15:58:41 +00:00

QA

Upstream fixed it as "no message when its not fully healed". That's at least correct enough.

100% were a message with each feeding saying the current and maximum HP, but let's give it a pass.

QA Upstream fixed it as "no message when its not fully healed". That's at least correct enough. 100% were a message with each feeding saying the current and maximum HP, but let's give it a pass.
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-14 02:48:34 +00:00
Member

100% were a message with each feeding saying the current and maximum HP, but let's give it a pass.

previously, w/ each feeding, there was a message displayed showing the HP from before healing the mob, along w/ the maximum HP. it was definitely a bug. i am very thankful whenever runs fixes things, even if the description isn't quite right.

> 100% were a message with each feeding saying the current and maximum HP, but let's give it a pass. previously, w/ each feeding, there was a message displayed showing the HP from before healing the mob, along w/ the maximum HP. it was definitely a bug. i am very thankful whenever runs fixes things, even if the description isn't quite right.
Member

this is live, though i wish they gave an indication of how much health they had when not full.

this is live, though i wish they gave an indication of how much health they had when not full.
flux closed this issue 2023-04-25 19:07:33 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-25 19:07:43 +00:00
AliasAlreadyTaken was unassigned by flux 2023-04-25 19:07:47 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3616
No description provided.