mod emotion some commands are broken #3504

New Issue

AliasAlreadyTaken · 2023-01-13T00:13:38Z

AliasAlreadyTaken commented

2023-01-13 00:13:38 +00:00

Those commands are broken:

freeze
point
wave

Those commands are broken: ``` freeze point wave ```

AliasAlreadyTaken referenced this issue

2023-01-13 00:14:04 +00:00

Lupercus reports: freeze and howl commands are n ... #2599

AliasAlreadyTaken added the

1. kind/bug

3. source/mod upstream

labels 2023-01-13 00:15:23 +00:00

flux commented

2023-01-13 21:50:42 +00:00

hm. this seems to caused by the fix for #1686, though things worked just fine back when that PR was tested upstream, and it was tested by at least 3 separate people...

hm. this seems to caused by the fix for https://gitea.your-land.de/your-land/bugtracker/issues/1686, though things worked just fine back when that PR was tested upstream, and it was tested by at least 3 separate people...

flux added this to the flux's TODO list project 2023-01-13 21:50:50 +00:00

flux self-assigned this 2023-01-13 21:51:00 +00:00

flux commented

2023-01-13 22:57:03 +00:00

the cause is that the fix to emotes changed it from hard-coding assumptions about animations of player models, and instead uses player_api. however, when we use mods w/ other player models, not all of the animations are defined (namely, point, wave, and freeze).

the best solution is probably to PR skinsdb, 3d_armor, and petz, and add the emote animations to those mods.

the cause is that the fix to emotes changed it from hard-coding assumptions about animations of player models, and instead uses player_api. however, when we use mods w/ other player models, not all of the animations are defined (namely, point, wave, and freeze). the best solution is probably to PR skinsdb, 3d_armor, and petz, and add the emote animations to those mods.

AliasAlreadyTaken commented

2023-01-13 23:16:01 +00:00

Either that or a new mod that brings nothing but the model and everyone else has to depend on that.

flux commented

2023-01-13 23:24:36 +00:00

upstream PRs:

3d_armor: https://github.com/minetest-mods/3d_armor/pull/98
petz: https://github.com/runsy/petz/pull/145
skinsdb: https://github.com/minetest-mods/skinsdb/pull/82

upstream PRs: * [x] 3d_armor: https://github.com/minetest-mods/3d_armor/pull/98 * [x] petz: https://github.com/runsy/petz/pull/145 * [x] skinsdb: https://github.com/minetest-mods/skinsdb/pull/82

flux added the

4. step/blocked

label 2023-01-13 23:24:49 +00:00

flux commented

2023-01-13 23:34:37 +00:00

Either that or a new mod that brings nothing but the model and everyone else has to depend on that.

the problems is that each of these mods defines their own model, which necessarily defines its own animations. there's no (non-hacky) way to define the animations separately. some mod might even provide a model that turns the player into a horse, which might have a very different set of animations.

annoyingly, there's currently no way to to test whether the model a player is currently using implements a particular animation, which could at least be used to provide feedback ("e.g. you don't know how to wave in this form").

> Either that or a new mod that brings nothing but the model and everyone else has to depend on that. the problems is that each of these mods defines their own model, which necessarily defines its own animations. there's no (non-hacky) way to define the animations separately. some mod might even provide a model that turns the player into a horse, which might have a very different set of animations. annoyingly, there's currently no way to to test whether the model a player is currently using implements a particular animation, which could at least be used to provide feedback ("e.g. you don't know how to wave in this form").

flux commented

2023-01-23 20:05:27 +00:00

new upstream PR which supersedes the old one: https://github.com/runsy/petz/pull/145

flux added

4. step/ready to QA test

and removed

4. step/blocked

labels 2023-01-24 00:16:48 +00:00

flux commented

2023-01-24 00:16:55 +00:00

upstream merged! :)

🎉 1