"xocean:horn_block" is not a registered node! #3277

Closed
opened 2022-12-20 16:54:27 +00:00 by AliasAlreadyTaken · 11 comments
2022-12-19 12:31:16: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'xocean' in callback node_on_dig(): Runtime error from mod 'xocean' in callback node_after_destruct(): "xocean:horn_block" is not a registered node!
2022-12-19 12:31:16: ERROR[Main]: stack traceback:
2022-12-19 12:31:16: ERROR[Main]: 	[C]: in function 'set_node'
2022-12-19 12:31:16: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:782: in function </home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:781>
2022-12-19 12:31:16: ERROR[Main]: 	[C]: in function 'remove_node'
2022-12-19 12:31:16: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig'
2022-12-19 12:31:16: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289>
2022-12-19 12:31:16: ERROR[Main]: stack traceback:
2022-12-19 12:31:16: ERROR[Main]: 	[C]: in function 'remove_node'
2022-12-19 12:31:16: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig'
2022-12-19 12:31:16: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289>
``` 2022-12-19 12:31:16: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'xocean' in callback node_on_dig(): Runtime error from mod 'xocean' in callback node_after_destruct(): "xocean:horn_block" is not a registered node! 2022-12-19 12:31:16: ERROR[Main]: stack traceback: 2022-12-19 12:31:16: ERROR[Main]: [C]: in function 'set_node' 2022-12-19 12:31:16: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:782: in function </home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:781> 2022-12-19 12:31:16: ERROR[Main]: [C]: in function 'remove_node' 2022-12-19 12:31:16: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig' 2022-12-19 12:31:16: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289> 2022-12-19 12:31:16: ERROR[Main]: stack traceback: 2022-12-19 12:31:16: ERROR[Main]: [C]: in function 'remove_node' 2022-12-19 12:31:16: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig' 2022-12-19 12:31:16: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289> ```
Author
Owner

I remember we already fixed that, but seems to have snuck into the code again. I dumbfixed and removed that line.

I remember we already fixed that, but seems to have snuck into the code again. I dumbfixed and removed that line.
Author
Owner
https://github.com/starninjas/xocean/issues/2
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
3. source/mod upstream
labels 2022-12-20 16:55:49 +00:00
flux added the
4. step/at work
label 2022-12-21 04:05:08 +00:00
Member

this is what i spent the majority of my day working on today, and i haven't even fixed the issue w/ digging coral. today i spent time refractoring the mod so i can try to understand what the intentions are. i'm not sure upstream will accept my rework, but i should finish it tomorrow.

this is what i spent the majority of my day working on today, and i haven't even fixed the issue w/ digging coral. today i spent time refractoring the mod so i can try to understand what the intentions are. i'm not sure upstream will accept my rework, but i should finish it tomorrow.
flux added this to the flux's TODO list project 2022-12-21 04:06:39 +00:00
flux self-assigned this 2022-12-21 04:06:44 +00:00
Member
upstream PR https://github.com/starninjas/xocean/pull/9
flux added
4. step/blocked
and removed
4. step/at work
labels 2022-12-21 21:53:43 +00:00
Author
Owner
2023-03-08 11:15:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'xocean' in callback node_on_dig(): Runtime error from mod 'xocean' in callback node_after_destruct(): "xocean:horn_block" is not a registered node!
2023-03-08 11:15:08: ERROR[Main]: stack traceback:
2023-03-08 11:15:08: ERROR[Main]: 	[C]: in function 'set_node'
2023-03-08 11:15:08: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:782: in function </home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:781>
2023-03-08 11:15:08: ERROR[Main]: 	[C]: in function 'remove_node'
2023-03-08 11:15:08: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig'
2023-03-08 11:15:08: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289>
2023-03-08 11:15:08: ERROR[Main]: stack traceback:
2023-03-08 11:15:08: ERROR[Main]: 	[C]: in function 'remove_node'
2023-03-08 11:15:08: ERROR[Main]: 	/home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig'
2023-03-08 11:15:08: ERROR[Main]: 	...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289>
``` 2023-03-08 11:15:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'xocean' in callback node_on_dig(): Runtime error from mod 'xocean' in callback node_after_destruct(): "xocean:horn_block" is not a registered node! 2023-03-08 11:15:08: ERROR[Main]: stack traceback: 2023-03-08 11:15:08: ERROR[Main]: [C]: in function 'set_node' 2023-03-08 11:15:08: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:782: in function </home/mt/5.6.1/Minetest_live/bin/../mods/xocean/init.lua:781> 2023-03-08 11:15:08: ERROR[Main]: [C]: in function 'remove_node' 2023-03-08 11:15:08: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig' 2023-03-08 11:15:08: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289> 2023-03-08 11:15:08: ERROR[Main]: stack traceback: 2023-03-08 11:15:08: ERROR[Main]: [C]: in function 'remove_node' 2023-03-08 11:15:08: ERROR[Main]: /home/mt/5.6.1/Minetest_live/bin/../builtin/game/item.lua:511: in function 'old_node_dig' 2023-03-08 11:15:08: ERROR[Main]: ...test_live/bin/../mods/yl_commons/features/tool_alert.lua:295: in function <...test_live/bin/../mods/yl_commons/features/tool_alert.lua:289> ```
Member

as the upstream PR is stalled, fixed the crash in integration:

ec93c4ee25

as the upstream PR is stalled, fixed the crash in integration: https://gitea.your-land.de/your-land/yl_commons/commit/ec93c4ee25bea1610f10b7aa661eba21fcded524
flux added the
4. step/ready to QA test
label 2023-03-08 19:12:23 +00:00
Author
Owner

Maybe we should adopt the mod. Some servers still use xocean, they're probably happy about fixes, too.

Maybe we should give ourselves a deadline, when a PR isn't accepted upstream in due time, we'll consider the mod abandoned?

If so, let's open a protocol issue.

Maybe we should adopt the mod. Some servers still use xocean, they're probably happy about fixes, too. Maybe we should give ourselves a deadline, when a PR isn't accepted upstream in due time, we'll consider the mod abandoned? If so, let's open a protocol issue.
Member

Maybe we should adopt the mod. Some servers still use xocean, they're probably happy about fixes, too.

Maybe we should give ourselves a deadline, when a PR isn't accepted upstream in due time, we'll consider the mod abandoned?

If so, let's open a protocol issue.

i'd much rather YL adopt the mod than have to adopt it myself :)

> Maybe we should adopt the mod. Some servers still use xocean, they're probably happy about fixes, too. > > Maybe we should give ourselves a deadline, when a PR isn't accepted upstream in due time, we'll consider the mod abandoned? > > If so, let's open a protocol issue. i'd much rather YL adopt the mod than have to adopt it myself :)
Author
Owner

Adoption discussion in #3960

Adoption discussion in #3960
AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-13 19:38:31 +00:00
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-13 19:38:36 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-25 20:45:49 +00:00
flux removed this from the flux's TODO list project 2023-04-25 20:45:52 +00:00
flux removed their assignment 2023-04-25 20:45:54 +00:00
Member

this is live

this is live
flux closed this issue 2023-04-25 20:46:05 +00:00
flux removed the
4. step/blocked
label 2023-08-09 21:59:03 +00:00
Member

upstream has actually merged this

upstream has actually merged this
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3277
No description provided.