Delijah reports: if u dont have armor on while ... #3232

Closed
opened 2022-12-13 14:29:24 +00:00 by yourland-report · 5 comments

Delijah reports a bug:

if u dont have armor on while in ur werewolf form, ur skinn dissapears and ur kinda invisible

Player position:

{
	z = 1467.4279785156,
	x = 2002.6989746094,
	y = 29805.5
}

Player look:

{
	z = -0.83044016361237,
	x = 0.54757511615753,
	y = -0.10261892527342
}

Player information:

{
	patch = 1,
	lang_code = "de",
	state = "Active",
	formspec_version = 4,
	max_rtt = 5.2119998931885,
	version_string = "5.4.1",
	protocol_version = 39,
	ip_version = 6,
	major = 5,
	minor = 4,
	min_rtt = 0.026000000536442,
	avg_rtt = 0.028000000864267,
	min_jitter = 0,
	max_jitter = 3.8249998092651,
	avg_jitter = 0,
	connection_uptime = 6123,
	serialization_version = 28
}

Player meta:

{
	fields = {
		["ocean_build.ocean_built"] = "2",
		crafted = "979",
		["stamina:level"] = "11",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["stamina:poisoned"] = "no",
		punch_count = "5032",
		["stamina:exhaustion"] = "46.5",
		hud_state = "on",
		["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"sneak_glitch\"] = false, [\"gravity\"] = 1}",
		repellant = "0",
		yl_commons_player_created = "1670349065",
		yl_commons_player_joined = "1670935661",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 12150\", \"3d_armor:leggings_crystal 1 28040\", \"3d_armor:chestplate_crystal 1 27630\", \"3d_armor:boots_crystal 1 10710\", \"shields:shield_rainbow 1 22212\", \"\"}",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 3010, [\"x\"] = 7018, [\"y\"] = 20}, [\"last_death_portal\"] = 1670865009}",
		["petz:werewolf"] = "0",
		["petz:lycanthropy"] = "1",
		["petz:werewolf_clan_idx"] = "2",
		["petz:werewolf_vignette_id"] = "20",
		["ocean_build.last_warning"] = "1.67044e+09",
		yl_commons_thankyou = "4",
		inflicted_damage = "108962",
		jointime = "1670349065",
		xp = "17459",
		arenalib_infobox_arenaID = "0",
		partychat = "party",
		bitten = "0",
		["signslib:pos"] = "(2001,29650,1439)",
		played_time = "123014",
		digged_nodes = "12176",
		placed_nodes = "2286",
		died = "23"
	}
}

Log identifier


[MOD] yl_report log identifier = 1FdJNF8YM6ZOWXZZYGjk3TXSEwizzEkI

Profiler save:

profile-20221213T142923.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 11h 6min 51s | max lag: 2.72s | clients (21/42): AliasAlreadyTaken, Antimatter_76, asgardian, Bailiff, bizon, cypis, daydream, Delijah, Ecklair, ElusiveAstropath, FFleder, Giuseppe, labrat, Minetest13, NodeBreaker, NotWater, phillip, Service, sherkhan30452, super_polak, yo_hi

Teleport command:

/teleport xyz 2003 29806 1467

Compass command:

/give_compass Construction 1FdJNF8YM6ZOWXZZYGjk3TXSEwizzEkI D2691E 2003 29806 1467
Delijah reports a bug: > if u dont have armor on while in ur werewolf form, ur skinn dissapears and ur kinda invisible Player position: ``` { z = 1467.4279785156, x = 2002.6989746094, y = 29805.5 } ``` Player look: ``` { z = -0.83044016361237, x = 0.54757511615753, y = -0.10261892527342 } ``` Player information: ``` { patch = 1, lang_code = "de", state = "Active", formspec_version = 4, max_rtt = 5.2119998931885, version_string = "5.4.1", protocol_version = 39, ip_version = 6, major = 5, minor = 4, min_rtt = 0.026000000536442, avg_rtt = 0.028000000864267, min_jitter = 0, max_jitter = 3.8249998092651, avg_jitter = 0, connection_uptime = 6123, serialization_version = 28 } ``` Player meta: ``` { fields = { ["ocean_build.ocean_built"] = "2", crafted = "979", ["stamina:level"] = "11", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["stamina:poisoned"] = "no", punch_count = "5032", ["stamina:exhaustion"] = "46.5", hud_state = "on", ["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"new_move\"] = true, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"sneak_glitch\"] = false, [\"gravity\"] = 1}", repellant = "0", yl_commons_player_created = "1670349065", yl_commons_player_joined = "1670935661", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 12150\", \"3d_armor:leggings_crystal 1 28040\", \"3d_armor:chestplate_crystal 1 27630\", \"3d_armor:boots_crystal 1 10710\", \"shields:shield_rainbow 1 22212\", \"\"}", yl_church = "return {[\"last_death\"] = {[\"z\"] = 3010, [\"x\"] = 7018, [\"y\"] = 20}, [\"last_death_portal\"] = 1670865009}", ["petz:werewolf"] = "0", ["petz:lycanthropy"] = "1", ["petz:werewolf_clan_idx"] = "2", ["petz:werewolf_vignette_id"] = "20", ["ocean_build.last_warning"] = "1.67044e+09", yl_commons_thankyou = "4", inflicted_damage = "108962", jointime = "1670349065", xp = "17459", arenalib_infobox_arenaID = "0", partychat = "party", bitten = "0", ["signslib:pos"] = "(2001,29650,1439)", played_time = "123014", digged_nodes = "12176", placed_nodes = "2286", died = "23" } } ``` Log identifier ``` [MOD] yl_report log identifier = 1FdJNF8YM6ZOWXZZYGjk3TXSEwizzEkI ``` Profiler save: ``` profile-20221213T142923.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 11h 6min 51s | max lag: 2.72s | clients (21/42): AliasAlreadyTaken, Antimatter_76, asgardian, Bailiff, bizon, cypis, daydream, Delijah, Ecklair, ElusiveAstropath, FFleder, Giuseppe, labrat, Minetest13, NodeBreaker, NotWater, phillip, Service, sherkhan30452, super_polak, yo_hi ``` Teleport command: ``` /teleport xyz 2003 29806 1467 ``` Compass command: ``` /give_compass Construction 1FdJNF8YM6ZOWXZZYGjk3TXSEwizzEkI D2691E 2003 29806 1467 ```
AliasAlreadyTaken was assigned by yourland-report 2022-12-13 14:29:24 +00:00
flux added the
1. kind/bug
3. source/mod upstream
2. prio/elevated
labels 2022-12-13 17:54:22 +00:00
flux added this to the flux's TODO list project 2022-12-13 17:54:29 +00:00
Member

i'm surprised that glitchwolf doesn't have an issue in our tracker yet, but i can't find one. the issue is discussed in #777 and your-land/administration#135, but those are about player_animations and werewolf balancing.

upstream issue:

the source of the problem isn't integration between the werewolf and 3d_armor itself, it's the wieldview mod that shows what a player is holding. the bug is triggered when a player becomes a werewolf and then swaps what they're holding.

i'm surprised that glitchwolf doesn't have an issue in our tracker yet, but i can't find one. the issue is discussed in #777 and https://gitea.your-land.de/your-land/administration/issues/135, but those are about player_animations and werewolf balancing. upstream issue: * https://github.com/runsy/petz/issues/42 the source of the problem isn't integration between the werewolf and 3d_armor itself, it's the wieldview mod that shows what a player is holding. the bug is triggered when a player becomes a werewolf and then swaps what they're holding.
flux added the
4. step/blocked
label 2023-01-23 20:06:09 +00:00
Member
upstream PR https://github.com/runsy/petz/pull/145
flux added
4. step/ready to QA test
and removed
4. step/blocked
labels 2023-01-24 00:16:12 +00:00
Member

upstream merged! definitely needs QA still IMO.

upstream merged! definitely needs QA still IMO.
flux added this to the 1.1.117.1 milestone 2023-01-25 23:24:03 +00:00
AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118 2023-02-12 15:59:34 +00:00

QA

Tested with and without armor and during day->night and night->day. Attempted skin change while a werewolf. Looks good.

QA Tested with and without armor and during day->night and night->day. Attempted skin change while a werewolf. Looks good.
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-14 04:51:37 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-04-25 18:58:09 +00:00
flux removed this from the flux's TODO list project 2023-04-25 18:58:13 +00:00
AliasAlreadyTaken was unassigned by flux 2023-04-25 18:58:15 +00:00
Member

this is now live, though i've noticed that the with the combination of werewolf and playeranim, wielded_item doesn't seem to work right.

this is now live, though i've noticed that the with the combination of werewolf and playeranim, wielded_item doesn't seem to work right.
flux closed this issue 2023-04-25 20:36:38 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#3232
No description provided.