daydream reports: I just tried to put a cichlid ... #3185

New Issue

yourland-report · 2022-12-05T08:51:11Z

yourland-report commented

2022-12-05 08:51:11 +00:00

daydream reports a bug:

I just tried to put a cichlid into a fish tank and it just disappeared... is that a bug?

Player position:

{
	z = -9612.890625,
	x = -7855.6069335938,
	y = 9.5
}

Player look:

{
	z = -0.91105157136917,
	x = -0.10541244596243,
	y = -0.3985889852047
}

Player information:

{
	major = 5,
	min_rtt = 0.16200000047684,
	avg_rtt = 0.17200000584126,
	min_jitter = 0,
	max_jitter = 1.597000002861,
	avg_jitter = 0.0040000081062317,
	connection_uptime = 57811,
	serialization_version = 29,
	patch = 1,
	max_rtt = 1.7719999551773,
	state = "Active",
	version_string = "5.6.1",
	protocol_version = 41,
	formspec_version = 6,
	ip_version = 6,
	minor = 6,
	lang_code = ""
}

Player meta:

{
	fields = {
		yl_church = "return {[\"last_death_portal\"] = 1669827109, [\"last_death\"] = {[\"z\"] = 1637, [\"x\"] = 1968, [\"y\"] = 30}}",
		hud_state = "on",
		arenalib_infobox_arenaID = "0",
		digged_nodes = "1161581",
		["petz:werewolf"] = "0",
		yl_commons_player_joined = "1670172495",
		["ocean_build.ocean_built"] = "8",
		["stamina:exhaustion"] = "38",
		xp = "976132",
		["stamina:poisoned"] = "no",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		jointime = "1650064821",
		bitten = "0",
		yl_commons_player_created = "1650064821",
		["stamina:level"] = "12",
		repellant = "0",
		["petz:werewolf_clan_idx"] = "2",
		["ocean_build.last_warning"] = "1.65235e+09",
		["petz:werewolf_vignette_id"] = "5",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:lycanthropy"] = "0",
		played_time = "10198284",
		xp_redo_hud_color = "0xFFC001",
		placed_nodes = "165300",
		died = "163",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 540\", \"shields:shield_rainbow 1 216\", \"3d_armor:chestplate_crystal 1 540\", \"3d_armor:leggings_crystal 1 540\", \"3d_armor:boots_crystal 1 540\", \"\"}",
		crafted = "2105",
		partychat = "party",
		punch_count = "47511",
		["signslib:pos"] = "(215,4,22485)",
		inflicted_damage = "936564",
		yl_commons_thankyou = "146"
	}
}

Log identifier


[MOD] yl_report log identifier = zuTurC2YAttvHxMf4II1T4MWczPgkkGC

Profiler save:

profile-20221205T085111.json_prettyEE

Status:

# Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 23h 43min 43s | max lag: 1.99s | clients (15/42): 9T9, AliasAlreadyTaken, Bailiff, daydream, ecki, Inuzuku, NodeBreaker, ourland, Parrish, PixelMan, Service, set, sherkhan30452, tf3st, tntyeeter1

Teleport command:

/teleport xyz -7856 10 -9613

Compass command:

/give_compass Construction zuTurC2YAttvHxMf4II1T4MWczPgkkGC D2691E -7856 10 -9613

daydream reports a bug: > I just tried to put a cichlid into a fish tank and it just disappeared... is that a bug? Player position: ``` { z = -9612.890625, x = -7855.6069335938, y = 9.5 } ``` Player look: ``` { z = -0.91105157136917, x = -0.10541244596243, y = -0.3985889852047 } ``` Player information: ``` { major = 5, min_rtt = 0.16200000047684, avg_rtt = 0.17200000584126, min_jitter = 0, max_jitter = 1.597000002861, avg_jitter = 0.0040000081062317, connection_uptime = 57811, serialization_version = 29, patch = 1, max_rtt = 1.7719999551773, state = "Active", version_string = "5.6.1", protocol_version = 41, formspec_version = 6, ip_version = 6, minor = 6, lang_code = "" } ``` Player meta: ``` { fields = { yl_church = "return {[\"last_death_portal\"] = 1669827109, [\"last_death\"] = {[\"z\"] = 1637, [\"x\"] = 1968, [\"y\"] = 30}}", hud_state = "on", arenalib_infobox_arenaID = "0", digged_nodes = "1161581", ["petz:werewolf"] = "0", yl_commons_player_joined = "1670172495", ["ocean_build.ocean_built"] = "8", ["stamina:exhaustion"] = "38", xp = "976132", ["stamina:poisoned"] = "no", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", jointime = "1650064821", bitten = "0", yl_commons_player_created = "1650064821", ["stamina:level"] = "12", repellant = "0", ["petz:werewolf_clan_idx"] = "2", ["ocean_build.last_warning"] = "1.65235e+09", ["petz:werewolf_vignette_id"] = "5", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:lycanthropy"] = "0", played_time = "10198284", xp_redo_hud_color = "0xFFC001", placed_nodes = "165300", died = "163", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 540\", \"shields:shield_rainbow 1 216\", \"3d_armor:chestplate_crystal 1 540\", \"3d_armor:leggings_crystal 1 540\", \"3d_armor:boots_crystal 1 540\", \"\"}", crafted = "2105", partychat = "party", punch_count = "47511", ["signslib:pos"] = "(215,4,22485)", inflicted_damage = "936564", yl_commons_thankyou = "146" } } ``` Log identifier ``` [MOD] yl_report log identifier = zuTurC2YAttvHxMf4II1T4MWczPgkkGC ``` Profiler save: ``` profile-20221205T085111.json_prettyEE ``` Status: ``` # Server: version: 5.6.1-yl | game: Minetest Game | uptime: 3d 23h 43min 43s | max lag: 1.99s | clients (15/42): 9T9, AliasAlreadyTaken, Bailiff, daydream, ecki, Inuzuku, NodeBreaker, ourland, Parrish, PixelMan, Service, set, sherkhan30452, tf3st, tntyeeter1 ``` Teleport command: ``` /teleport xyz -7856 10 -9613 ``` Compass command: ``` /give_compass Construction zuTurC2YAttvHxMf4II1T4MWczPgkkGC D2691E -7856 10 -9613 ```

AliasAlreadyTaken was assigned by yourland-report

2022-12-05 08:51:11 +00:00

flux added the

1. kind/bug

4. step/needs confirmation

labels 2022-12-07 19:19:24 +00:00

flux commented

2022-12-07 19:20:07 +00:00

i have no idea how the fish tank mechanics work, or which fish work with it. but i think we've got 4 mods that each add fish. i think the cichlid is from ethereal.

Squawk commented

2022-12-27 00:57:37 +00:00

I confirmed this bug with a clownfish in a tank. The fish was visible for a few seconds, and then disappeared.

flux commented

2022-12-27 20:46:03 +00:00

after doing some testings, i've discovered that

the fishtank is incredibly buggy.

i can't figure out how placing fishtank nodes is supposed to work. when trying to build a multinode fishtank, half the time it seems to place the node on the opposite side from where i clicked (!?)
i can't figure out how breaking fishtank nodes is supposed to work. you have to use a sword, and sometimes it doesn't work?
is the hitbox not a full node? that partially explains the issues...

sometimes placing a fish in the fishtank will actually drop it in the world, instead of putting it in the tank, and it will suffocate and die.
trying to place a cichlid (or another non-petz fish) in the fishtank doesn't work, and you tend to eat the fish.

after doing some testings, i've discovered that 1. the fishtank is *incredibly* buggy. * i can't figure out how placing fishtank nodes is supposed to work. when trying to build a multinode fishtank, half the time it seems to place the node on the *opposite side* from where i clicked (!?) * i can't figure out how breaking fishtank nodes is supposed to work. you have to use a sword, and sometimes it doesn't work? * is the hitbox not a full node? that partially explains the issues... 2. sometimes placing a fish in the fishtank will actually drop it in the world, instead of putting it in the tank, and it will suffocate and die. 3. trying to place a cichlid (or another non-petz fish) in the fishtank doesn't work, and you tend to eat the fish.

flux added

3. source/mod upstream

ugh/petz

and removed

4. step/needs confirmation

labels 2022-12-27 20:50:21 +00:00

flux commented

2022-12-27 21:09:23 +00:00

created an upstream issue: https://github.com/runsy/petz/issues/134

given the status of runs' most recent bugfixes for teleporting petz (currently you can't place petz indoors, and placing petz outdoors teleports them into the sky where they fall to their death), i'm worried that somehow this will actually make things worse...

created an upstream issue: https://github.com/runsy/petz/issues/134 given the status of runs' most recent bugfixes for teleporting petz (currently you can't place petz indoors, and placing petz outdoors teleports them into the sky where they fall to their death), i'm worried that somehow this will actually make things *worse*...

flux commented

2023-01-01 21:05:36 +00:00

upstream, the size of the fishtank has been fixed, but it does not give a message about trying to place non-petz fish in the tank. if runs declines to do that, i'll probably patch something on top.

flux added the

4. step/ready to QA test

4. step/partially fixed

labels 2023-01-01 21:06:16 +00:00

flux commented

2023-01-25 23:23:28 +00:00

most of this is live.

implemented an alert: af440ff4ff

most of this is live. implemented an alert: https://gitea.your-land.de/your-land/yl_commons/commit/af440ff4ff019872b85c465332b5c70824258cb0

flux added this to the 1.1.117.1 milestone 2023-01-25 23:24:11 +00:00

flux referenced this issue

2023-02-01 16:48:03 +00:00

1.1.118 #3401

AliasAlreadyTaken modified the milestone from 1.1.117.1 to 1.1.118

2023-02-12 15:59:40 +00:00

AliasAlreadyTaken referenced this issue

2023-04-14 04:54:52 +00:00

Allow all kinds of fish be put in the fishtank #4186

AliasAlreadyTaken commented

2023-04-14 04:55:27 +00:00

QA

While the changes didn't allow cichlids be placed in the fishtank, at least there's now an explanation.

If we want the fishtank to take more kind of fish, we should gather all kinds of fish of all kinds of mods and allow them be put in, short of dolphins, sharks and whales.

This is beyond the scope of this issue but we can discuss here: #4186

QA While the changes didn't allow cichlids be placed in the fishtank, at least there's now an explanation. If we want the fishtank to take more kind of fish, we should gather all kinds of fish of all kinds of mods and allow them be put in, short of dolphins, sharks and whales. This is beyond the scope of this issue but we can discuss here: #4186

AliasAlreadyTaken added the

ugh/QA OK

label 2023-04-14 04:55:33 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

4. step/partially fixed

labels 2023-04-25 18:57:39 +00:00

AliasAlreadyTaken was unassigned by flux

2023-04-25 18:57:42 +00:00

flux commented