Suggestion: Lua Runtime Strictness #3119

New Issue

sherkhan30452 · 2022-11-23T11:57:07Z

sherkhan30452 commented

2022-11-23 11:57:07 +00:00

Runtime Strictness
https://content.minetest.net/packages/LMD/strictest/

Disallows questionable usage of the Lua API & Lua itself to help catch errors.

Description:
Runtime Strictness for Minetest Mods

Strictest consists of two components:

Lua strictness: Will disallow string indexing and string - number coercion.
Minetest strictness: Disallows usage of deprecated APIs & using entity-only or player-only methods on the wrong type of object.

Particularly useful when writing new mods that don't target older Minetest versions.

Runtime Strictness https://content.minetest.net/packages/LMD/strictest/ Disallows questionable usage of the Lua API & Lua itself to help catch errors. Description: Runtime Strictness for Minetest Mods Strictest consists of two components: Lua strictness: Will disallow string indexing and string - number coercion. Minetest strictness: Disallows usage of deprecated APIs & using entity-only or player-only methods on the wrong type of object. Particularly useful when writing new mods that don't target older Minetest versions.

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-11-23 12:02:50 +00:00

flux commented

2022-11-24 04:08:20 +00:00

Will disallow string indexing and string - number coercion.

when are these useful? lua is already rather strict, i can't recall a bug i blamed on such a feature.

Particularly useful when writing new mods that don't target older Minetest versions.

the server generally runs the latest stable version, why should we care?

> Will disallow string indexing and string - number coercion. when are these useful? lua is already rather strict, i can't recall a bug i blamed on such a feature. > Particularly useful when writing new mods that don't target older Minetest versions. the server generally runs the latest stable version, why should we care?

Bla commented

2022-11-24 09:51:34 +00:00

stuff that does shenanigans shouldn´t end up on the server so that mod wouldn´t be helpful there.
maybe useful in a dev environment but for me it would make more sense to add those things to luacheck or similar in your code editor to get a warning even before you start minetest.

stuff that does shenanigans shouldn´t end up on the server so that mod wouldn´t be helpful there. maybe useful in a dev environment but for me it would make more sense to add those things to luacheck or similar in your code editor to get a warning even before you start minetest.

flux added

and removed

labels 2022-11-24 15:42:17 +00:00

flux commented

2022-11-24 15:42:28 +00:00

(again, i need to not respond to things when i'm half asleep, i didn't properly understand this)

this is the sort of thing that ought to be run by developers in their local environment, not on a live server.

also, triggering errors for use of deprecated API is already a config option:

1c10988d6a/builtin/settingtypes.txt (L1583-L1587)

however, your-land depends on a lot of mods which haven't seen active development in a long time, and use deprecated API calls. cleaning all that up is something i've had in the back of my head for a while, but there's been more important things to care about.

(again, i need to not respond to things when i'm half asleep, i didn't properly understand this) this is the sort of thing that ought to be run by *developers* in their *local* environment, not on a live server. also, triggering errors for use of deprecated API is already a config option: * https://github.com/minetest/minetest/blob/1c10988d6a19b06ac9c64e83675a76dea29cad2e/builtin/settingtypes.txt#L1583-L1587 however, your-land depends on a *lot* of mods which haven't seen active development in a long time, and use deprecated API calls. cleaning all that up is something i've had in the back of my head for a while, but there's been more important things to care about.

AliasAlreadyTaken commented

2023-01-12 23:06:59 +00:00

This is basically a question how to deal with depreciation messages in abandoned upstream mods.

Let's NOT add Lua Runtime Strictness to the live server
Let's discuss how to deal with deprecated mods here: your-land/administration#180

This is basically a question how to deal with depreciation messages in abandoned upstream mods. 1. Let's NOT add Lua Runtime Strictness to the live server 2. Let's discuss how to deal with deprecated mods here: https://gitea.your-land.de/your-land/administration/issues/180

AliasAlreadyTaken closed this issue

2023-01-12 23:07:00 +00:00

AliasAlreadyTaken added the

5. result/wontfix

label 2023-01-12 23:07:07 +00:00

Sign in to join this conversation.