Suggestion: Configurable Traders (for NPC shops) #3117

New Issue

sherkhan30452 · 2022-11-23T08:25:20Z

sherkhan30452 commented

2022-11-23 08:25:20 +00:00

Traders
Configurable mobs/NPC which can trade for you.
https://content.minetest.net/packages/Sokomine/mobf_trader/

I saw some shops in outside gates of 'Viskateel' were planned to be opened, without making use of smartshop. So, I think this is a great idea.

Traders Configurable mobs/NPC which can trade for you. https://content.minetest.net/packages/Sokomine/mobf_trader/ I saw some shops in outside gates of 'Viskateel' were planned to be opened, without making use of smartshop. So, I think this is a great idea.

AliasAlreadyTaken commented

2022-11-23 10:05:05 +00:00

The very Sokomine is working towards enhancing yl_speak_up to become a better NPC mod, which also allows sales.

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-11-23 10:05:11 +00:00

flux commented

2022-11-24 02:07:18 +00:00

i wonder if i could abstract the smartshop API to allow soko's mobs to make use of existing smartshop functionality. hmmm....

flux added this to the flux's TODO list project 2022-11-24 02:07:22 +00:00

flux added the

2. prio/interesting

label 2022-11-24 02:07:32 +00:00

Sokomine commented

2022-11-24 05:45:50 +00:00

Perhaps. The yl_speak_up NPC are a bit diffrent regarding trading. In some ways they are more capable than smartshops, in some less.

My mobf_trader mod was probably too complicated regarding setting up trades. Due to lack of...space...I used the inventory of the player to set up the trades, which...wasn't understood by many players. The yl_speak_up traders use a very simple formspec which can't do much more than the smartshops. They can only trade one item(stack) for another - and not packages of multiple items per trade.

They can however offer a lot more than 4 trades each.

Limits can be set for the maximum and minimum amount of each item that the NPC wants to buy or sell. If he doesn't have enough, he doesn't sell the item anymore. If he has too much, he doesn't buy.

Another very useful feature is that each time a player asks for the list of trades the options of the dialog d_trade are checked. That way it is possible to react to shortages and let the NPC for example craft something he needs - or to take something from a chest or put something into a chest. This is hopefully useful for things where the demand isn't known in advance. It may also help to deal with the limited inventory space the NPC have.

I'd highly appreciate if this trading feature could be tested more! Please join the NPC test server on the same IP as YL, but port 30003, get an egg from farmer Fred, place it somewhere you can and teach it to trade, please!

Testing of the trading features is highly welcome.

Perhaps. The yl_speak_up NPC are a bit diffrent regarding trading. In some ways they are more capable than smartshops, in some less. My mobf_trader mod was probably too complicated regarding setting up trades. Due to lack of...space...I used the inventory of the player to set up the trades, which...wasn't understood by many players. The yl_speak_up traders use a very simple formspec which can't do much more than the smartshops. They can only trade one item(stack) for another - and not packages of multiple items per trade. They can however offer a lot more than 4 trades each. Limits can be set for the maximum and minimum amount of each item that the NPC wants to buy or sell. If he doesn't have enough, he doesn't sell the item anymore. If he has too much, he doesn't buy. Another very useful feature is that each time a player asks for the list of trades the options of the dialog d_trade are checked. That way it is possible to react to shortages and let the NPC for example craft something he needs - or to take something from a chest or put something into a chest. This is hopefully useful for things where the demand isn't known in advance. It may also help to deal with the limited inventory space the NPC have. I'd highly appreciate if this trading feature could be tested more! Please join the NPC test server on the same IP as YL, but port 30003, get an egg from farmer Fred, place it somewhere you can and teach it to trade, please! Testing of the trading features is highly welcome.

flux removed this from the flux's TODO list project 2022-11-30 16:02:42 +00:00

Boot commented

2022-12-01 17:53:34 +00:00

Testing of the trading features is highly welcome.

In my opinion, the trading function on the NPCs on the test server is already the easiest part to adjust. Maybe there should be two different NPCs. Once the full variant and next to it just this already well usable simple NPC dealer.

> Testing of the trading features is highly welcome. In my opinion, the trading function on the NPCs on the test server is already the easiest part to adjust. Maybe there should be two different NPCs. Once the full variant and next to it just this already well usable simple NPC dealer.

flux commented

2022-12-02 05:43:47 +00:00

after more consideration, i decided it's best to keep the NPC store and smartshops semantically distinct. soko's point that NPCs can do a lot more than a smartshop is very important. if someone wants to have an NPC w/ a smartshop interface, they can very easily have an NPC AND a smartshop next to them.

after more consideration, i decided it's best to keep the NPC store and smartshops semantically distinct. soko's point that NPCs can do a lot more than a smartshop is very important. if someone wants to have an NPC w/ a smartshop interface, they can very easily have an NPC *AND* a smartshop next to them.

sherkhan30452 commented

2022-12-05 19:23:20 +00:00

after more consideration, i decided it's best to keep the NPC store and smartshops semantically distinct. soko's point that NPCs can do a lot more than a smartshop is very important. if someone wants to have an NPC w/ a smartshop interface, they can very easily have an NPC AND a smartshop next to them.

However there is a limitation, you can't exchange one item for multiple items, for example if you want to sell say one rainbow ore, I want it to sell for 1 gold ingot, 50 silver ingot.

This screenshot explains my point

> after more consideration, i decided it's best to keep the NPC store and smartshops semantically distinct. soko's point that NPCs can do a lot more than a smartshop is very important. if someone wants to have an NPC w/ a smartshop interface, they can very easily have an NPC *AND* a smartshop next to them. However there is a limitation, you can't exchange one item for multiple items, for example if you want to sell say one rainbow ore, I want it to sell for 1 gold ingot, 50 silver ingot. This screenshot explains my point ![](https://content.minetest.net/uploads/B7B1mpBrjG.png)

~~sherkhan30452 referenced this issue 2022-12-06 07:03:54 +00:00~~

Suggestion: Minecart with Storage (requires Hopper) #3113

Sokomine commented

2022-12-11 18:57:14 +00:00

sherkhan30452: Yes, I'm aware that my traders mod is more versatile and can do more. For the NPC here I've limited it deliberately because too many players did not understand how to set up the traders. So they're easier (and sadly thus more limited) here. They also try to fit their offers into the small text box at the bottom.