Autocrafter Segfault #2816
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#2816
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
found by rabenkind.
When I take the result out of an autocrafter which is placed in an area, the server segfaults. Without the area, it works.
[38007.336689] Server[110138]: segfault at 7f6c662760ce ip 000055e2bf43277b sp 00007f6ba380ad30 error 4 in minetestserver[55e2bf0d8000+456000]
[38007.336703] Code: 85 a0 f7 ff ff 00 00 00 00 c7 85 94 f7 ff ff 00 00 00 00 44 0f bf 43 58 4d 8b 2e 4c 89 c0 48 c1 e0 05 4c 29 c0 4d 8d 6c c5 00 <41> 0f b7 55 20 66 44 39 ca 0f 83 11 19 00 00 66 89 93 b2 00 00 00
Repro:
=> Server crash
Tested pipeworks versions:
latest release from content db, release = 7488
yl 07e7e0e6e5 aka 20e81e67a0
areas latest release from content db, release = 5030
my tests:
removed unified inventory, got 5.5.1 to crash:
possibly related upstream:
can't reproduce when pipeworks and areas are the only 2 mods installed...
figured out how to reproduce it w/ minimal mods, and in 5.6.1 as well (so it's not fixed)
https://your-land.de/res/2022-10-05%2018-04-14.mkv
i've updated https://github.com/minetest/minetest/issues/11805 w/ the info i've been able to dig up. might take a peek at fixing it, but i'm not sure i'll be able to do that effectively
it appears that exist upstream PR https://github.com/minetest/minetest/pull/11882 fixes the issue; guessing it'll make it into 5.7, or we can patch it in if it's urgent.
was not able to replicate the issue on tunnelers' abyss
can't replicate on pandorabox
if anyone could explain to me what
Code: 85 a0 f7 ff ff 00 00 00 00 c7 85 94 f7 ff ff 00 00 00 00 44 0f bf 43 58 4d 8b 2e 4c 89 c0 48 c1 e0 05 4c 29 c0 4d 8d 6c c5 00 <41> 0f b7 55 20 66 44 39 ca 0f 83 11 19 00 00 66 89 93 b2 00 00 00
means, i'd give you a dollar, if i had any money to give. i hate being fed machine code in an error, when i'm not a machine.maybe it's saying i need to use these numbers to buy a lottery ticket?
Maybe we should build at least the testserver not as Release, but as full debug build?
that's actually probably a good idea.
I doubt it's of much use, but here you go:
i triggered this again, by accident, just now.
The testserver is now on DCMAKE_BUILD_TYPE=Debug and - by accident - 5.7.0, but now I can't reproduce it!
There we are again
[ 256.455538] Server[3167]: segfault at 7fd5fc2c8 ip 000055ccf4cd517e sp 00007fd6196c1db0 error 4 in minetestserver[55ccf4982000+44d000]
[ 256.455862] Code: 66 44 89 93 b2 00 00 00 83 bd 9c f7 ff ff ff 0f 85 8c 12 00 00 0f bf 7b 58 4d 8b 0e 48 89 f8 48 c1 e0 05 48 29 f8 4d 8d 2c c1 <45> 0f b7 55 20 66 44 3b 95 a8 f7 ff ff 73 10 66 44 89 93 b2 00 00
It also happens when the autocrafter is off.
But I still have no idea, how to reproduce this
@Murmel did you look at https://github.com/minetest/minetest/issues/11805?
No I didn't until you mention. But as far is i understand, in the reported issue the autocrafter is turned on, when the error occurs. So I tried to be sure it is turned off, when I move items but still the server crashes.
Maybe this happens when it's laggy so the autocrafter only seems to be turned off but the server first gets the moving action and after the the signal to turn the autocrafter off?
Today i always waited a while after tuning it off, maybe this helps to avoid further crashes?
edit:
Mhhh, it does not.
I turned the autocrafter off and waited a while as I did more than one time before today.
Then I tried to clean the recipe, first by clearing the result-box which had no effect.
I closed the autocrafter after that, opened it after a moment and tried clearing the recipe by moving items from the left which resulted in a crash.
I think I will empty that autocrafter at a time not too many players are online and stop using it until we have an idea how to stop this behaviour.
Funny thing is: I have this one for a while now and crashes happen to occur just in the last few (probably three) days.
2nd edit: when the server was online i had a view in this autocrafter and it was turned on. So it seems my Idea, that the server did not get the turning off seems to be true.
For whatever reason this happened during the last couple of days a lot more than in the past couple of month. Those are only the recorded segfaults after a server restart:
temporarily disabled clearing the crafting recipes via the output slot of the autocrafter, until the engine fix goes live:
3af3478bd7
2023-01-16 09:04:25: ACTION[Main]: Server: Shutting down
2023-01-16 09:04:27: ERROR[Main]: ModError: Failed to load and run script from /home/mt/5.6.1/Minetest_test/bin/../mods/yl_commons/init.lua:
2023-01-16 09:04:27: ERROR[Main]: ...mods/yl_commons/bugfixes/autocrafter_inventory_crash.lua:11: attempt to call field 'override_node' (a nil value)
2023-01-16 09:04:27: ERROR[Main]: stack traceback:
2023-01-16 09:04:27: ERROR[Main]: ...mods/yl_commons/bugfixes/autocrafter_inventory_crash.lua:11: in main chunk
2023-01-16 09:04:27: ERROR[Main]: [C]: in function 'dofile'
2023-01-16 09:04:27: ERROR[Main]: ...e/mt/5.6.1/Minetest_test/bin/../mods/yl_commons/init.lua:179: in function 'dofile'
2023-01-16 09:04:27: ERROR[Main]: ...1/Minetest_test/bin/../mods/yl_commons/bugfixes/init.lua:8: in main chunk
2023-01-16 09:04:27: ERROR[Main]: [C]: in function 'dofile'
2023-01-16 09:04:27: ERROR[Main]: ...e/mt/5.6.1/Minetest_test/bin/../mods/yl_commons/init.lua:179: in function 'dofile'
2023-01-16 09:04:27: ERROR[Main]: ...e/mt/5.6.1/Minetest_test/bin/../mods/yl_commons/init.lua:188: in main chunk
Fixed
294a6e39ef
the patch is in place, considering this fixed, even though the engine issue isn't resolved yet.
https://github.com/joe7575/techage/issues/117
upstream PR has been closed as abandoned :(