persistent INV position #2743

Closed
opened 2022-09-22 13:40:54 +00:00 by daydream · 10 comments
Member

I wonder if players would like the inventory to remember it's position from last time open, such as Bag 3 was open, so when entering 'i' again it is open to Bag 3 or even open to 3Darmor tab or whatever?

I wonder if players would like the inventory to remember it's position from last time open, such as Bag 3 was open, so when entering 'i' again it is open to Bag 3 or even open to 3Darmor tab or whatever?
flux added the
1. kind/enhancement
4. step/question
3. source/mod upstream
labels 2022-09-22 17:54:21 +00:00
Member

i remember a time where it worked like this - it remembered the last thing you were looking at.

after some testing,

  1. it still works like this by default
  2. it doesn't work like this on my local YL clone
  3. it's not due to any recent change to unified_inventory
  4. it's not a setting

i suspect unified_inventory_plus might be doing some shenanigans? other than that, no idea.

edit: it's not unified_inventory_plus

i remember a time where it worked like this - it remembered the last thing you were looking at. after some testing, 1. it still works like this by default 2. it doesn't work like this on my local YL clone 3. it's not due to any recent change to unified_inventory 4. it's not a setting i suspect unified_inventory_plus might be doing some shenanigans? other than that, no idea. edit: it's not unified_inventory_plus
flux added the
2. prio/elevated
label 2022-09-22 18:10:45 +00:00
flux added this to the flux's TODO list project 2022-09-22 19:10:54 +00:00
flux self-assigned this 2022-09-22 19:11:06 +00:00
flux added
3. source/integration
and removed
3. source/mod upstream
labels 2022-09-23 00:39:49 +00:00
Member

mods which need to be checked because they interact w/ unified_inventory or player:set_inventory_formspec

  • 3d_armor
  • biome_lib
  • canned_food
  • chesttools
  • digistuff
  • jonez
  • mail_mod
  • meseportals
  • moreblocks
  • moretrees
  • personal_log
  • pipeworks
  • pvpplus
  • skinsdb
  • unified_inventory
  • unified_inventory_plus
  • water_life
  • wine
  • worldedit
  • yl_commons
  • yl_easter
  • yl_maze
mods which need to be checked because they interact w/ unified_inventory or `player:set_inventory_formspec` * [x] 3d_armor * [x] biome_lib * [x] canned_food * [x] chesttools * [x] digistuff * [x] jonez * [x] mail_mod * [x] meseportals * [x] moreblocks * [x] moretrees * [x] personal_log * [x] pipeworks * [x] pvpplus * [x] skinsdb * [x] unified_inventory * [x] unified_inventory_plus * [x] water_life * [x] wine * [x] worldedit * [x] yl_commons * [x] yl_easter * [x] yl_maze
Member

it's mail_mod. the question is "why"

it's mail_mod. the question is "why"
Member

created an upstream issue:

created an upstream issue: * https://github.com/mt-mods/mail/issues/22
flux added
3. source/mod upstream
4. step/at work
and removed
4. step/question
labels 2022-09-23 16:41:51 +00:00

it's mail_mod. the question is "why"

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

> it's mail_mod. the question is "why" probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug
Member
upstream PR: https://github.com/mt-mods/mail/pull/23
flux added
4. step/ready to QA test
and removed
4. step/at work
labels 2022-09-23 17:30:32 +00:00
Member

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

yup, the problems were related, my fix for this also fixed that. #1818

> probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug yup, the problems were related, my fix for this also fixed that. #1818

it's mail_mod. the question is "why"

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

Thanks!

> > it's mail_mod. the question is "why" > > probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug Thanks!
Member

upstream was merged, we just have to update ours

upstream was merged, we just have to update ours
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-09-24 17:11:18 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2022-11-15 22:36:20 +00:00
flux removed this from the flux's TODO list project 2022-11-15 22:36:23 +00:00
flux removed their assignment 2022-11-15 22:36:25 +00:00
Member

this is live.

this is live.
flux closed this issue 2022-11-15 22:36:33 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2743
No description provided.