persistent INV position #2743

Open
opened 1 week ago by daydream · 9 comments
Collaborator

I wonder if players would like the inventory to remember it's position from last time open, such as Bag 3 was open, so when entering 'i' again it is open to Bag 3 or even open to 3Darmor tab or whatever?

I wonder if players would like the inventory to remember it's position from last time open, such as Bag 3 was open, so when entering 'i' again it is open to Bag 3 or even open to 3Darmor tab or whatever?
flux added the
1. kind/enhancement
4. step/question
3. source/upstream
labels 1 week ago
Collaborator

i remember a time where it worked like this - it remembered the last thing you were looking at.

after some testing,

  1. it still works like this by default
  2. it doesn't work like this on my local YL clone
  3. it's not due to any recent change to unified_inventory
  4. it's not a setting

i suspect unified_inventory_plus might be doing some shenanigans? other than that, no idea.

edit: it's not unified_inventory_plus

i remember a time where it worked like this - it remembered the last thing you were looking at. after some testing, 1. it still works like this by default 2. it doesn't work like this on my local YL clone 3. it's not due to any recent change to unified_inventory 4. it's not a setting i suspect unified_inventory_plus might be doing some shenanigans? other than that, no idea. edit: it's not unified_inventory_plus
flux added the
2. prio/elevated
label 1 week ago
flux added this to the flux's TODO list project 1 week ago
flux self-assigned this 1 week ago
flux added
3. source/integration
and removed
3. source/upstream
labels 7 days ago
Collaborator

mods which need to be checked because they interact w/ unified_inventory or player:set_inventory_formspec

  • 3d_armor
  • biome_lib
  • canned_food
  • chesttools
  • digistuff
  • jonez
  • mail_mod
  • meseportals
  • moreblocks
  • moretrees
  • personal_log
  • pipeworks
  • pvpplus
  • skinsdb
  • unified_inventory
  • unified_inventory_plus
  • water_life
  • wine
  • worldedit
  • yl_commons
  • yl_easter
  • yl_maze
mods which need to be checked because they interact w/ unified_inventory or `player:set_inventory_formspec` * [x] 3d_armor * [x] biome_lib * [x] canned_food * [x] chesttools * [x] digistuff * [x] jonez * [x] mail_mod * [x] meseportals * [x] moreblocks * [x] moretrees * [x] personal_log * [x] pipeworks * [x] pvpplus * [x] skinsdb * [x] unified_inventory * [x] unified_inventory_plus * [x] water_life * [x] wine * [x] worldedit * [x] yl_commons * [x] yl_easter * [x] yl_maze
Collaborator

it's mail_mod. the question is "why"

it's mail_mod. the question is "why"
Collaborator

created an upstream issue:

created an upstream issue: * https://github.com/mt-mods/mail/issues/22
flux added
3. source/upstream
4. step/at work
and removed
4. step/question
labels 6 days ago
Collaborator

it's mail_mod. the question is "why"

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

> it's mail_mod. the question is "why" probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug
Collaborator
upstream PR: https://github.com/mt-mods/mail/pull/23
flux added
4. step/awaiting deployment
and removed
4. step/at work
labels 6 days ago
Collaborator

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

yup, the problems were related, my fix for this also fixed that. #1818

> probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug yup, the problems were related, my fix for this also fixed that. #1818

it's mail_mod. the question is "why"

probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug

Thanks!

> > it's mail_mod. the question is "why" > > probably the same reason as the "cant open inventory after closing mail formspec by ESC etc" bug Thanks!
Collaborator

upstream was merged, we just have to update ours

upstream was merged, we just have to update ours
AliasAlreadyTaken added this to the next milestone 5 days ago
Sign in to join this conversation.
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2743
Loading…
There is no content yet.