flux reports: tool warning/breaking mechanis ... #2724

New Issue

yourland-report · 2022-09-20T03:32:35Z

yourland-report commented

2022-09-20 03:32:35 +00:00

flux reports a bug:

tool warning/breaking mechanism, and protection violations, should ideally handle server lag at the least (which the server can measure), and also possibly client lag (not sure server code gets enough info to really see when that spikes)

Player position:

{
	x = 1288.7110595703,
	y = 47.700000762939,
	z = 624.0009765625
}

Player look:

{
	x = -0.36063626408577,
	y = 0.34005129337311,
	z = -0.86850821971893
}

Player information:

{
	protocol_version = 40,
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.15800000727177,
	max_rtt = 3.5829999446869,
	avg_rtt = 0.16699999570847,
	min_jitter = 0,
	max_jitter = 3.4189999103546,
	avg_jitter = 0.0050000101327896,
	connection_uptime = 44973,
	serialization_version = 29,
	patch = 0,
	minor = 6,
	version_string = "5.6.0",
	state = "Active",
	major = 5
}

Player meta:

{
	fields = {
		played_time = "23961752",
		inflicted_damage = "1703884",
		placed_nodes = "354230",
		["petz:werewolf_clan_idx"] = "1",
		crafted = "40302",
		jointime = "1615351173",
		["signslib:pos"] = "(1273,69,540)",
		yl_church = "return {[\"last_death_portal\"] = 1662955227, [\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"x\"] = 2154, [\"y\"] = -16671, [\"z\"] = 1535}}",
		bitten = "0",
		hud_state = "on",
		died = "70",
		repellant = "0",
		yl_commons_thankyou = "167",
		partychat = "party",
		digged_nodes = "1105928",
		arenalib_infobox_arenaID = "0",
		yl_commons_player_created = "1615351173",
		xp = "1295367",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		["petz:werewolf"] = "0",
		yl_commons_player_joined = "1663599803",
		["petz:lycanthropy"] = "1",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"nether_mobs:dragon_shield\", \"3d_armor:helmet_nether\", \"3d_armor:leggings_nether\", \"3d_armor:chestplate_nether\", \"\"}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:level"] = "17",
		punch_count = "100241",
		["stamina:poisoned"] = "no",
		["petz:werewolf_vignette_id"] = "20",
		["stamina:exhaustion"] = "105"
	}
}

Log identifier


[MOD] yl_report log identifier = KGiLhRx9xHKflJGZ4Tkiw5Jm6qHVp90h

Profiler save:

profile-20220920T033234.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 18h 26min 44s | max lag: 2.4s | clients: digdeep, wordes, HorusDamocles, Sokomine, DreamNotFound, Domough, Insomniacs_Yello, Laylem, Frostian, Kiyoko, catia, Bailiff, rheo, jackofthebean000, flux, MarseySeether, NodeBreaker

Teleport command:

/teleport xyz 1289 48 624

Compass command:

/give_compass Construction KGiLhRx9xHKflJGZ4Tkiw5Jm6qHVp90h D2691E 1289 48 624

flux reports a bug: > tool warning/breaking mechanism, and protection violations, should ideally handle server lag at the least (which the server can measure), and also possibly client lag (not sure server code gets enough info to really see when that spikes) Player position: ``` { x = 1288.7110595703, y = 47.700000762939, z = 624.0009765625 } ``` Player look: ``` { x = -0.36063626408577, y = 0.34005129337311, z = -0.86850821971893 } ``` Player information: ``` { protocol_version = 40, lang_code = "", formspec_version = 6, ip_version = 6, min_rtt = 0.15800000727177, max_rtt = 3.5829999446869, avg_rtt = 0.16699999570847, min_jitter = 0, max_jitter = 3.4189999103546, avg_jitter = 0.0050000101327896, connection_uptime = 44973, serialization_version = 29, patch = 0, minor = 6, version_string = "5.6.0", state = "Active", major = 5 } ``` Player meta: ``` { fields = { played_time = "23961752", inflicted_damage = "1703884", placed_nodes = "354230", ["petz:werewolf_clan_idx"] = "1", crafted = "40302", jointime = "1615351173", ["signslib:pos"] = "(1273,69,540)", yl_church = "return {[\"last_death_portal\"] = 1662955227, [\"last_heal\"] = 1615504208, [\"last_death\"] = {[\"x\"] = 2154, [\"y\"] = -16671, [\"z\"] = 1535}}", bitten = "0", hud_state = "on", died = "70", repellant = "0", yl_commons_thankyou = "167", partychat = "party", digged_nodes = "1105928", arenalib_infobox_arenaID = "0", yl_commons_player_created = "1615351173", xp = "1295367", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", ["petz:werewolf"] = "0", yl_commons_player_joined = "1663599803", ["petz:lycanthropy"] = "1", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots\", \"nether_mobs:dragon_shield\", \"3d_armor:helmet_nether\", \"3d_armor:leggings_nether\", \"3d_armor:chestplate_nether\", \"\"}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:level"] = "17", punch_count = "100241", ["stamina:poisoned"] = "no", ["petz:werewolf_vignette_id"] = "20", ["stamina:exhaustion"] = "105" } } ``` Log identifier ``` [MOD] yl_report log identifier = KGiLhRx9xHKflJGZ4Tkiw5Jm6qHVp90h ``` Profiler save: ``` profile-20220920T033234.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 18h 26min 44s | max lag: 2.4s | clients: digdeep, wordes, HorusDamocles, Sokomine, DreamNotFound, Domough, Insomniacs_Yello, Laylem, Frostian, Kiyoko, catia, Bailiff, rheo, jackofthebean000, flux, MarseySeether, NodeBreaker ``` Teleport command: ``` /teleport xyz 1289 48 624 ``` Compass command: ``` /give_compass Construction KGiLhRx9xHKflJGZ4Tkiw5Jm6qHVp90h D2691E 1289 48 624 ```

AliasAlreadyTaken was assigned by yourland-report

2022-09-20 03:32:35 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-09-20 08:00:09 +00:00

AliasAlreadyTaken commented

2022-09-20 08:06:00 +00:00

The server does know about what happened, but ofc it cannot take a look into the future. You could certainly have averages or the max lag, you can also read out per-player connection lag.

flux added the

3. source/integration

3. source/lag

2. prio/elevated

labels 2022-09-20 15:07:00 +00:00

flux added this to the flux's TODO list project 2022-09-20 15:35:51 +00:00

flux referenced this issue

2022-10-23 00:32:41 +00:00

shanish2 reports: rainbow pickaxe break warning ... #2905

flux referenced this issue

2022-10-29 04:10:08 +00:00

JeCel reports: I lost 6487 XP while helping t ... #2111

flux commented

2023-03-02 23:21:08 +00:00

the protection violation messages should only increment at most once per server step w/ #3882, so this issue is really only about tool warnings now, which is trickier to solve.

AliasAlreadyTaken commented

2023-03-03 12:39:19 +00:00

Can we detect lagspikes and not break tools during or restore them after a lagspike hit?

flux commented

2023-03-03 19:26:09 +00:00

Can we detect lagspikes and not break tools during or restore them after a lagspike hit?

with difficulty. wish the game had a register_on_tool_break callback.

> Can we detect lagspikes and not break tools during or restore them after a lagspike hit? with difficulty. wish the game had a `register_on_tool_break` callback.

Sign in to join this conversation.