rheo reports: group:food_tofu contains both ... #2722

New Issue

yourland-report · 2022-09-20T01:03:25Z

yourland-report commented

2022-09-20 01:03:25 +00:00

rheo reports a bug:

group:food_tofu contains both cooked and raw tofu from farming, but only cooked tofu from cv

Player position:

{
	x = 2382.8229980469,
	y = 25.530000686646,
	z = -3041.9721679688
}

Player look:

{
	x = 0.35065874457359,
	y = -0.78618061542511,
	z = 0.50887966156006
}

Player information:

{
	protocol_version = 40,
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.15999999642372,
	max_rtt = 4.3029999732971,
	avg_rtt = 0.1710000038147,
	min_jitter = 0,
	max_jitter = 4.1329998970032,
	avg_jitter = 0,
	connection_uptime = 7191,
	major = 5,
	minor = 6,
	version_string = "5.6.0",
	state = "Active",
	serialization_version = 29,
	patch = 0
}

Player meta:

{
	fields = {
		repellant = "0",
		inflicted_damage = "147838",
		placed_nodes = "14275",
		died = "2",
		crafted = "251",
		["ethereal:fly_timer"] = "-99",
		jointime = "1644205752",
		["signslib:pos"] = "(2153,19,1181)",
		yl_commons_thankyou = "25",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		hud_state = "off",
		["stamina:exhaustion"] = "152",
		arenalib_infobox_arenaID = "0",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 2200\", \"\", \"\", \"\", \"\", \"\"}",
		xp = "0",
		["ocean_build.last_warning"] = "1.6588e+09",
		played_time = "2036313",
		yl_commons_player_joined = "1663628639",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}",
		bitten = "0",
		yl_commons_player_created = "1644205752",
		["stamina:level"] = "0",
		digged_nodes = "7565",
		["stamina:poisoned"] = "no",
		["ocean_build.ocean_built"] = "2",
		punch_count = "904"
	}
}

Log identifier


[MOD] yl_report log identifier = pmHabGBmoPKYvZ7oKAwxlmFQ8Gx1fYvo

Profiler save:

profile-20220920T010325.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 15h 58min 5s | max lag: 2.43s | clients: leela, kobra123456789, Oakenshield, Therottenpotato, paneg, Kiyoko, Silvercastle, Sokomine, Bailiff, rheo, wordes, jackofthebean000, icser, AspireMint, daydream, flux, MarseySeether, NodeBreaker

Teleport command:

/teleport xyz 2383 26 -3042

Compass command:

/give_compass Construction pmHabGBmoPKYvZ7oKAwxlmFQ8Gx1fYvo D2691E 2383 26 -3042

rheo reports a bug: > group:food_tofu contains both cooked and raw tofu from farming, but only cooked tofu from cv Player position: ``` { x = 2382.8229980469, y = 25.530000686646, z = -3041.9721679688 } ``` Player look: ``` { x = 0.35065874457359, y = -0.78618061542511, z = 0.50887966156006 } ``` Player information: ``` { protocol_version = 40, lang_code = "", formspec_version = 6, ip_version = 6, min_rtt = 0.15999999642372, max_rtt = 4.3029999732971, avg_rtt = 0.1710000038147, min_jitter = 0, max_jitter = 4.1329998970032, avg_jitter = 0, connection_uptime = 7191, major = 5, minor = 6, version_string = "5.6.0", state = "Active", serialization_version = 29, patch = 0 } ``` Player meta: ``` { fields = { repellant = "0", inflicted_damage = "147838", placed_nodes = "14275", died = "2", crafted = "251", ["ethereal:fly_timer"] = "-99", jointime = "1644205752", ["signslib:pos"] = "(2153,19,1181)", yl_commons_thankyou = "25", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", hud_state = "off", ["stamina:exhaustion"] = "152", arenalib_infobox_arenaID = "0", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 2200\", \"\", \"\", \"\", \"\", \"\"}", xp = "0", ["ocean_build.last_warning"] = "1.6588e+09", played_time = "2036313", yl_commons_player_joined = "1663628639", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}", bitten = "0", yl_commons_player_created = "1644205752", ["stamina:level"] = "0", digged_nodes = "7565", ["stamina:poisoned"] = "no", ["ocean_build.ocean_built"] = "2", punch_count = "904" } } ``` Log identifier ``` [MOD] yl_report log identifier = pmHabGBmoPKYvZ7oKAwxlmFQ8Gx1fYvo ``` Profiler save: ``` profile-20220920T010325.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 15h 58min 5s | max lag: 2.43s | clients: leela, kobra123456789, Oakenshield, Therottenpotato, paneg, Kiyoko, Silvercastle, Sokomine, Bailiff, rheo, wordes, jackofthebean000, icser, AspireMint, daydream, flux, MarseySeether, NodeBreaker ``` Teleport command: ``` /teleport xyz 2383 26 -3042 ``` Compass command: ``` /give_compass Construction pmHabGBmoPKYvZ7oKAwxlmFQ8Gx1fYvo D2691E 2383 26 -3042 ```

AliasAlreadyTaken was assigned by yourland-report

2022-09-20 01:03:25 +00:00

flux added the

1. kind/balancing

3. source/integration

labels 2022-09-20 01:21:15 +00:00

flux added this to the flux's TODO list project 2022-09-20 01:21:36 +00:00

The4spaceconstants commented

2022-09-20 11:49:20 +00:00

As if it matters if you can't get farming:tofu.
(farming:tofu just means tofu from farming, a shortener.)

As if it matters if you can't get farming:tofu. (farming:tofu just means tofu from farming, a shortener.)

😆 1

flux commented

2022-09-20 15:43:42 +00:00

there's 2 issues here:

redundant food items need to be unified (#2490 (comment)), which is planned
cooked vs. uncooked tofu is not a huge distinction in IRL, but i think maintaining the "cooked vs. raw" distinction for tofu in-game is better for consistency. farming:tofu is in both group:food_tofu and group:food_tofu_raw.

there's 2 issues here: * redundant food items need to be unified (https://gitea.your-land.de/your-land/bugtracker/issues/2490#issuecomment-24197), which is planned * cooked vs. uncooked tofu is not a huge distinction in IRL, but i think maintaining the "cooked vs. raw" distinction for tofu in-game is better for consistency. `farming:tofu` is in *both* `group:food_tofu` and `group:food_tofu_raw`.

flux added the

4. step/ready to QA test

label 2022-11-07 18:02:54 +00:00

flux commented

2022-11-07 18:03:46 +00:00

was fixed in #2490, i think

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-11 14:31:34 +00:00

flux added the

4. step/partially fixed

label 2022-11-15 21:52:35 +00:00

flux commented

2022-11-15 21:52:54 +00:00

i failed to remove tofu from group:tofu. fixed that now: 80fc109947

i failed to remove tofu from `group:tofu`. fixed that now: https://gitea.your-land.de/your-land/yl_commons/commit/80fc10994782138567e435f93b3e48468cb1753f

flux modified the milestone from 1.1.116 to 1.1.117

2022-11-18 21:11:11 +00:00

AliasAlreadyTaken added the

ugh/QA OK

label 2023-01-18 11:59:39 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

4. step/partially fixed

labels 2023-01-25 17:39:54 +00:00

flux removed this from the flux's TODO list project 2023-01-25 17:39:57 +00:00