Kiyoko reports: game thinks im digging a block ... #2700

New Issue

yourland-report · 2022-09-16T19:19:37Z

yourland-report commented

2022-09-16 19:19:37 +00:00

Kiyoko reports a bug:

game thinks im digging a block in someones area when im not anywhere near that area

Player position:

{
	z = 1153.5549316406,
	x = 2001.8430175781,
	y = 14.5
}

Player look:

{
	z = 0.99917644262314,
	x = 0.017789594829082,
	y = -0.036469291895628
}

Player information:

{
	avg_rtt = 0.13400000333786,
	min_jitter = 0,
	max_jitter = 1.0910000801086,
	avg_jitter = 0.0020000040531158,
	connection_uptime = 59,
	serialization_version = 29,
	patch = 0,
	major = 5,
	minor = 6,
	version_string = "5.6.0",
	lang_code = "",
	formspec_version = 6,
	state = "Active",
	min_rtt = 0.13099999725819,
	max_rtt = 1.2319999933243,
	ip_version = 6,
	protocol_version = 40
}

Player meta:

{
	fields = {
		partychat = "party",
		arenalib_infobox_arenaID = "0",
		["stamina:poisoned"] = "no",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:exhaustion"] = "2.5",
		["ocean_build.forbidden"] = "true",
		["ocean_build.ocean_built"] = "12",
		["stamina:level"] = "19",
		hud_state = "on",
		repellant = "0",
		played_time = "3507031",
		xp = "197840",
		yl_commons_player_created = "1613163701",
		punch_count = "13165",
		placed_nodes = "143418",
		inflicted_damage = "200630",
		digged_nodes = "346694",
		bitten = "0",
		died = "485",
		crafted = "14360",
		["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"sneak\"] = true, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"speed\"] = 2}",
		["signslib:pos"] = "(25173,-32,30572)",
		["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}",
		["petz:werewolf"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		jointime = "1613163701",
		yl_commons_thankyou = "18",
		["ocean_build.last_warning"] = "1.65974e+09",
		yl_church = "return {[\"last_death_portal\"] = 1663272226, [\"last_death\"] = {[\"z\"] = 1154, [\"x\"] = 2003, [\"y\"] = 17}, [\"last_heal\"] = 1613167562}",
		yl_commons_player_joined = "1663355932",
		["petz:lycanthropy"] = "0",
		["petz:werewolf_clan_idx"] = "2"
	}
}

Log identifier


[MOD] yl_report log identifier = gDuLbCHNYzVT1NjvEjEGktCcdw24rU0p

Profiler save:

profile-20220916T191936.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 2d 21h 19min 8s | max lag: 2.6s | clients: Kiyoko, Ivanhoe, Armades, GrimPixel, Bla, Mielle, rabenkind, athanda, Therottenpotato, hbreturns, Lucien, Aatest, Bond007, HellRob, Amun, NodeBreaker, The4spaceconstants, flux, Boot, Bailiff, daydream

Teleport command:

/teleport xyz 2002 15 1154

Compass command:

/give_compass Construction gDuLbCHNYzVT1NjvEjEGktCcdw24rU0p D2691E 2002 15 1154

Kiyoko reports a bug: > game thinks im digging a block in someones area when im not anywhere near that area Player position: ``` { z = 1153.5549316406, x = 2001.8430175781, y = 14.5 } ``` Player look: ``` { z = 0.99917644262314, x = 0.017789594829082, y = -0.036469291895628 } ``` Player information: ``` { avg_rtt = 0.13400000333786, min_jitter = 0, max_jitter = 1.0910000801086, avg_jitter = 0.0020000040531158, connection_uptime = 59, serialization_version = 29, patch = 0, major = 5, minor = 6, version_string = "5.6.0", lang_code = "", formspec_version = 6, state = "Active", min_rtt = 0.13099999725819, max_rtt = 1.2319999933243, ip_version = 6, protocol_version = 40 } ``` Player meta: ``` { fields = { partychat = "party", arenalib_infobox_arenaID = "0", ["stamina:poisoned"] = "no", ["petz:werewolf_vignette_id"] = "19", ["stamina:exhaustion"] = "2.5", ["ocean_build.forbidden"] = "true", ["ocean_build.ocean_built"] = "12", ["stamina:level"] = "19", hud_state = "on", repellant = "0", played_time = "3507031", xp = "197840", yl_commons_player_created = "1613163701", punch_count = "13165", placed_nodes = "143418", inflicted_damage = "200630", digged_nodes = "346694", bitten = "0", died = "485", crafted = "14360", ["petz:old_override_table"] = "return {[\"jump\"] = 1.5, [\"sneak\"] = true, [\"gravity\"] = 1, [\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"speed\"] = 2}", ["signslib:pos"] = "(25173,-32,30572)", ["3d_armor_inventory"] = "return {\"\", \"\", \"\", \"\", \"\", \"\"}", ["petz:werewolf"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", jointime = "1613163701", yl_commons_thankyou = "18", ["ocean_build.last_warning"] = "1.65974e+09", yl_church = "return {[\"last_death_portal\"] = 1663272226, [\"last_death\"] = {[\"z\"] = 1154, [\"x\"] = 2003, [\"y\"] = 17}, [\"last_heal\"] = 1613167562}", yl_commons_player_joined = "1663355932", ["petz:lycanthropy"] = "0", ["petz:werewolf_clan_idx"] = "2" } } ``` Log identifier ``` [MOD] yl_report log identifier = gDuLbCHNYzVT1NjvEjEGktCcdw24rU0p ``` Profiler save: ``` profile-20220916T191936.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 2d 21h 19min 8s | max lag: 2.6s | clients: Kiyoko, Ivanhoe, Armades, GrimPixel, Bla, Mielle, rabenkind, athanda, Therottenpotato, hbreturns, Lucien, Aatest, Bond007, HellRob, Amun, NodeBreaker, The4spaceconstants, flux, Boot, Bailiff, daydream ``` Teleport command: ``` /teleport xyz 2002 15 1154 ``` Compass command: ``` /give_compass Construction gDuLbCHNYzVT1NjvEjEGktCcdw24rU0p D2691E 2002 15 1154 ```

AliasAlreadyTaken was assigned by yourland-report

2022-09-16 19:19:37 +00:00

flux added the

1. kind/bug

label 2022-09-16 20:02:35 +00:00

flux commented

2022-09-16 20:03:04 +00:00

my suspicion is this was lag (possibly connection lag), anticheat, and possibly "interacting while dead".

AliasAlreadyTaken commented

2022-09-16 21:45:59 +00:00

The problem was that Kiyoko helped install a coral digging machine in an area she then most likely coowned. The dig in her name worked.

As soon as she was not entrusted to the area anymore, the machine then dug in her name a position she wasn't allowed to. Causing the effects of yl_areas_addon: Damage and turning.

The problem was that Kiyoko helped install a coral digging machine in an area she then most likely coowned. The dig in her name worked. As soon as she was not entrusted to the area anymore, the machine then dug in her name a position she wasn't allowed to. Causing the effects of yl_areas_addon: Damage and turning.

flux commented

2022-09-16 22:03:50 +00:00

i'm wondering whether to consider this a bug in pipeworks, or a bug in the protection violation detector.

AliasAlreadyTaken added the

3. source/integration

label 2022-09-16 22:10:28 +00:00

Bla commented

2022-09-16 22:10:52 +00:00

depends if "mesemaker as a service" builds should be prevented, if yes I would say its pipeworks that should check the protection

flux commented

2022-09-16 22:13:40 +00:00

decided it's a pipeworks bug. the wielder machines should check that they can modify the node in front of the machine before attempting to do anything.

AliasAlreadyTaken commented

2022-09-16 22:14:47 +00:00

Usecase that supports the current behaviour: Evil A places a nodebreaker at the border of B's territory and gnaws on the border.

Usecase that says the current behaviour is a bug: Nice mesemaker A installs a machine including a nodebreaker on the territory of non-memsemaker B, then is removed from the area.

I don't think we can have one without the other, unless we make crazy exceptions. I wonder why this worked in the past? Did the nodebreakers get "owners" lately?

Usecase that supports the current behaviour: Evil A places a nodebreaker at the border of B's territory and gnaws on the border. Usecase that says the current behaviour is a bug: Nice mesemaker A installs a machine including a nodebreaker on the territory of non-memsemaker B, then is removed from the area. I don't think we can have one without the other, unless we make crazy exceptions. I wonder why this worked in the past? Did the nodebreakers get "owners" lately?

Bla commented

2022-09-16 22:20:40 +00:00

I don't think we can have one without the other, unless we make crazy exceptions. I wonder why this worked in the past? Did the nodebreakers get "owners" lately?

check both positions
nodebreaker = only run if owner is in the protection
infront of nodebreaker = only dig if in protection

> I don't think we can have one without the other, unless we make crazy exceptions. I wonder why this worked in the past? Did the nodebreakers get "owners" lately? check both positions nodebreaker = only run if owner is in the protection infront of nodebreaker = only dig if in protection

flux commented

2022-09-16 23:14:55 +00:00

upstream PR: https://github.com/mt-mods/pipeworks/pull/42

flux added the

3. source/mod upstream

4. step/ready to QA test

labels 2022-09-16 23:16:52 +00:00

AliasAlreadyTaken commented

2022-09-16 23:44:38 +00:00

Merged less than 5 minutes after you sent the PR :D Thankyou wsor!

We'll also update

Merged less than 5 minutes after you sent the PR :D Thankyou wsor! We'll also update

flux commented

2022-09-17 00:15:41 +00:00

yeah, while i'm not a huge fan of some of mt-mods "solutions", they are at least really prompt about dealing w/ PRs and well described bug reports.

flux commented

2022-09-17 17:16:51 +00:00

note: further upstream drama

AliasAlreadyTaken commented

2022-09-19 21:57:47 +00:00

How is this situation solved in the other technic mods?

flux commented

2022-09-19 22:59:06 +00:00

How is this situation solved in the other technic mods?

pipeworks isn't a technic mod? technic machines don't try to fake being a player, so far as i know?

> How is this situation solved in the other technic mods? pipeworks isn't a technic mod? technic machines don't try to fake being a player, so far as i know?

flux referenced this issue

2022-09-26 16:29:15 +00:00

Bla reports: Hulda constant dieing loop at ... #2765

daydream commented

2022-09-26 17:25:18 +00:00

This is exactly why players shouldn't bulid machines for other players and each player should have to earn their own mese privs!

In the case of someone having control over a significant build (like Hulda's) that would otherwise have been deleted entirely - it's a bit more complex - but I suppose the bitter pill to swallow is that the people interested in seeing it could come and study it and then a master mese maker could dismantle whatever runs it so that a non-mese priv player can't cause these sorts of issues.

Not to hyjack the wrong issue here but maybe Hulda's area could be preserved by someone else (not me!) and just leave me on the list as an administrator for access only. This is the second time now that a major area has been left to me... ofc I want to look after it if I can, but there's got to be a smarter way to do it.

This is exactly why players shouldn't bulid machines for other players and each player should have to earn their own mese privs! In the case of someone having control over a significant build (like Hulda's) that would otherwise have been deleted entirely - it's a bit more complex - but I suppose the bitter pill to swallow is that the people interested in seeing it could come and study it and then a master mese maker could dismantle whatever runs it so that a non-mese priv player can't cause these sorts of issues. Not to hyjack the wrong issue here but maybe Hulda's area could be preserved by someone else (not me!) and just leave me on the list as an administrator for access only. This is the second time now that a major area has been left to me... ofc I want to look after it if I can, but there's got to be a smarter way to do it.

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-02 13:04:50 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2022-11-14 04:11:50 +00:00

AliasAlreadyTaken was unassigned by flux

2022-11-14 04:11:53 +00:00

flux commented

2022-11-14 04:12:00 +00:00

this is live

flux closed this issue