your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

alexandre2005 reports: you can take out and put stuff ... #2680

New Issue
Open
opened 2022-09-14 13:48:09 +00:00 by yourland-report · 11 comments
yourland-report commented 2022-09-14 13:48:09 +00:00
Member
Copy Link

alexandre2005 reports a bug:

you can take out and put stuff i vessels:shelf on protected areas

Player position:

{
	z = 1179.5440673828,
	x = 1912.2769775391,
	y = 21.5
}

Player look:

{
	z = 0.46116131544113,
	x = -0.023280832916498,
	y = 0.8870108127594
}

Player information:

{
	state = "Active",
	ip_version = 6,
	min_rtt = 0.027000000700355,
	max_rtt = 0.36399999260902,
	major = 5,
	minor = 5,
	max_jitter = 0.30500000715256,
	avg_jitter = 0,
	connection_uptime = 673,
	serialization_version = 29,
	patch = 0,
	formspec_version = 5,
	version_string = "5.5.0",
	avg_rtt = 0.028000000864267,
	lang_code = "fr",
	min_jitter = 0,
	protocol_version = 40
}

Player meta:

{
	fields = {
		["stamina:level"] = "18",
		arenalib_infobox_arenaID = "0",
		["stamina:poisoned"] = "no",
		["petz:werewolf_vignette_id"] = "19",
		["stamina:exhaustion"] = "16.5",
		partychat = "main",
		["petz:werewolf_clan_idx"] = "2",
		yl_church = "return {[\"last_death\"] = {[\"z\"] = 574, [\"x\"] = 1480, [\"y\"] = 93}, [\"last_death_portal\"] = 1661081227, [\"last_heal\"] = 1638658034}",
		digged_nodes = "756781",
		xp = "703367",
		["petz:werewolf"] = "0",
		punch_count = "43468",
		bitten = "0",
		repellant = "0",
		jointime = "1620902771",
		placed_nodes = "348119",
		died = "182",
		crafted = "46095",
		partypvp = "true",
		hud_state = "on",
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 4400\", \"nether_mobs:dragon_boots 1 4400\", \"3d_armor:leggings_crystal 1 4400\", \"shields:shield_crystal 1 4400\", \"petz:prince_north_coat 1 22820\", \"\"}",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		["signslib:pos"] = "(30841,30502,30909)",
		played_time = "3271718",
		yl_commons_thankyou = "62",
		inflicted_damage = "497846",
		yl_commons_player_created = "1620902771",
		yl_commons_player_joined = "1663162634",
		["petz:lycanthropy"] = "0",
		["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"jump\"] = 1, [\"speed\"] = 1, [\"gravity\"] = 1}"
	}
}

Log identifier


[MOD] yl_report log identifier = I59pKFMpt3tOO5S9WMhnEVDU2kXBBMFM

Profiler save:

profile-20220914T134809.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 15h 56min 57s | max lag: 3.56s | clients: aila29, sparrow, aila29a, LOR, davi29, rabenkind, The4spaceconstants, LinuxIsGreat, enzo29, cypis, Chacha, Antimatter_76, SkyKnife, Davidsoft, Pecka, Segmentation_Fault, Bailiff, flux, Bishiro, Aero, daydream, hbreturns, Armades, AliasAlreadyTaken, niceride, alexandre2005, Service

Teleport command:

/teleport xyz 1912 22 1180

Compass command:

/give_compass Construction I59pKFMpt3tOO5S9WMhnEVDU2kXBBMFM D2691E 1912 22 1180
alexandre2005 reports a bug: > you can take out and put stuff i vessels:shelf on protected areas Player position: ``` { z = 1179.5440673828, x = 1912.2769775391, y = 21.5 } ``` Player look: ``` { z = 0.46116131544113, x = -0.023280832916498, y = 0.8870108127594 } ``` Player information: ``` { state = "Active", ip_version = 6, min_rtt = 0.027000000700355, max_rtt = 0.36399999260902, major = 5, minor = 5, max_jitter = 0.30500000715256, avg_jitter = 0, connection_uptime = 673, serialization_version = 29, patch = 0, formspec_version = 5, version_string = "5.5.0", avg_rtt = 0.028000000864267, lang_code = "fr", min_jitter = 0, protocol_version = 40 } ``` Player meta: ``` { fields = { ["stamina:level"] = "18", arenalib_infobox_arenaID = "0", ["stamina:poisoned"] = "no", ["petz:werewolf_vignette_id"] = "19", ["stamina:exhaustion"] = "16.5", partychat = "main", ["petz:werewolf_clan_idx"] = "2", yl_church = "return {[\"last_death\"] = {[\"z\"] = 574, [\"x\"] = 1480, [\"y\"] = 93}, [\"last_death_portal\"] = 1661081227, [\"last_heal\"] = 1638658034}", digged_nodes = "756781", xp = "703367", ["petz:werewolf"] = "0", punch_count = "43468", bitten = "0", repellant = "0", jointime = "1620902771", placed_nodes = "348119", died = "182", crafted = "46095", partypvp = "true", hud_state = "on", ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 4400\", \"nether_mobs:dragon_boots 1 4400\", \"3d_armor:leggings_crystal 1 4400\", \"shields:shield_crystal 1 4400\", \"petz:prince_north_coat 1 22820\", \"\"}", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", ["signslib:pos"] = "(30841,30502,30909)", played_time = "3271718", yl_commons_thankyou = "62", inflicted_damage = "497846", yl_commons_player_created = "1620902771", yl_commons_player_joined = "1663162634", ["petz:lycanthropy"] = "0", ["petz:old_override_table"] = "return {[\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"new_move\"] = true, [\"jump\"] = 1, [\"speed\"] = 1, [\"gravity\"] = 1}" } } ``` Log identifier ``` [MOD] yl_report log identifier = I59pKFMpt3tOO5S9WMhnEVDU2kXBBMFM ``` Profiler save: ``` profile-20220914T134809.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 15h 56min 57s | max lag: 3.56s | clients: aila29, sparrow, aila29a, LOR, davi29, rabenkind, The4spaceconstants, LinuxIsGreat, enzo29, cypis, Chacha, Antimatter_76, SkyKnife, Davidsoft, Pecka, Segmentation_Fault, Bailiff, flux, Bishiro, Aero, daydream, hbreturns, Armades, AliasAlreadyTaken, niceride, alexandre2005, Service ``` Teleport command: ``` /teleport xyz 1912 22 1180 ``` Compass command: ``` /give_compass Construction I59pKFMpt3tOO5S9WMhnEVDU2kXBBMFM D2691E 1912 22 1180 ```
AliasAlreadyTaken was assigned by yourland-report 2022-09-14 13:48:09 +00:00
flux added the
1. kind/balancing
 label 2022-09-14 16:18:32 +00:00
flux commented 2022-09-14 16:19:32 +00:00
Member
Copy Link

that's the way it's always been.

it's easy to override though, see e.g. https://github.com/BlockySurvival/bls_custom/blob/master/node_inventory_protection.lua

that's the way it's always been. it's easy to override though, see e.g. https://github.com/BlockySurvival/bls_custom/blob/master/node_inventory_protection.lua
AliasAlreadyTaken commented 2022-09-15 00:00:31 +00:00
Owner
Copy Link

Maybe we should create a unified protection API. One doesn't need much more than a public chest, a locked chest and a protected chest. Every other "storage" block should get a public, locked and protected version as well IMO. Bookshelves, chests, ...

Opinions?

Maybe we should create a unified protection API. One doesn't need much more than a public chest, a locked chest and a protected chest. Every other "storage" block should get a public, locked and protected version as well IMO. Bookshelves, chests, ... Opinions?
AliasAlreadyTaken added the
4. step/question
 label 2022-09-15 00:00:37 +00:00
flux commented 2022-09-15 02:26:31 +00:00
Member
Copy Link

Maybe we should create a unified protection API. One doesn't need much more than a public chest, a locked chest and a protected chest. Every other "storage" block should get a public, locked and protected version as well IMO. Bookshelves, chests, ...

Opinions?

i'm currently implementing something like this for my cottages update, but it's a something that's controlled by clicking a button in the formspec. one thing it doesn't do is handle different appearances for nodes w/ different protection levels - there's no way to apply texture overlays to "variants" of a node w/out creating new node IDs.

so you could easily have chests that you could toggle between "private, protected, and public", but they'd all look the same, or they'd all have to have separate node IDs.

> > Maybe we should create a unified protection API. One doesn't need much more than a public chest, a locked chest and a protected chest. Every other "storage" block should get a public, locked and protected version as well IMO. Bookshelves, chests, ... > > Opinions? i'm currently implementing something like this for my cottages update, but it's a something that's controlled by clicking a button in the formspec. one thing it doesn't do is handle different appearances for nodes w/ different protection levels - there's no way to apply texture overlays to "variants" of a node w/out creating new node IDs. so you could easily have chests that you could toggle between "private, protected, and public", but they'd all look the same, or they'd all have to have separate node IDs.
Bla commented 2022-09-15 06:14:33 +00:00
Copy Link

Maybe we should create a unified protection API.

https://gitea.your-land.de/your-land/locks

> > Maybe we should create a unified protection API. https://gitea.your-land.de/your-land/locks
flux commented 2022-09-15 13:18:27 +00:00
Member
Copy Link

Maybe we should create a unified protection API.

https://gitea.your-land.de/your-land/locks

IMO that mod makes the situation worse and should be gotten rid of. the mechanic of sharing keys to share protection is entirely orthogonal to the public/private/protected model.

> > > > Maybe we should create a unified protection API. > > https://gitea.your-land.de/your-land/locks IMO that mod makes the situation *worse* and should be gotten rid of. the mechanic of sharing keys to share protection is entirely orthogonal to the public/private/protected model.
flux commented 2022-09-15 14:14:45 +00:00
Member
Copy Link

for chests that don't have special function (digilines, mese), we currently have

variant all can use in protected area all can use in public area area owners can use area owners can remove chest owner can use in other player's protected area comments
default:chest yes yes yes yes N/A
default:chest_locked no no no no yes
chesttools:shared_chest no no yes no yes useful buttons
shared_chest:shared_chest no no yes no* yes like the chesttools chest but less useful
yl_tools:chest_protected no yes yes yes yes see #1507
locks:shared_locked_chest no no no no yes can be used by owner & those manually listed or with a password. non-owners must have a keyring item in inventory, for some reason.
for chests that don't have special function (digilines, mese), we currently have | variant | all can use in protected area | all can use in public area | area owners can use | area owners can remove | chest owner can use in other player's protected area | comments | | -------- | -------- | -------- | -------- | -------- | -- | -------- | | default:chest | yes | yes | yes | yes | N/A | | | default:chest_locked | no | no | no | no | yes | | | chesttools:shared_chest | no | no | yes | no | yes | useful buttons | | shared_chest:shared_chest | no | no | yes | no[\*](https://github.com/Sokomine/chesttools/pull/3) | yes | like the chesttools chest but less useful | | yl_tools:chest_protected | no | yes | yes | yes | yes | see #1507 | | locks:shared_locked_chest | no | no | no | no | yes | can be used by owner & those manually listed or with a password. non-owners must have a keyring item in inventory, for some reason. |
flux commented 2022-09-15 14:27:41 +00:00
Member
Copy Link

IMO shared_chest:shared_chest and locks:shared_locked_chest should be aliased to chesttools:shared_chest, and yl_tools:chest_protected shouldn't be craftable and should be not_in_creative_inventory.

IMO `shared_chest:shared_chest` and `locks:shared_locked_chest` should be aliased to `chesttools:shared_chest`, and `yl_tools:chest_protected` shouldn't be craftable and should be `not_in_creative_inventory`.
👍 1
AliasAlreadyTaken commented 2022-09-16 10:30:27 +00:00
Owner
Copy Link

We should gather all named block, protected chest, locked something here:

your-land/administration#172

We should gather all named block, protected chest, locked something here: https://gitea.your-land.de/your-land/administration/issues/172
flux added a new dependency 2022-11-05 21:24:46 +00:00
your-land/administration#172 - Unify chests
niceride commented 2023-06-29 11:23:14 +00:00
Copy Link

minor omission on the rubric

for chests that don't have special function (digilines, mese), we currently have
...

what happens when you place the chest in another's protected area at the time you have a sub-area protection to do so, and the sub-area protection is removed? i.e. yl_tools:chest_protected the player that placed the chest retains access to it (violating area protections?)

minor omission on the rubric > for chests that don't have special function (digilines, mese), we currently have > ... what happens when you place the chest in another's protected area at the time you have a sub-area protection to do so, and the sub-area protection is removed? i.e. `yl_tools:chest_protected` the player that placed the chest retains access to it (violating area protections?)
flux commented 2023-06-29 18:29:05 +00:00
Member
Copy Link

minor omission on the rubric

for chests that don't have special function (digilines, mese), we currently have
...

what happens when you place the chest in another's protected area at the time you have a sub-area protection to do so, and the sub-area protection is removed? i.e. yl_tools:chest_protected the player that placed the chest retains access to it (violating area protections?)

sure i can add that. it seems that all chests allow the owner to use them even if they don't control the area.

> minor omission on the rubric > > > for chests that don't have special function (digilines, mese), we currently have > > ... > > what happens when you place the chest in another's protected area at the time you have a sub-area protection to do so, and the sub-area protection is removed? i.e. `yl_tools:chest_protected` the player that placed the chest retains access to it (violating area protections?) sure i can add that. it seems that all chests allow the owner to use them even if they don't control the area.
niceride commented 2023-07-03 07:47:39 +00:00
Copy Link

Have been using smartshop:storage instead of chests, and it has the interesting benefit of being able to dynamically mark private/protected. If you can dig in the area and it is un-marked private, and you mark the checkbox private again, it is (correctly) no longer accessible to non-owners that can build in the area. Perhaps worth adding to the rubric ; there's a lot of storage nodes that could be added.

Have been using `smartshop:storage` instead of chests, and it has the interesting benefit of being able to dynamically mark private/protected. If you can dig in the area and it is un-marked private, and you mark the checkbox private again, it is (correctly) no longer accessible to non-owners that can build in the area. Perhaps worth adding to the rubric ; there's a lot of storage nodes that could be added.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
You do not have permission to read 1 dependency
Reference: your-land/bugtracker#2680
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?