your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

mesecons_debug/util.lua:11: attempt to perform arithmetic on field 'x' (a nil value) #2673

New Issue
Closed
opened 2022-09-13 20:19:13 +00:00 by AliasAlreadyTaken · 14 comments
AliasAlreadyTaken commented 2022-09-13 20:19:13 +00:00
Owner
Copy Link
2022-09-13 20:17:51: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: attempt to perform arithmetic on field 'x' (a nil value)
2022-09-13 20:17:51: ERROR[Main]: stack traceback:
2022-09-13 20:17:51: ERROR[Main]: 	.../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: in function 'hashpos'
2022-09-13 20:17:51: ERROR[Main]: 	...6.0/Minetest_test/bin/../mods/mesecons_debug/context.lua:5: in function 'get_context'
2022-09-13 20:17:51: ERROR[Main]: 	.../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:14: in function 'execute'
2022-09-13 20:17:51: ERROR[Main]: 	...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
2022-09-13 20:17:51: ERROR[Main]: 	.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:429: in function <.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:415>
``` 2022-09-13 20:17:51: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: attempt to perform arithmetic on field 'x' (a nil value) 2022-09-13 20:17:51: ERROR[Main]: stack traceback: 2022-09-13 20:17:51: ERROR[Main]: .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: in function 'hashpos' 2022-09-13 20:17:51: ERROR[Main]: ...6.0/Minetest_test/bin/../mods/mesecons_debug/context.lua:5: in function 'get_context' 2022-09-13 20:17:51: ERROR[Main]: .../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:14: in function 'execute' 2022-09-13 20:17:51: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73> 2022-09-13 20:17:51: ERROR[Main]: .../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:429: in function <.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:415> ```
JeCel commented 2022-09-13 20:23:43 +00:00
Copy Link

I clicked multiple times on the programmable color node from digicolor in the inventory menu. I think it was about three times, and instead of giving me a third stack, the server crashed. Maybe I clicked too fast?

I actually just wanted to see, if it has a crafting recipe on the test server, and forgot that I had creative privs there, which is why I clicked multiple times until I realized.

I clicked multiple times on the programmable color node from digicolor in the inventory menu. I think it was about three times, and instead of giving me a third stack, the server crashed. Maybe I clicked too fast? I actually just wanted to see, if it has a crafting recipe on the test server, and forgot that I had creative privs there, which is why I clicked multiple times until I realized.
flux added the
1. kind/bug
3. source/mod upstream
2. prio/critical
 labels 2022-09-13 20:25:13 +00:00
flux self-assigned this 2022-09-13 20:25:21 +00:00
flux commented 2022-09-13 20:26:20 +00:00
Member
Copy Link

JeCel, pretty sure what you did in unified inventory was just a coincidence, i'll look into this, as mesecons_debug is sort-of my mod now.

JeCel, pretty sure what you did in unified inventory was just a coincidence, i'll look into this, as mesecons_debug is sort-of my mod now.
flux commented 2022-09-13 20:35:22 +00:00
Member
Copy Link

looks like mesecons_debug isn't really to blame, somehow an "invalid" mesecons action got created without a valid position.

looks like mesecons_debug isn't really to blame, somehow an "invalid" mesecons action got created without a valid position.
flux commented 2022-09-13 21:01:10 +00:00
Member
Copy Link

made it so that an error is generated if a mesecons action is queued w/ no position, so we can catch the issue when it's created, not when the action is executed.

9831ad7a8d

made it so that an error is generated if a mesecons action is queued w/ no position, so we can catch the issue when it's created, not when the action is executed. https://gitea.your-land.de/your-land/yl_commons/commit/9831ad7a8df876c50b21e136faa406226088a8d2
flux added the
4. step/ready to QA test
 label 2022-09-13 21:01:26 +00:00
AliasAlreadyTaken was assigned by flux 2022-09-13 21:01:33 +00:00
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-09-14 00:03:15 +00:00
AliasAlreadyTaken commented 2022-09-14 00:22:14 +00:00
Author
Owner
Copy Link

Repro:

2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2015,15,1140)
2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2016,15,1141)
2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1141)
2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1141)
2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1139)
2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1138)
2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1137)
2022-09-14 00:19:19: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1136)
2022-09-14 00:19:19: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2016,15,1135)

Result:

2022-09-14 00:19:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: attempt to perform arithmetic on field 'x' (a nil value)
2022-09-14 00:19:25: ERROR[Main]: stack traceback:
2022-09-14 00:19:25: ERROR[Main]: 	.../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: in function 'hashpos'
2022-09-14 00:19:25: ERROR[Main]: 	...6.0/Minetest_test/bin/../mods/mesecons_debug/context.lua:5: in function 'get_context'
2022-09-14 00:19:25: ERROR[Main]: 	.../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:14: in function 'execute'
2022-09-14 00:19:25: ERROR[Main]: 	...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
2022-09-14 00:19:25: ERROR[Main]: 	.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:429: in function <.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:415>
Repro: ``` 2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2015,15,1140) 2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2016,15,1141) 2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1141) 2022-09-14 00:19:17: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1141) 2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1139) 2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2018,15,1138) 2022-09-14 00:19:18: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1137) 2022-09-14 00:19:19: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2017,15,1136) 2022-09-14 00:19:19: ACTION[Server]: AliasAlreadyTaken places node digitated:digimeseioexp_0 at (2016,15,1135) ``` Result: ``` 2022-09-14 00:19:25: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: attempt to perform arithmetic on field 'x' (a nil value) 2022-09-14 00:19:25: ERROR[Main]: stack traceback: 2022-09-14 00:19:25: ERROR[Main]: .../5.6.0/Minetest_test/bin/../mods/mesecons_debug/util.lua:11: in function 'hashpos' 2022-09-14 00:19:25: ERROR[Main]: ...6.0/Minetest_test/bin/../mods/mesecons_debug/context.lua:5: in function 'get_context' 2022-09-14 00:19:25: ERROR[Main]: .../bin/../mods/mesecons_debug/overrides/mesecons_queue.lua:14: in function 'execute' 2022-09-14 00:19:25: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73> 2022-09-14 00:19:25: ERROR[Main]: .../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:429: in function <.../mt/5.6.0/Minetest_test/bin/../builtin/game/register.lua:415> ```
flux commented 2022-09-14 00:45:32 +00:00
Member
Copy Link

it sounds like the bug is in the ioexpander then?

it sounds like the bug is in the ioexpander then?
AliasAlreadyTaken commented 2022-09-17 00:50:45 +00:00
Author
Owner
Copy Link

Yes. https://github.com/antevens/digitated/issues/1

Yes. https://github.com/antevens/digitated/issues/1
AliasAlreadyTaken commented 2022-10-24 10:14:42 +00:00
Author
Owner
Copy Link

We'll remove the ioexpander for the moment

We'll remove the ioexpander for the moment
flux added
4. step/blocked
 and removed
4. step/ready to QA test
 labels 2022-11-05 21:05:41 +00:00
flux added the
4. step/partially fixed
 label 2022-11-17 22:05:18 +00:00
flux commented 2022-11-17 22:06:14 +00:00
Member
Copy Link

digitated is no longer active

digitated is no longer active
flux removed this from the 1.1.116 milestone 2022-11-18 21:17:13 +00:00
AliasAlreadyTaken commented 2022-11-23 07:18:16 +00:00
Author
Owner
Copy Link

Why remove the milestone? The "fix" went live during 1.1.116, even when that means the mod was removed :D

Why remove the milestone? The "fix" went live during 1.1.116, even when that means the mod was removed :D
flux commented 2022-11-24 03:24:53 +00:00
Member
Copy Link

Why remove the milestone? The "fix" went live during 1.1.116, even when that means the mod was removed :D

i removed the milestone because the remaining part of the issue doesn't have any planned release, though the fixed part of the issue has already been released. i can split that into a new issue if you prefer.

> Why remove the milestone? The "fix" went live during 1.1.116, even when that means the mod was removed :D i removed the milestone because the remaining part of the issue doesn't have any planned release, though the fixed part of the issue has already been released. i can split that into a new issue if you prefer.
AliasAlreadyTaken commented 2022-11-24 16:39:09 +00:00
Author
Owner
Copy Link

Let's decide on how to deal with partially fixed issues: #3129

Let's decide on how to deal with partially fixed issues: #3129
flux added the
4. step/ready to QA test
 label 2022-12-20 18:24:48 +00:00
flux commented 2022-12-20 18:26:36 +00:00
Member
Copy Link

i've pushed a fix to mesecons_debug in gitea that ought to avoid crashes due to actions w/out valid positions:

0a3e3f2a90

upstream could use this, but upstream seems to have diverged a bit, and my long-term plans for mesecons_debug are to rework it into a general task scheduling and load-balancing framework.

i've pushed a fix to mesecons_debug in gitea that ought to avoid crashes due to actions w/out valid positions: https://gitea.your-land.de/your-land/mesecons_debug/commit/0a3e3f2a909792a10008193d6e571bbed573941a upstream could use this, but upstream seems to have diverged a bit, and my long-term plans for mesecons_debug are to rework it into a general task scheduling and load-balancing framework.
flux added
5. result/fixed
 and removed
4. step/ready to QA test
4. step/partially fixed
 labels 2023-01-25 23:01:05 +00:00
flux commented 2023-01-25 23:01:32 +00:00
Member
Copy Link

the fix for this is live

the fix for this is live
flux closed this issue 2023-01-25 23:01:34 +00:00
flux removed their assignment 2023-01-25 23:01:39 +00:00
AliasAlreadyTaken was unassigned by flux 2023-01-25 23:01:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2673
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?