rheo reports: there's still lots of firework ... #2655

Open
opened 2022-09-11 23:39:55 +00:00 by yourland-report · 9 comments

rheo reports a bug:

there's still lots of fireworks in the air all around haven, just waiting for an unsuspecting admin to fly past them and get a "boom" in their ear...

Player position:

{
	x = 1957.8538818359,
	y = 144.74398803711,
	z = 1489.9150390625
}

Player look:

{
	x = -0.26848646998405,
	y = -0.59580445289612,
	z = -0.75692278146744
}

Player information:

{
	formspec_version = 6,
	lang_code = "",
	state = "Active",
	version_string = "5.6.0",
	protocol_version = 40,
	max_jitter = 2.1920001506805,
	ip_version = 6,
	min_rtt = 0.16500000655651,
	max_rtt = 2.3670001029968,
	avg_rtt = 0.18199999630451,
	major = 5,
	minor = 6,
	avg_jitter = 0.0029999911785126,
	connection_uptime = 4713,
	serialization_version = 29,
	patch = 0,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "127.5",
		yl_commons_player_created = "1644205752",
		yl_commons_player_joined = "1662934903",
		["ocean_build.ocean_built"] = "2",
		punch_count = "903",
		digged_nodes = "7493",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}",
		died = "2",
		crafted = "251",
		["ethereal:fly_timer"] = "-99",
		played_time = "1955557",
		["signslib:pos"] = "(2153,19,1181)",
		["ocean_build.last_warning"] = "1.6588e+09",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 12100\", \"\", \"\", \"\", \"\", \"\"}",
		inflicted_damage = "145838",
		bitten = "0",
		xp = "0",
		repellant = "0",
		hud_state = "off",
		partychat = "party",
		arenalib_infobox_arenaID = "0",
		placed_nodes = "14080",
		yl_commons_thankyou = "24",
		jointime = "1644205752",
		["stamina:level"] = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}"
	}
}

Log identifier


[MOD] yl_report log identifier = iz9XfNPIqMhFxOlMTEw2iWC9LI9IZtSl

Profiler save:

profile-20220911T233955.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 7d 6h 44min 41s | max lag: 2.06s | clients: zing2, HorusDamocles, shanish2, AliasAlreadyTaken, Bailiff, bellgrade, Sokomine, Service, Squawk, AspireMint, Therottenpotato, daniel9, Oakenshield, daydream, rheo, pitman, flux, Xonon, LeetPeet

Teleport command:

/teleport xyz 1958 145 1490

Compass command:

/give_compass Construction iz9XfNPIqMhFxOlMTEw2iWC9LI9IZtSl D2691E 1958 145 1490
rheo reports a bug: > there's still lots of fireworks in the air all around haven, just waiting for an unsuspecting admin to fly past them and get a "boom" in their ear... Player position: ``` { x = 1957.8538818359, y = 144.74398803711, z = 1489.9150390625 } ``` Player look: ``` { x = -0.26848646998405, y = -0.59580445289612, z = -0.75692278146744 } ``` Player information: ``` { formspec_version = 6, lang_code = "", state = "Active", version_string = "5.6.0", protocol_version = 40, max_jitter = 2.1920001506805, ip_version = 6, min_rtt = 0.16500000655651, max_rtt = 2.3670001029968, avg_rtt = 0.18199999630451, major = 5, minor = 6, avg_jitter = 0.0029999911785126, connection_uptime = 4713, serialization_version = 29, patch = 0, min_jitter = 0 } ``` Player meta: ``` { fields = { ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "127.5", yl_commons_player_created = "1644205752", yl_commons_player_joined = "1662934903", ["ocean_build.ocean_built"] = "2", punch_count = "903", digged_nodes = "7493", yl_church = "return {[\"last_death\"] = {[\"y\"] = 15, [\"x\"] = 1353, [\"z\"] = 1089}}", died = "2", crafted = "251", ["ethereal:fly_timer"] = "-99", played_time = "1955557", ["signslib:pos"] = "(2153,19,1181)", ["ocean_build.last_warning"] = "1.6588e+09", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 12100\", \"\", \"\", \"\", \"\", \"\"}", inflicted_damage = "145838", bitten = "0", xp = "0", repellant = "0", hud_state = "off", partychat = "party", arenalib_infobox_arenaID = "0", placed_nodes = "14080", yl_commons_thankyou = "24", jointime = "1644205752", ["stamina:level"] = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", [4] = \"unified_inventory:bag_large\"}" } } ``` Log identifier ``` [MOD] yl_report log identifier = iz9XfNPIqMhFxOlMTEw2iWC9LI9IZtSl ``` Profiler save: ``` profile-20220911T233955.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 7d 6h 44min 41s | max lag: 2.06s | clients: zing2, HorusDamocles, shanish2, AliasAlreadyTaken, Bailiff, bellgrade, Sokomine, Service, Squawk, AspireMint, Therottenpotato, daniel9, Oakenshield, daydream, rheo, pitman, flux, Xonon, LeetPeet ``` Teleport command: ``` /teleport xyz 1958 145 1490 ``` Compass command: ``` /give_compass Construction iz9XfNPIqMhFxOlMTEw2iWC9LI9IZtSl D2691E 1958 145 1490 ```
AliasAlreadyTaken was assigned by yourland-report 2022-09-11 23:39:55 +00:00
flux added the
1. kind/bug
2. prio/good first issue
labels 2022-09-11 23:58:16 +00:00
Member

they should be static_save = false and possibly also load the blocks they will traverse

they should be `static_save = false` and possibly also load the blocks they will traverse

I added this in 4330ebe55d

However, existing rockets are not affected.

I added this in https://gitea.your-land.de/your-land/fireworks_redo/commit/4330ebe55d92b9f26b4fc501ff7145a7d80a975a However, existing rockets are not affected.
AliasAlreadyTaken added the
5. result/fixed
label 2022-09-12 07:33:31 +00:00
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-09-12 07:33:35 +00:00
AliasAlreadyTaken added the
3. source/mod upstream
label 2022-09-12 07:51:45 +00:00
https://gitlab.com/niwla2305/fireworks_redo/-/issues/2
flux added
4. step/partially fixed
and removed
5. result/fixed
labels 2022-09-23 00:31:48 +00:00

Modmaker most likely fell inactive :-/

Modmaker most likely fell inactive :-/
Member

when the ballistics mod i'm working on is done, and fireworks are rebuilt on top of that, the problem will be solved. not sure when i'll get back to that. on any day, the project i work on is dependent on how good i'm feeling. my best days are going to mob_composer, my worst are going to random minor issues or nothing at all. another push at the ballistics might be a while, but it will happen, the major remaining issue is just figuring out how to point the arrow in the right direction (geometry).

when the ballistics mod i'm working on is done, and fireworks are rebuilt on top of that, the problem will be solved. not sure when i'll get back to that. on any day, the project i work on is dependent on how good i'm feeling. my best days are going to mob_composer, my worst are going to random minor issues or nothing at all. another push at the ballistics might be a while, but it *will* happen, the major remaining issue is just figuring out how to point the arrow in the right direction (geometry).
Member

the fix for new rockets is live

the fix for new rockets is live
flux removed this from the 1.1.116 milestone 2022-11-18 00:45:50 +00:00
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-11-23 07:07:17 +00:00

Ups. You removed it from the milestone and I wondered why its not on there, although it is live?

What's the appropriate milestone, if any?

Ups. You removed it from the milestone and I wondered why its not on there, although it is live? What's the appropriate milestone, if any?
AliasAlreadyTaken removed this from the 1.1.116 milestone 2022-11-23 07:09:14 +00:00
Member

You removed it from the milestone and I wondered why its not on there, although it is live?

currently, there's no solution to the unresolved portion of the issue (which involves porting fireworks to the new ballistics API), so there's no valid milestone for the overall issue anymore.

i've made this sort of assessment to a number of other issues; if you want, i can instead create new issues for the remaining work that needs to be done, keep the old milestone, and close the present issue. as it's just you and me manaing the issues, i don't really see a need to be so formal.

> You removed it from the milestone and I wondered why its not on there, although it is live? currently, there's no solution to the unresolved portion of the issue (which involves porting fireworks to the new ballistics API), so there's no valid milestone for the overall issue anymore. i've made this sort of assessment to a number of other issues; if you want, i can instead create new issues for the remaining work that needs to be done, keep the old milestone, and close the present issue. as it's just you and me manaing the issues, i don't really see a need to be so formal.

Let's decide on how to deal with partially fixed issues: #3129

Let's decide on how to deal with partially fixed issues: #3129
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2655
No description provided.