Runtime error from mod '*builtin*' in callback on_chat_message(): String too long #2580

Closed
opened 2022-08-30 18:30:12 +00:00 by AliasAlreadyTaken · 9 comments

2022-08-30 17:45:59: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'builtin' in callback on_chat_message(): String too long
2022-08-30 17:45:59: ERROR[Main]: stack traceback:
2022-08-30 17:45:59: ERROR[Main]: [C]: in function 'old_chat_send_player'
2022-08-30 17:45:59: ERROR[Main]: ...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:118: in function 'chat_send_player'
2022-08-30 17:45:59: ERROR[Main]: /home/mt/5.5.1/Minetest_live/bin/../builtin/game/chat.lua:103: in function 'func'
2022-08-30 17:45:59: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100>
2022-08-30 17:45:59: ERROR[Main]: .../mt/5.5.1/Minetest_live/bin/../builtin/game/register.lua:429: in function <.../mt/5.5.1/Minetest_live/bin/../builtin/game/register.lua:415>
2022-08-30 17:54:01: ERROR[Main]: The following mods could not be found: "along_shore" "flowers_plus" "junglegrass" "mokapi"

2022-08-30 17:45:59: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): String too long 2022-08-30 17:45:59: ERROR[Main]: stack traceback: 2022-08-30 17:45:59: ERROR[Main]: [C]: in function 'old_chat_send_player' 2022-08-30 17:45:59: ERROR[Main]: ...test_live/bin/../mods/yl_commons/chatcommands/ignore.lua:118: in function 'chat_send_player' 2022-08-30 17:45:59: ERROR[Main]: /home/mt/5.5.1/Minetest_live/bin/../builtin/game/chat.lua:103: in function 'func' 2022-08-30 17:45:59: ERROR[Main]: ...inetest_live/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_live/bin/../builtin/profiler/instrumentation.lua:100> 2022-08-30 17:45:59: ERROR[Main]: .../mt/5.5.1/Minetest_live/bin/../builtin/game/register.lua:429: in function <.../mt/5.5.1/Minetest_live/bin/../builtin/game/register.lua:415> 2022-08-30 17:54:01: ERROR[Main]: The following mods could not be found: "along_shore" "flowers_plus" "junglegrass" "mokapi"
AliasAlreadyTaken added the
1. kind/bug
2. prio/critical
labels 2022-08-30 18:30:23 +00:00
Member

ah, interesting. looks like the result of /profile print was too large to send as a chat message. well, don't do that...

ah, interesting. looks like the result of `/profile print` was too large to send as a chat message. well, don't do that...
Author
Owner

Not sure, did anyone use /profiler print? Because I didn't, as far as I know?

That this command runs into an error is a very known issue

Not sure, did anyone use `/profiler print`? Because I didn't, as far as I know? That this command runs into an error is a very known issue
Member

Not sure, did anyone use /profiler print? Because I didn't, as far as I know?

i did, see #2578. i've had that error using /list_areas (before i fixed it). i wonder what sort of fix upstream would want.

> Not sure, did anyone use `/profiler print`? Because I didn't, as far as I know? i did, see #2578. i've had that error using `/list_areas` (before i fixed it). i wonder what sort of fix upstream would want.
Member

upstream issues:

upstream issues: * https://github.com/minetest/minetest/issues/10246 (`/profiler print` crash, closed as a duplicate of the thing below) * https://github.com/minetest/minetest/issues/9326 (generic "string too long" crash)
Member

fixed via f246064cd1

fixed via https://gitea.your-land.de/your-land/yl_commons/commit/f246064cd19c6ef5a3b4a6f7fd522a1759e99231
flux added the
4. step/ready to QA test
label 2022-08-30 23:04:52 +00:00
AliasAlreadyTaken added this to the 1.1.116 milestone 2022-09-12 10:32:13 +00:00
Author
Owner

This one doesn't appear to be fixed, I crashed the server again with

profiler print

This was the result:

2022-10-26 01:59:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): String too long
2022-10-26 01:59:10: ERROR[Main]: stack traceback:
2022-10-26 01:59:10: ERROR[Main]: 	[C]: in function 'old_chat_send_player'
2022-10-26 01:59:10: ERROR[Main]: 	...test_test/bin/../mods/yl_commons/chatcommands/ignore.lua:118: in function 'chat_send_player'
2022-10-26 01:59:10: ERROR[Main]: 	/home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:103: in function 'func'
2022-10-26 01:59:10: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100>
2022-10-26 01:59:10: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:417>

Looks like the ignore functionality grabs the content before the overwrite does?

This one doesn't appear to be fixed, I crashed the server again with ``` profiler print ``` This was the result: ``` 2022-10-26 01:59:10: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '*builtin*' in callback on_chat_message(): String too long 2022-10-26 01:59:10: ERROR[Main]: stack traceback: 2022-10-26 01:59:10: ERROR[Main]: [C]: in function 'old_chat_send_player' 2022-10-26 01:59:10: ERROR[Main]: ...test_test/bin/../mods/yl_commons/chatcommands/ignore.lua:118: in function 'chat_send_player' 2022-10-26 01:59:10: ERROR[Main]: /home/mt/5.6.1/Minetest_test/bin/../builtin/game/chat.lua:103: in function 'func' 2022-10-26 01:59:10: ERROR[Main]: ...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100> 2022-10-26 01:59:10: ERROR[Main]: .../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:431: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:417> ``` Looks like the ignore functionality grabs the content before the overwrite does?
AliasAlreadyTaken removed this from the 1.1.116 milestone 2022-10-26 02:01:30 +00:00
Member

Looks like the ignore functionality grabs the content before the overwrite does?

the fix for too-long messages became part of my builtin_overrides mod; i can re-insert the relevant code into yl_commons if you prefer.

then again it's not a perfect solution, but it should handle... 99.99% of messages.

> Looks like the ignore functionality grabs the content before the overwrite does? the fix for too-long messages became part of my [builtin_overrides](https://content.minetest.net/packages/rheo/builtin_overrides/) mod; i can re-insert the relevant code into yl_commons if you prefer. then again it's not a perfect solution, but it should handle... 99.99% of messages.
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2022-11-13 22:46:27 +00:00
Member

this is live

this is live
flux closed this issue 2022-11-13 22:46:34 +00:00
Author
Owner

i can re-insert the relevant code into yl_commons if you prefer.

We can do that as part of yl_commons cleanup, if license permits. No rush though.

> i can re-insert the relevant code into yl_commons if you prefer. We can do that as part of yl_commons cleanup, if license permits. No rush though.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2580
No description provided.