flux reports: if you /mail a player but don' ... #2549

Closed
opened 2022-08-26 04:06:52 +00:00 by yourland-report · 7 comments

flux reports a bug:

if you /mail a player but don't get the capitalization right, they will get a notice that they received a message, but won't actually "receive" it in their mailbox. (on the whole, minetest needs to be case-insensitive to player names, this is a common anti-pattern)

Player position:

{
	x = 1273.9790039063,
	y = 48,
	z = 607.92297363281
}

Player look:

{
	x = -0.02424168586731,
	y = 0.53154641389847,
	z = -0.84668219089508
}

Player information:

{
	major = 5,
	minor = 6,
	version_string = "5.6.0",
	protocol_version = 40,
	lang_code = "",
	formspec_version = 6,
	ip_version = 6,
	min_rtt = 0.16599999368191,
	max_rtt = 4.518000125885,
	avg_rtt = 0.179000005126,
	min_jitter = 0,
	max_jitter = 4.3420000076294,
	avg_jitter = 0.0039999932050705,
	connection_uptime = 2051,
	serialization_version = 29,
	patch = 0,
	state = "Active"
}

Player meta:

{
	fields = {
		played_time = "22422555",
		bitten = "0",
		arenalib_infobox_arenaID = "0",
		hud_state = "on",
		crafted = "39731",
		yl_commons_player_created = "1615351173",
		yl_commons_player_joined = "1661484786",
		xp = "1294148",
		repellant = "0",
		partychat = "party",
		["petz:lycanthropy"] = "1",
		["stamina:poisoned"] = "no",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:level"] = "15",
		digged_nodes = "1094669",
		["petz:werewolf_vignette_id"] = "20",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		yl_commons_thankyou = "149",
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 3860\", \"3d_armor:leggings_nether 1 7920\", \"3d_armor:helmet_nether 1 3960\", \"nether_mobs:dragon_shield 1 3960\", \"3d_armor:chestplate_nether 1 7920\", \"\"}",
		jointime = "1615351173",
		["petz:werewolf_clan_idx"] = "1",
		["stamina:exhaustion"] = "139",
		["petz:werewolf"] = "1",
		yl_church = "return {[\"last_death_portal\"] = 1660095612, [\"last_death\"] = {[\"y\"] = 15, [\"z\"] = 1874, [\"x\"] = 2417}, [\"last_heal\"] = 1615504208}",
		["signslib:pos"] = "(1273,69,540)",
		died = "68",
		inflicted_damage = "1633996",
		punch_count = "96837",
		placed_nodes = "353489"
	}
}

Log identifier


[MOD] yl_report log identifier = EMdAPDwlrk3TBAIOYB3hGrY0Yklj8phM

Profiler save:

profile-20220826T040652.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 3d 5h 26min 14s | max lag: 2.26s | clients: Laylem, Bla, haruhi, flux, AliasAlreadyTaken, johhn, annah, Xonon, Domough, Frostian, Ivanhoe, Aayush0350C, RIPBla, Mentaloid, Bailiff, daydream, pitman, Hulda, hbreturns, Service

Teleport command:

/teleport xyz 1274 48 608

Compass command:

/give_compass Construction EMdAPDwlrk3TBAIOYB3hGrY0Yklj8phM D2691E 1274 48 608
flux reports a bug: > if you /mail a player but don't get the capitalization right, they will get a notice that they received a message, but won't actually "receive" it in their mailbox. (on the whole, minetest needs to be case-insensitive to player names, this is a common anti-pattern) Player position: ``` { x = 1273.9790039063, y = 48, z = 607.92297363281 } ``` Player look: ``` { x = -0.02424168586731, y = 0.53154641389847, z = -0.84668219089508 } ``` Player information: ``` { major = 5, minor = 6, version_string = "5.6.0", protocol_version = 40, lang_code = "", formspec_version = 6, ip_version = 6, min_rtt = 0.16599999368191, max_rtt = 4.518000125885, avg_rtt = 0.179000005126, min_jitter = 0, max_jitter = 4.3420000076294, avg_jitter = 0.0039999932050705, connection_uptime = 2051, serialization_version = 29, patch = 0, state = "Active" } ``` Player meta: ``` { fields = { played_time = "22422555", bitten = "0", arenalib_infobox_arenaID = "0", hud_state = "on", crafted = "39731", yl_commons_player_created = "1615351173", yl_commons_player_joined = "1661484786", xp = "1294148", repellant = "0", partychat = "party", ["petz:lycanthropy"] = "1", ["stamina:poisoned"] = "no", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:level"] = "15", digged_nodes = "1094669", ["petz:werewolf_vignette_id"] = "20", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", yl_commons_thankyou = "149", ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 3860\", \"3d_armor:leggings_nether 1 7920\", \"3d_armor:helmet_nether 1 3960\", \"nether_mobs:dragon_shield 1 3960\", \"3d_armor:chestplate_nether 1 7920\", \"\"}", jointime = "1615351173", ["petz:werewolf_clan_idx"] = "1", ["stamina:exhaustion"] = "139", ["petz:werewolf"] = "1", yl_church = "return {[\"last_death_portal\"] = 1660095612, [\"last_death\"] = {[\"y\"] = 15, [\"z\"] = 1874, [\"x\"] = 2417}, [\"last_heal\"] = 1615504208}", ["signslib:pos"] = "(1273,69,540)", died = "68", inflicted_damage = "1633996", punch_count = "96837", placed_nodes = "353489" } } ``` Log identifier ``` [MOD] yl_report log identifier = EMdAPDwlrk3TBAIOYB3hGrY0Yklj8phM ``` Profiler save: ``` profile-20220826T040652.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 3d 5h 26min 14s | max lag: 2.26s | clients: Laylem, Bla, haruhi, flux, AliasAlreadyTaken, johhn, annah, Xonon, Domough, Frostian, Ivanhoe, Aayush0350C, RIPBla, Mentaloid, Bailiff, daydream, pitman, Hulda, hbreturns, Service ``` Teleport command: ``` /teleport xyz 1274 48 608 ``` Compass command: ``` /give_compass Construction EMdAPDwlrk3TBAIOYB3hGrY0Yklj8phM D2691E 1274 48 608 ```
AliasAlreadyTaken was assigned by yourland-report 2022-08-26 04:06:52 +00:00
flux added the
1. kind/bug
3. source/mod upstream
labels 2022-08-26 04:38:39 +00:00
https://github.com/mt-mods/mail/issues/17
flux added the
2. prio/interesting
label 2022-10-10 17:17:45 +00:00
flux added this to the flux's TODO list project 2022-10-10 17:17:48 +00:00
flux self-assigned this 2022-10-10 17:17:53 +00:00
Member

mail should make use of canonical_name

mail should make use of [canonical_name](https://github.com/fluxionary/minetest-canonical_name)
flux added the
4. step/blocked
label 2023-02-23 21:48:45 +00:00
Member
upstream PR: https://github.com/mt-mods/mail/pull/28
flux added
4. step/ready to QA test
and removed
4. step/blocked
labels 2023-02-23 22:56:55 +00:00
Member

upstream is fixed, though the PR got superseded.

upstream is fixed, though the PR got superseded.
AliasAlreadyTaken added this to the 1.1.118 milestone 2023-04-13 19:35:20 +00:00
AliasAlreadyTaken added the
ugh/QA OK
label 2023-04-13 19:35:25 +00:00
Member

this is not live - canonical_name isn't installed. however, sending mail to a misspelled name will now fail and print a message.

this is *not* live - canonical_name isn't installed. however, sending mail to a misspelled name will now fail and print a message.

-> 1.1.119

-> 1.1.119
AliasAlreadyTaken modified the milestone from 1.1.118 to 1.1.119 2023-05-06 20:17:57 +00:00
flux added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-05-18 18:28:56 +00:00
flux removed this from the flux's TODO list project 2023-05-18 18:28:59 +00:00
AliasAlreadyTaken was unassigned by flux 2023-05-18 18:29:02 +00:00
flux removed their assignment 2023-05-18 18:29:02 +00:00
Member

this is live

this is live
flux closed this issue 2023-05-18 18:29:09 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2549
No description provided.