your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

flux reports: we need an itemframe where the ... #2067

New Issue
Open
opened 2022-06-12 03:08:02 +00:00 by yourland-report · 14 comments
yourland-report commented 2022-06-12 03:08:02 +00:00
Member
Copy Link

flux reports a bug:

we need an itemframe where the "background image" is a plate. it might be nice to even have a couple different styles of such plates

Player position:

{
	y = 69.5,
	x = 1262.8070068359,
	z = 551.09600830078
}

Player look:

{
	y = -0.86127460002899,
	x = -0.045877262949944,
	z = -0.50606453418732
}

Player information:

{
	min_rtt = 0.15099999308586,
	max_rtt = 4.0710000991821,
	connection_uptime = 40178,
	max_jitter = 1.6980000734329,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-d208be276-dirty",
	avg_rtt = 0.15999999642372,
	state = "Active",
	avg_jitter = 0.0019999891519547,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 2880\", \"3d_armor:helmet_nether 1 1440\", \"3d_armor:leggings_nether 1 2880\", \"nether_mobs:dragon_boots 1 1440\", \"nether_mobs:dragon_shield 1 1440\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		played_time = "17252747",
		jointime = "1615351173",
		["stamina:poisoned"] = "no",
		["stamina:exhaustion"] = "81",
		["signslib:pos"] = "(2583,11,3234)",
		digged_nodes = "1058632",
		punch_count = "79147",
		yl_commons_player_joined = "1654963118",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		["petz:werewolf_clan_idx"] = "1",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29400, [\"x\"] = 2338, [\"z\"] = 1226}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}",
		yl_commons_thankyou = "124",
		["stamina:level"] = "15",
		xp = "1238808",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1274840",
		crafted = "36121",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf"] = "0",
		placed_nodes = "346857",
		died = "65",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = IkZYQCSFcb9bRRP7oVsStvJUNhOxyvSV

Profiler save:

profile-20220612T050802.json_prettyEE

Status:

# Server: version: 5.5.1-yl | game: Minetest Game | uptime: 11h 33min 8s | max lag: 1.96s | clients: Giuseppe, Zonon, Alex1977, evil1234, Gardenfire2007, LadyPyle, daydream, jackofthebean000, Bailiff, HorusDamocles, plod, pitman, Boot, flux

Teleport command:

/teleport xyz 1263 70 551

Compass command:

/give_compass Construction IkZYQCSFcb9bRRP7oVsStvJUNhOxyvSV D2691E 1263 70 551
flux reports a bug: > we need an itemframe where the "background image" is a plate. it might be nice to even have a couple different styles of such plates Player position: ``` { y = 69.5, x = 1262.8070068359, z = 551.09600830078 } ``` Player look: ``` { y = -0.86127460002899, x = -0.045877262949944, z = -0.50606453418732 } ``` Player information: ``` { min_rtt = 0.15099999308586, max_rtt = 4.0710000991821, connection_uptime = 40178, max_jitter = 1.6980000734329, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-d208be276-dirty", avg_rtt = 0.15999999642372, state = "Active", avg_jitter = 0.0019999891519547, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_nether 1 2880\", \"3d_armor:helmet_nether 1 1440\", \"3d_armor:leggings_nether 1 2880\", \"nether_mobs:dragon_boots 1 1440\", \"nether_mobs:dragon_shield 1 1440\", \"\"}", ["petz:werewolf_vignette_id"] = "20", played_time = "17252747", jointime = "1615351173", ["stamina:poisoned"] = "no", ["stamina:exhaustion"] = "81", ["signslib:pos"] = "(2583,11,3234)", digged_nodes = "1058632", punch_count = "79147", yl_commons_player_joined = "1654963118", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", ["petz:werewolf_clan_idx"] = "1", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29400, [\"x\"] = 2338, [\"z\"] = 1226}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1653796347}", yl_commons_thankyou = "124", ["stamina:level"] = "15", xp = "1238808", arenalib_infobox_arenaID = "0", inflicted_damage = "1274840", crafted = "36121", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf"] = "0", placed_nodes = "346857", died = "65", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = IkZYQCSFcb9bRRP7oVsStvJUNhOxyvSV ``` Profiler save: ``` profile-20220612T050802.json_prettyEE ``` Status: ``` # Server: version: 5.5.1-yl | game: Minetest Game | uptime: 11h 33min 8s | max lag: 1.96s | clients: Giuseppe, Zonon, Alex1977, evil1234, Gardenfire2007, LadyPyle, daydream, jackofthebean000, Bailiff, HorusDamocles, plod, pitman, Boot, flux ``` Teleport command: ``` /teleport xyz 1263 70 551 ``` Compass command: ``` /give_compass Construction IkZYQCSFcb9bRRP7oVsStvJUNhOxyvSV D2691E 1263 70 551 ```
AliasAlreadyTaken was assigned by yourland-report 2022-06-12 03:08:02 +00:00
AliasAlreadyTaken added the
1. kind/enhancement
 label 2022-06-12 13:02:25 +00:00
AliasAlreadyTaken commented 2022-06-12 13:03:45 +00:00
Owner
Copy Link

That's a nice idea, could even be used upstream. The node already has item meta, so we could just save a texture file there and display it, instead of having "itemframe", "itemframe invisible", "itemframe plate" and so forth.

Should I post the suggestion upstream?

That's a nice idea, could even be used upstream. The node already has item meta, so we could just save a texture file there and display it, instead of having "itemframe", "itemframe invisible", "itemframe plate" and so forth. Should I post the suggestion upstream?
flux commented 2022-06-12 16:14:16 +00:00
Member
Copy Link

If you think they'll implement it upstream, sure. I'm not sure it's a good idea to turn the thing into 2 entities to save a couple of nodes, though.

If you think they'll implement it upstream, sure. I'm not sure it's a good idea to turn the thing into 2 entities to save a couple of nodes, though.
AliasAlreadyTaken commented 2022-06-16 01:32:40 +00:00
Owner
Copy Link

Couldn't we make it a texture modifier? Where the plate/invisible/... background is read from a value in nodemeta and then the item gets displayed on top?

Couldn't we make it a texture modifier? Where the plate/invisible/... background is read from a value in nodemeta and then the item gets displayed on top?
flux commented 2022-06-16 02:17:43 +00:00
Member
Copy Link

Couldn't we make it a texture modifier? Where the plate/invisible/... background is read from a value in nodemeta and then the item gets displayed on top?

i don't think it's possible to use node metadata to change the visible texture? i think the game should give us the ability to e.g. change paramtype1, paramtype2 to link specific textures or meshes or nodeboxes... but that'd be a heavy change on the engine.

currently the only modifier for a node's textures is via a palette.

> Couldn't we make it a texture modifier? Where the plate/invisible/... background is read from a value in nodemeta and then the item gets displayed on top? i don't think it's possible to use node metadata to change the visible texture? i think the game should give us the ability to e.g. change paramtype1, paramtype2 to link specific textures or meshes or nodeboxes... but that'd be a heavy change on the engine. currently the only modifier for a node's textures is via a palette.
AliasAlreadyTaken commented 2022-06-17 23:34:41 +00:00
Owner
Copy Link

The mechanic that changes the item texture as soon as we place a new item in could look at node meta, read the value and place the appropriate picture in the background. The problem is more a UI one: How would someone change that node meta?

The mechanic that changes the item texture as soon as we place a new item in could look at node meta, read the value and place the appropriate picture in the background. The problem is more a UI one: How would someone change that node meta?
flux commented 2022-06-17 23:49:53 +00:00
Member
Copy Link

The mechanic that changes the item texture as soon as we place a new item in could look at node meta, read the value and place the appropriate picture in the background. The problem is more a UI one: How would someone change that node meta?

my objection isn't that it couldn't be done this way, but that you'd need a 2nd entity to handle the 2nd texture, and we're already trying to deal w/ having too many entities in places like haven. i feel like it's important to not exacerbate that by turning all item frames into 2 entities.

> The mechanic that changes the item texture as soon as we place a new item in could look at node meta, read the value and place the appropriate picture in the background. The problem is more a UI one: How would someone change that node meta? my objection isn't that it couldn't be done this way, but that you'd need a 2nd entity to handle the 2nd texture, and we're already trying to deal w/ having too many entities in places like haven. i feel like it's important to not exacerbate that by turning all item frames into 2 entities.
flux commented 2022-06-17 23:52:06 +00:00
Member
Copy Link

oh i get it, you want to compose the plate texture w/ the other entity texture. but that can't work, because the the current entity is a wielditem, and the texture is specified by an itemstring. that's why you'd need a 2nd entity. either that, or create a dummy item for every registered item in the game w/ a wield image that does that composition... which is a terrible idea.

oh i get it, you want to compose the plate texture w/ the other entity texture. but that can't work, because the the current entity is a wielditem, and the texture is specified by an itemstring. that's why you'd need a 2nd entity. either that, or create a dummy item for every registered item in the game w/ a wield image that does that composition... which is a terrible idea.
flux commented 2022-06-17 23:53:57 +00:00
Member
Copy Link

see ae555465ba/doc/lua_api.txt (L7515-L7533)

there's no general mechanism to replicate the mechanic that the wielditem visual uses, hence why my smartshop fork has different kinds of entities. sprite visuals cause less FPS lag, but you can't represent nodebox or mesh drawtypes, and things get wonky if there's animations.

see https://github.com/minetest/minetest/blob/ae555465ba1c02d5fe6b409c50191ddc34d26d75/doc/lua_api.txt#L7515-L7533 there's no general mechanism to replicate the mechanic that the `wielditem` visual uses, hence why my smartshop fork has different kinds of entities. `sprite` visuals cause less FPS lag, but you can't represent `nodebox` or mesh `drawtypes`, and things get wonky if there's animations.
flux commented 2022-06-19 00:17:13 +00:00
Member
Copy Link

while looking around for a plate nodebox/texture to steal, i found https://forum.minetest.net/viewtopic.php?p=403908 which looks real interesting...

while looking around for a plate nodebox/texture to steal, i found https://forum.minetest.net/viewtopic.php?p=403908 which looks real interesting...
flux commented 2022-07-02 19:03:55 +00:00
Member
Copy Link

cf. #1169

cf. #1169
flux added this to the flux's TODO list project 2022-07-02 22:13:00 +00:00
flux added the
1. kind/node limit
2. prio/elevated
 labels 2022-10-28 20:51:56 +00:00
flux commented 2022-10-28 22:58:54 +00:00
Member
Copy Link

created one: https://content.minetest.net/packages/rheo/itemplate/

created one: https://content.minetest.net/packages/rheo/itemplate/ ![](https://gitea.your-land.de/attachments/c3a1f925-eead-4a0d-9152-152b7c564638)
screenshot.png
3.8 MiB
flux added the
4. step/ready to QA test
 label 2022-10-28 22:59:22 +00:00
flux added this to the 1.1.117 milestone 2022-11-18 22:47:09 +00:00
AliasAlreadyTaken removed this from the 1.1.117 milestone 2023-01-18 14:37:41 +00:00
AliasAlreadyTaken commented 2024-02-26 13:55:14 +00:00
Owner
Copy Link

Opinions please: 1. Add this mod standalone? 2. PR "upstream" to itemframes? 3. Close as wontfix?

I'm slightly in favour of 2, then 1

Opinions please: 1. Add this mod standalone? 2. PR "upstream" to itemframes? 3. Close as wontfix? I'm slightly in favour of 2, then 1
whosit commented 2024-02-26 14:13:31 +00:00
Member
Copy Link

Feels more like a standalone thing... Even though it's basically an itemframe...

This mod could potentially try to do something special, like displaying alternative models for known food...
(imagine a 3d burger :P)

(makes sense since YL is a cooking simulation server)

Feels more like a standalone thing... Even though it's basically an itemframe... This mod could potentially try to do something special, like displaying alternative models for known food... (imagine a 3d burger :P) (makes sense since YL is a cooking simulation server)
😆 1
flux commented 2024-03-03 04:43:13 +00:00
Member
Copy Link

it'd be nice if the original itemframe was an API, and you could just import that and choose which kind of itemframe nodes you wanted to use.

the main reason i depend on the original itemframe mod is to not duplicate code. we've fixed upstream itemframe issues before.

it'd be nice if the original itemframe was an API, and you could just import that and choose which kind of itemframe nodes you wanted to use. the main reason i depend on the original itemframe mod is to not duplicate code. we've fixed upstream itemframe issues before.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#2067
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?