filter-injector.lua:211: bad argument #1 to 'ipairs' (table expected, got nil) #2005

New Issue

AliasAlreadyTaken · 2022-05-30T02:42:08Z

AliasAlreadyTaken commented

2022-05-30 02:42:08 +00:00

2022-05-30 04:35:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:211: bad argument #1 to 'ipairs' (table expected, got nil)
2022-05-30 04:35:08: ERROR[Main]: stack traceback:
2022-05-30 04:35:08: ERROR[Main]: [C]: in function 'ipairs'
2022-05-30 04:35:08: ERROR[Main]: .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:211: in function 'punch_filter'
2022-05-30 04:35:08: ERROR[Main]: .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:485: in function 'action_on'
2022-05-30 04:35:08: ERROR[Main]: ...Minetest_test/bin/../mods/mesecons/mesecons/internal.lua:193: in function <...Minetest_test/bin/../mods/mesecons/mesecons/internal.lua:186>
2022-05-30 04:35:08: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute'
2022-05-30 04:35:08: ERROR[Main]: ...st/worldmods/mesecons_debug/overrides/mesecons_queue.lua:20: in function 'execute'
2022-05-30 04:35:08: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73>
2022-05-30 04:35:08: ERROR[Main]: ...ive/5.5.1/Minetest_test/bin/../builtin/game/register.lua:430: in function <...ive/5.5.1/Minetest_test/bin/../builtin/game/register.lua:416>

2022-05-30 04:35:08: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod '??' in callback environment_Step(): .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:211: bad argument #1 to 'ipairs' (table expected, got nil) 2022-05-30 04:35:08: ERROR[Main]: stack traceback: 2022-05-30 04:35:08: ERROR[Main]: [C]: in function 'ipairs' 2022-05-30 04:35:08: ERROR[Main]: .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:211: in function 'punch_filter' 2022-05-30 04:35:08: ERROR[Main]: .../Minetest_test/bin/../mods/pipeworks/filter-injector.lua:485: in function 'action_on' 2022-05-30 04:35:08: ERROR[Main]: ...Minetest_test/bin/../mods/mesecons/mesecons/internal.lua:193: in function <...Minetest_test/bin/../mods/mesecons/mesecons/internal.lua:186> 2022-05-30 04:35:08: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:137: in function 'old_execute' 2022-05-30 04:35:08: ERROR[Main]: ...st/worldmods/mesecons_debug/overrides/mesecons_queue.lua:20: in function 'execute' 2022-05-30 04:35:08: ERROR[Main]: ...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:111: in function <...etest_test/bin/../mods/mesecons/mesecons/actionqueue.lua:73> 2022-05-30 04:35:08: ERROR[Main]: ...ive/5.5.1/Minetest_test/bin/../builtin/game/register.lua:430: in function <...ive/5.5.1/Minetest_test/bin/../builtin/game/register.lua:416>

flux commented

2022-05-30 02:43:49 +00:00

This time, it isn't even pipeworks' fault. Very few mods can handle their metadata being taken out from under them.

flux added the

1. kind/bug

2. prio/critical

labels 2022-07-02 22:03:25 +00:00

flux commented

2022-07-02 22:03:59 +00:00

(this was due to removing all node metadata in a region)

AliasAlreadyTaken added the

3. source/integration

label 2022-08-07 09:19:35 +00:00

AliasAlreadyTaken commented

2023-01-05 11:03:26 +00:00

What rules do we have to obey to not trigger the issue? Like "no WE adding, removing, moving, no nothing when mesemachines/pipeworks/... are involved" ?

Or is that a more general problem and we also need to play attention when using WE on smartshops, workbenches and similar?

What rules do we have to obey to not trigger the issue? Like "no WE adding, removing, moving, no nothing when mesemachines/pipeworks/... are involved" ? Or is that a more general problem and we also need to play attention when using WE on smartshops, workbenches and similar?

AliasAlreadyTaken added the

4. step/question

label 2023-01-05 11:03:33 +00:00

flux commented

2023-01-05 19:36:18 +00:00

WE-ing machines creates problems, because most machines require construction/destruction logic in order to properly initialize, and WE (generally) doesn't call these constructors. it generally does try to copy metadata, but that's not always enough.

i doubt WE-ing mesecons/smartshops will cause much of a problem, but pipeworks keeps track of a lot of metadata outside of individual nodes. note that tubelib/techpack has similar problems.

but more than that, wiping metadata of existing nodes is almost certain to cause problems for all sorts of things.

WE-ing machines creates problems, because most machines require construction/destruction logic in order to properly initialize, and WE (generally) doesn't call these constructors. it generally *does* try to copy metadata, but that's not always enough. i doubt WE-ing mesecons/smartshops will cause much of a problem, but pipeworks keeps track of a lot of metadata outside of individual nodes. note that tubelib/techpack has similar problems. but more than that, wiping metadata of *existing* nodes is almost certain to cause problems for all sorts of things.

👍 1

AliasAlreadyTaken commented

2023-12-05 13:36:37 +00:00

Hasn't happened ever since, we'll reopen if it does

AliasAlreadyTaken closed this issue

2023-12-05 13:36:38 +00:00

AliasAlreadyTaken added

5. result/cannot reproduce

and removed

4. step/question

labels 2023-12-05 13:36:48 +00:00

Sign in to join this conversation.