JeCel reports: When Milky Medieval Glass is p ... #1768

New Issue

yourland-report · 2022-04-15T14:14:47Z

yourland-report commented

2022-04-15 14:14:47 +00:00

JeCel reports a bug:

When Milky Medieval Glass is placed and then dug, it can't be put on a stack with those, that haven't been placed and dug yet. Therefore two different stacks of the same block are created.

Player position:

{
	y = -25.499000549316,
	x = 6577.9389648438,
	z = 10365.19921875
}

Player look:

{
	y = -0.41151434183121,
	x = 0.68972033262253,
	z = 0.59576994180679
}

Player information:

{
	min_rtt = 0.023000000044703,
	max_rtt = 0.46399998664856,
	connection_uptime = 7168,
	max_jitter = 0.43599998950958,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.032000001519918,
	state = "Active",
	avg_jitter = 0.0079999975860119,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14980\", \"3d_armor:chestplate_crystal 1 15100\", \"3d_armor:leggings_crystal 1 14980\", \"shields:shield_crystal 1 14980\", \"3d_armor:boots_crystal 1 18940\", \"\"}",
		played_time = "687763",
		jointime = "1621787993",
		yl_commons_player_joined = "1650024954",
		["stamina:exhaustion"] = "128",
		digged_nodes = "353985",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29247, [\"x\"] = 1962, [\"z\"] = 1559}}",
		["stamina:poisoned"] = "no",
		["stamina:level"] = "18",
		punch_count = "3125",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "22614",
		crafted = "148784",
		xp = "540097",
		yl_commons_thankyou = "2",
		placed_nodes = "55852",
		died = "12",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621787993"
	}
}

Log identifier


[MOD] yl_report log identifier = kdWNWZVVpet4pDcufJa9ZMNXgjSCWcJH

Profiler save:

profile-20220415T161446.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 14h 46min 16s | max lag: 4.6s | clients: sansational64, Kilarin, shanish2, PLOC, ramneeiu, AliasAlreadyTaken, JeCel, Aleks555, Imhotheb, pitman, Akshay_444, Bailiff, debiankaios, Bla, Morphelia, Papi, Ernle1, googl, slayer, tour, drgn, Service, Greater_Dog, Boot

Teleport command:

/teleport xyz 6578 -25 10365

Compass command:

/give_compass Construction kdWNWZVVpet4pDcufJa9ZMNXgjSCWcJH D2691E 6578 -25 10365

JeCel reports a bug: > When Milky Medieval Glass is placed and then dug, it can't be put on a stack with those, that haven't been placed and dug yet. Therefore two different stacks of the same block are created. Player position: ``` { y = -25.499000549316, x = 6577.9389648438, z = 10365.19921875 } ``` Player look: ``` { y = -0.41151434183121, x = 0.68972033262253, z = 0.59576994180679 } ``` Player information: ``` { min_rtt = 0.023000000044703, max_rtt = 0.46399998664856, connection_uptime = 7168, max_jitter = 0.43599998950958, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.032000001519918, state = "Active", avg_jitter = 0.0079999975860119, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 14980\", \"3d_armor:chestplate_crystal 1 15100\", \"3d_armor:leggings_crystal 1 14980\", \"shields:shield_crystal 1 14980\", \"3d_armor:boots_crystal 1 18940\", \"\"}", played_time = "687763", jointime = "1621787993", yl_commons_player_joined = "1650024954", ["stamina:exhaustion"] = "128", digged_nodes = "353985", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29247, [\"x\"] = 1962, [\"z\"] = 1559}}", ["stamina:poisoned"] = "no", ["stamina:level"] = "18", punch_count = "3125", arenalib_infobox_arenaID = "0", inflicted_damage = "22614", crafted = "148784", xp = "540097", yl_commons_thankyou = "2", placed_nodes = "55852", died = "12", hud_state = "on", repellant = "0", yl_commons_player_created = "1621787993" } } ``` Log identifier ``` [MOD] yl_report log identifier = kdWNWZVVpet4pDcufJa9ZMNXgjSCWcJH ``` Profiler save: ``` profile-20220415T161446.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 14h 46min 16s | max lag: 4.6s | clients: sansational64, Kilarin, shanish2, PLOC, ramneeiu, AliasAlreadyTaken, JeCel, Aleks555, Imhotheb, pitman, Akshay_444, Bailiff, debiankaios, Bla, Morphelia, Papi, Ernle1, googl, slayer, tour, drgn, Service, Greater_Dog, Boot ``` Teleport command: ``` /teleport xyz 6578 -25 10365 ``` Compass command: ``` /give_compass Construction kdWNWZVVpet4pDcufJa9ZMNXgjSCWcJH D2691E 6578 -25 10365 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-15 14:14:47 +00:00

flux commented

2022-04-15 16:41:59 +00:00

this is a longstanding issue w/ unified dye, having to do w/ how paramtype2 = "color" is handled w.r.t. the unified dye palette. basically, uncolored (white) nodes don't have param2 = 0, because white is not at position 0 on unified dye's palettes. when the "default" node, which isn't storing the param2 value in metadata, is placed and broken, the dug-up node will have the "param2=240" value, and won't stack.

unfortunately vanessae's repo has been totally deleted, so there's no way to reference the issue that as it was presented there.

i think the proposed solution was to not store the metadata value for the default (white, 240) value?

before we do any work on this, are we currently using the most recent commit from https://github.com/mt-mods/unifieddyes?

this is a longstanding issue w/ unified dye, having to do w/ how `paramtype2 = "color"` is handled w.r.t. the unified dye palette. basically, uncolored (white) nodes don't have `param2 = 0`, because white is not at position 0 on unified dye's palettes. when the "default" node, which isn't storing the param2 value in metadata, is placed and broken, the dug-up node will have the "param2=240" value, and won't stack. unfortunately vanessae's repo has been totally deleted, so there's no way to reference the issue that as it was presented there. i think the proposed solution was to *not* store the metadata value for the default (white, 240) value? before we do any work on this, are we currently using the most recent commit from https://github.com/mt-mods/unifieddyes?

flux added the

1. kind/bug

4. step/question

3. source/mod upstream

labels 2022-04-15 16:42:16 +00:00

flux commented

2022-04-15 16:43:48 +00:00

Answer: yes, it looks like we are. I'll bug the mt-mods people about this at some point.

flux removed the

4. step/question

label 2022-04-15 16:43:57 +00:00

AliasAlreadyTaken was unassigned by flux

2022-04-15 16:44:23 +00:00

flux self-assigned this 2022-04-15 16:44:23 +00:00

flux commented

2022-04-15 21:44:32 +00:00

It's not a bug in unifieddye.

Need to replace

        minetest.register_craft({
                output = "darkage:milk_glass",
                type = "shapeless",
                recipe = {"darkage:glass", "dye:white"}
        })

with

    unifieddyes.register_color_craft({
        output = "darkage:milk_glass",
        palette = "extended",
        type = "shapeless",
        neutral_node = "darkage:glass",
        recipe = {
                 "NEUTRAL_NODE",
                 "MAIN_DYE"
        }
    })

etc. gotta AFK in a minute so just making a note of this for now.

It's not a bug in unifieddye. Need to replace ```lua minetest.register_craft({ output = "darkage:milk_glass", type = "shapeless", recipe = {"darkage:glass", "dye:white"} }) ``` with ```lua unifieddyes.register_color_craft({ output = "darkage:milk_glass", palette = "extended", type = "shapeless", neutral_node = "darkage:glass", recipe = { "NEUTRAL_NODE", "MAIN_DYE" } }) ``` etc. gotta AFK in a minute so just making a note of this for now.

flux added this to the flux's TODO list project 2022-07-02 20:49:11 +00:00

flux commented

2022-10-27 00:30:15 +00:00

upstream PR https://github.com/adrido/darkage/pull/14

flux added the

4. step/blocked

label 2022-10-27 00:30:23 +00:00

flux added

4. step/ready to QA test

and removed

4. step/blocked

labels 2022-12-01 00:46:10 +00:00