flux reports: it bothers me that youngtrees ... #1707

New Issue

yourland-report · 2022-04-09T00:21:10Z

yourland-report commented

2022-04-09 00:21:10 +00:00

flux reports a bug:

it bothers me that youngtrees and bushes from plantlife break when you even touch them, and can't be grown

Player position:

{
	y = 73.5,
	x = 5754.1923828125,
	z = 5779.5219726563
}

Player look:

{
	y = -0.95772212743759,
	x = 0.0072295400314033,
	z = 0.28760400414467
}

Player information:

{
	min_rtt = 0.15000000596046,
	max_rtt = 4.103000164032,
	connection_uptime = 77730,
	max_jitter = 3.9070000648499,
	minor = 6,
	major = 5,
	ip_version = 6,
	formspec_version = 5,
	patch = 0,
	protocol_version = 40,
	serialization_version = 29,
	lang_code = "",
	version_string = "5.6.0-dev-9683cc17c",
	avg_rtt = 0.16200000047684,
	state = "Active",
	avg_jitter = 0.0039999932050705,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4160\", \"3d_armor:helmet_nether 1 4160\", \"3d_armor:leggings_nether 1 8320\", \"3d_armor:chestplate_nether 1 8320\", \"nether_mobs:dragon_shield 1 4160\", \"\"}",
		["petz:werewolf_vignette_id"] = "21",
		played_time = "13167147",
		jointime = "1615351173",
		yl_commons_player_joined = "1649385956",
		["stamina:exhaustion"] = "124.5",
		["signslib:pos"] = "(1240,-2,2263)",
		digged_nodes = "1025012",
		["petz:werewolf"] = "0",
		xp = "1222654",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		died = "60",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 39, [\"x\"] = -241, [\"z\"] = -2078}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1644977020}",
		yl_commons_thankyou = "103",
		["stamina:level"] = "15",
		punch_count = "69141",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1073154",
		crafted = "34146",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf_clan_idx"] = "1",
		["stamina:poisoned"] = "no",
		placed_nodes = "340934",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = 3aBG9RbWqOo6TJ2igzIrCOlGUin9Y29j

Profiler save:

profile-20220409T022109.json_prettyEE

Status:

# Server: version: 5.5.0-yl | game: Minetest Game | uptime: 3d 1h 59min 46s | max lag: 2.15s | clients: Coolstorms, Flatulenator, DanteLives, Sokomine, Test_User, Service, AliasAlreadyTaken, shanish, shanish2, Boot, resU_tseT, aliwoto, Bailiff, flux

Teleport command:

/teleport xyz 5754 74 5780

Compass command:

/give_compass Construction 3aBG9RbWqOo6TJ2igzIrCOlGUin9Y29j D2691E 5754 74 5780

flux reports a bug: > it bothers me that youngtrees and bushes from plantlife break when you even touch them, and can't be grown Player position: ``` { y = 73.5, x = 5754.1923828125, z = 5779.5219726563 } ``` Player look: ``` { y = -0.95772212743759, x = 0.0072295400314033, z = 0.28760400414467 } ``` Player information: ``` { min_rtt = 0.15000000596046, max_rtt = 4.103000164032, connection_uptime = 77730, max_jitter = 3.9070000648499, minor = 6, major = 5, ip_version = 6, formspec_version = 5, patch = 0, protocol_version = 40, serialization_version = 29, lang_code = "", version_string = "5.6.0-dev-9683cc17c", avg_rtt = 0.16200000047684, state = "Active", avg_jitter = 0.0039999932050705, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"nether_mobs:dragon_boots 1 4160\", \"3d_armor:helmet_nether 1 4160\", \"3d_armor:leggings_nether 1 8320\", \"3d_armor:chestplate_nether 1 8320\", \"nether_mobs:dragon_shield 1 4160\", \"\"}", ["petz:werewolf_vignette_id"] = "21", played_time = "13167147", jointime = "1615351173", yl_commons_player_joined = "1649385956", ["stamina:exhaustion"] = "124.5", ["signslib:pos"] = "(1240,-2,2263)", digged_nodes = "1025012", ["petz:werewolf"] = "0", xp = "1222654", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", died = "60", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 39, [\"x\"] = -241, [\"z\"] = -2078}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1644977020}", yl_commons_thankyou = "103", ["stamina:level"] = "15", punch_count = "69141", arenalib_infobox_arenaID = "0", inflicted_damage = "1073154", crafted = "34146", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf_clan_idx"] = "1", ["stamina:poisoned"] = "no", placed_nodes = "340934", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = 3aBG9RbWqOo6TJ2igzIrCOlGUin9Y29j ``` Profiler save: ``` profile-20220409T022109.json_prettyEE ``` Status: ``` # Server: version: 5.5.0-yl | game: Minetest Game | uptime: 3d 1h 59min 46s | max lag: 2.15s | clients: Coolstorms, Flatulenator, DanteLives, Sokomine, Test_User, Service, AliasAlreadyTaken, shanish, shanish2, Boot, resU_tseT, aliwoto, Bailiff, flux ``` Teleport command: ``` /teleport xyz 5754 74 5780 ``` Compass command: ``` /give_compass Construction 3aBG9RbWqOo6TJ2igzIrCOlGUin9Y29j D2691E 5754 74 5780 ```

AliasAlreadyTaken was assigned by yourland-report

2022-04-09 00:21:10 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-04-09 00:22:47 +00:00

AliasAlreadyTaken commented

2022-04-09 00:23:43 +00:00

Good idea. We should make all growable stuff re-growable with an lbm. Not only bushes, youngtree-bushes and other flora, but also farming and cucina vegana wild crops, coconuts and apples.

Bla commented

2022-04-09 08:13:26 +00:00

Good idea. We should make all growable stuff re-growable with an lbm. Not only bushes, youngtree-bushes and other flora, but also farming and cucina vegana wild crops, coconuts and apples.

Sure it would be nice if everything regrows but it would also cause more problems like #315

> Good idea. We should make all growable stuff re-growable with an lbm. Not only bushes, youngtree-bushes and other flora, but also farming and cucina vegana wild crops, coconuts and apples. Sure it would be nice if everything regrows but it would also cause more problems like #315

flux commented

2022-05-25 00:17:13 +00:00

@AliasAlreadyTaken youngtrees and other plantlife stuff are spawning on a featureless expanse of default:dirt that i was testing out vines behavior on my local server. did we implement this, or is part of the recent updates to plantlife_modpack? either way we should probably close this.

flux commented

2022-05-25 00:17:43 +00:00

Sure it would be nice if everything regrows but it would also cause more problems like #315

sure, but they're comparatively tiny, so even less of a problem.

EDIT: i'd love to stop trees from growing through buildings, but doing so is relatively computationally expensive, and also tricky. Perhaps, eventually, ABMs could be used to grow trees slowly over time. I've seen some mods that do that well in minecraft, but currently ABMs are too expensive to use.

> Sure it would be nice if everything regrows but it would also cause more problems like #315 sure, but they're comparatively tiny, so even less of a problem. EDIT: i'd love to stop trees from growing through buildings, but doing so is relatively computationally expensive, and also tricky. Perhaps, eventually, ABMs could be used to grow trees slowly over time. I've seen some mods that do that well in minecraft, but currently ABMs are too expensive to use.

AliasAlreadyTaken commented

2022-05-25 17:48:51 +00:00

Maybe we should tackle this problem when we do your-land/administration#134

With the new async env we could grab a voxelmaip of the growth area, compute whether and where the tree may grow and then add it all-in-one.

Or we could cut the tree-grwoing stuff into smaller pieces, growing each stage after another.

However, let's close this as maybe and fix in the regrow mechanic?

Maybe we should tackle this problem when we do https://gitea.your-land.de/your-land/administration/issues/134 With the new async env we could grab a voxelmaip of the growth area, compute whether and where the tree may grow and then add it all-in-one. Or we could cut the tree-grwoing stuff into smaller pieces, growing each stage after another. However, let's close this as maybe and fix in the regrow mechanic?

flux commented

2022-05-28 15:30:33 +00:00

I didn't realize that these things already respawned, so I'm closing this. A more general regrow mechanic as discussed in your-land/administration#134 is probably needed though.

I didn't realize that these things already respawned, so I'm closing this. A more general regrow mechanic as discussed in https://gitea.your-land.de/your-land/administration/issues/134 is probably needed though.

👍 1

flux closed this issue

2022-05-28 15:30:34 +00:00

flux added the

5. result/cannot reproduce

label 2022-05-28 15:30:57 +00:00

flux commented

2022-05-31 00:17:33 +00:00

Re-opening as I'm not sure whether they're actually being respawned, or whether the emerge queue generates them much later that i'd expect.

flux reopened this issue

2022-05-31 00:17:34 +00:00

flux added

4. step/question

and removed

5. result/cannot reproduce

labels 2022-05-31 00:17:49 +00:00

flux added this to the flux's TODO list project 2022-07-02 20:34:29 +00:00

flux removed the

4. step/question

label 2022-10-26 21:32:26 +00:00

flux referenced this issue

2022-11-22 17:36:56 +00:00

flux reports: bushes should be sturdier and ... #2198

flux added the

4. step/ready to QA test

4. step/partially fixed

labels 2022-11-22 17:37:14 +00:00

flux commented

2022-11-22 17:37:44 +00:00

youngtrees are now sturdier (ea80b6db4f) but there's still no mechanism for them to respawn.

youngtrees are now sturdier (https://gitea.your-land.de/your-land/yl_commons/commit/ea80b6db4f040dd64a7b3621eeadb513c24b5d7c) but there's still no mechanism for them to respawn.

AliasAlreadyTaken commented

2022-11-23 06:34:56 +00:00

May either need to wait for the regrow mechanic:

your-land/administration#134

Or added to a shrubbery cow:

#3046

May either need to wait for the regrow mechanic: https://gitea.your-land.de/your-land/administration/issues/134 Or added to a shrubbery cow: https://gitea.your-land.de/your-land/bugtracker/issues/3046

flux commented

2022-11-24 02:49:33 +00:00

Or added to a shrubbery cow:

see this comment: #3046 (comment)

i kinda like the idea of a cow that basically just automatically does terrain regeneration over time, but that's very complicated and probably shouldn't be something that players can tame and capture.

> Or added to a shrubbery cow: see this comment: https://gitea.your-land.de/your-land/bugtracker/issues/3046#issuecomment-33849 i kinda like the idea of a cow that basically just automatically does terrain regeneration over time, but that's ***very*** complicated and probably shouldn't be something that players can tame and capture.

flux referenced this issue

2022-12-07 19:49:25 +00:00

JeCel reports: Since youngtrees and bushes do ... #3205

AliasAlreadyTaken referenced this issue

2023-01-18 14:36:58 +00:00

flux reports: bushes should be sturdier and ... #2198

flux referenced this issue

2023-01-19 04:08:36 +00:00

flux reports: bushes should be sturdier and ... #2198

AliasAlreadyTaken added this to the 1.1.117 milestone 2023-01-21 00:29:01 +00:00

AliasAlreadyTaken commented

2023-01-21 00:30:09 +00:00

Let's count this as fixed and for the second part of the request, let's add it to the regrow mechanic.

your-land/administration#134

Let's count this as fixed and for the second part of the request, let's add it to the regrow mechanic. https://gitea.your-land.de/your-land/administration/issues/134

AliasAlreadyTaken added the

ugh/QA OK

label 2023-01-21 00:30:16 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test

labels 2023-01-25 02:20:24 +00:00

flux removed this from the flux's TODO list project 2023-01-25 02:20:26 +00:00

AliasAlreadyTaken was unassigned by flux

2023-01-25 02:20:28 +00:00

flux commented