Eris_still_crafts reports: The block signs:wooden_right_s ... #157

New Issue

yourland-report · 2021-01-08T01:17:46Z

yourland-report commented

2021-01-08 01:17:46 +00:00

Eris_still_crafts reports a bug:

The block signs:wooden_right_sign doesn't let a player walk through it, while signs:wooden_left_sign lets them.

Player position:

{
	y = 2.5,
	x = 1784.0640869141,
	z = 2498.2580566406
}

Player look:

{
	y = -0.32705295085907,
	x = 0.22301049530506,
	z = 0.91831511259079
}

Log identifier


[MOD] yl_report log identifier = Zm09mTRVNjHiMQeL8V6S4BktpLgRqFDe

Profiler save:

profile-20210108T021746.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=79638.6, max_lag=8.68266, clients={kwadroke, TyrellCorporation, AliasAlreadyTaken, Bailiff, InitialD, LeetPeet, Eris_still_crafts, darealbang}

Eris_still_crafts reports a bug: ``` The block signs:wooden_right_sign doesn't let a player walk through it, while signs:wooden_left_sign lets them. ``` Player position: ``` { y = 2.5, x = 1784.0640869141, z = 2498.2580566406 } ``` Player look: ``` { y = -0.32705295085907, x = 0.22301049530506, z = 0.91831511259079 } ``` Log identifier ``` [MOD] yl_report log identifier = Zm09mTRVNjHiMQeL8V6S4BktpLgRqFDe ``` Profiler save: ``` profile-20210108T021746.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=79638.6, max_lag=8.68266, clients={kwadroke, TyrellCorporation, AliasAlreadyTaken, Bailiff, InitialD, LeetPeet, Eris_still_crafts, darealbang} ```

AliasAlreadyTaken was assigned by yourland-report

2021-01-08 01:17:46 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2021-01-08 03:38:01 +00:00

AliasAlreadyTaken added the

3. source/mod upstream

label 2021-11-20 14:36:04 +00:00

AliasAlreadyTaken commented

2021-11-20 14:39:06 +00:00

https://github.com/pyrollo/display_modpack/issues/45

flux added the

2. prio/good first issue

label 2022-10-23 17:42:34 +00:00

AliasAlreadyTaken commented

2023-05-06 13:55:08 +00:00

A new modmaker @AtlanteIIV attempts a fix for this issue. This is the plan:

Fork the upstream mod
Find the place where to fix the issue in the fork
Create a PR to the upstream mod
Create a second mod. You can use https://gitea.your-land.de/your-land/yl_template as a basis. (throw out all things you don't want: everything but init.lua)
Find out which part of the modpack the faulty sign is from
Make your new mod depend on that mod in your new one
Research how to overwrite an item (https://github.com/minetest/minetest/blob/master/doc/lua_api.md), if you search for overwrite you should find it.
Overwrite the item and add the fix there
Publish and notify me

What happens after the bugfix: We will include it into our temporary bugfixes in yl_commons until upstream pulls your PR. To be compatible, your mod needs to have a MIT license

A new modmaker @AtlanteIIV attempts a fix for this issue. This is the plan: - Fork the upstream mod - Find the place where to fix the issue in the fork - Create a PR to the upstream mod - Create a second mod. You can use https://gitea.your-land.de/your-land/yl_template as a basis. (throw out all things you don't want: everything but init.lua) - Find out which part of the modpack the faulty sign is from - Make your new mod depend on that mod in your new one - Research how to overwrite an item (https://github.com/minetest/minetest/blob/master/doc/lua_api.md), if you search for overwrite you should find it. - Overwrite the item and add the fix there - Publish and notify me What happens after the bugfix: We will include it into our temporary bugfixes in yl_commons until upstream pulls your PR. To be compatible, your mod needs to have a MIT license

AtlanteIIV commented

2023-05-06 20:13:28 +00:00

Hey, good evening, here is the zip file that solves the problem, it uses minetest.override_item. As a result I was able to put the correct box for signs:wooden_right_sign.

minetest.override_item("signs:wooden_right_sign", {
    selection_box = { type="fixed", fixed = {-0.5, -7/32, 0.5, 7/16, 7/32, 7/16} },
    collision_box = { type = "fixed", fixed = { -7/16, -7/32, 0.5, 0.5, 7/32, 7/16 } },
})

Hey, good evening, here is the zip file that solves the problem, it uses minetest.override_item. As a result I was able to put the correct box for signs:wooden_right_sign. ``` minetest.override_item("signs:wooden_right_sign", { selection_box = { type="fixed", fixed = {-0.5, -7/32, 0.5, 7/16, 7/32, 7/16} }, collision_box = { type = "fixed", fixed = { -7/16, -7/32, 0.5, 0.5, 7/32, 7/16 } }, }) ```

signs_wooden_right_sign.zip

814 B

👍 1

AliasAlreadyTaken referenced this issue

2023-05-06 21:25:09 +00:00

1.1.119 #4181

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-07 21:09:56 +00:00

AliasAlreadyTaken commented

2023-05-08 00:25:46 +00:00

Fixed in 686ed89e8f

Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/686ed89e8f022f98716c0d067d2d654b7846e282

👍 1

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-05-08 00:25:52 +00:00

flux commented

2023-05-09 05:34:00 +00:00

Fixed in 686ed89e8f

doing this in integration seems like the right solution, +1 from me

> Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/686ed89e8f022f98716c0d067d2d654b7846e282 doing this in integration seems like the right solution, +1 from me

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-09 05:49:17 +00:00

flux commented

2023-05-18 18:03:53 +00:00

this seems live

flux closed this issue

2023-05-18 18:03:53 +00:00

flux added

5. result/fixed

and removed

4. step/ready to QA test