Segmentation_Fault reports: possible bug regarding "Past I ... #1562

New Issue

yourland-report · 2022-03-11T11:02:17Z

yourland-report commented

2022-03-11 11:02:17 +00:00

Segmentation_Fault reports a bug:

possible bug regarding "Past IP: ..." So recently I looked at the login screen that shows the "Past IP" and all that stuff for a new player named "printses", who also happens to be under the same network as "my-names-is-vaeria". However, when "my-names-is-vaeria" had logged out, and printses joined, it displayed "my-names-is-vaeria" under "Past IP" 9 times for some reason. If I'm not wrong, it should display the name of the account under "Past IP" only once instead of displaying it 9 times

Player position:

{
	y = 16.5,
	x = 1999.2529296875,
	z = 1194.873046875
}

Player look:

{
	y = -0.35347485542297,
	x = 0.21631050109863,
	z = -0.91009080410004
}

Player information:

{
	min_rtt = 0.17800000309944,
	max_rtt = 23.264999389648,
	connection_uptime = 8885,
	max_jitter = 22.239999771118,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.55099999904633,
	state = "Active",
	avg_jitter = 0.34999999403954,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 31593\", \"3d_armor:chestplate_crystal 1 31593\", \"3d_armor:helmet_crystal 1 31653\", \"\", \"\", \"\"}",
		["petz:werewolf_vignette_id"] = "10",
		["petz:werewolf"] = "0",
		jointime = "1626766817",
		yl_commons_player_joined = "1646987679",
		["signslib:pos"] = "(2481,3,-1727)",
		digged_nodes = "119369",
		died = "168",
		xp = "107914",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		played_time = "1694536",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 17, [\"x\"] = 1999, [\"z\"] = 1219}, [\"last_heal\"] = 1634989711, [\"last_death_portal\"] = 1646909298}",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["stamina:level"] = "12",
		punch_count = "7715",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "142088",
		crafted = "24067",
		["petz:werewolf_clan_idx"] = "3",
		yl_commons_thankyou = "46",
		partypvp = "true",
		placed_nodes = "72314",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1626766817"
	}
}

Log identifier


[MOD] yl_report log identifier = ygpbTWqyYg4Xz1pZCG5UjtN9FR8XsKpM

Profiler save:

profile-20220311T120214.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=879834, max_lag=2.72042, clients={evil123, Aero, my-names-is-vaeria, Segmentation_Fault, wishingirl, Bailiff, AliasAlreadyTaken, Service, flux, guestxmart}

Teleport command:

/teleport xyz 1999 17 1195

Compass command:

/give_compass Construction ygpbTWqyYg4Xz1pZCG5UjtN9FR8XsKpM D2691E 1999 17 1195

Segmentation_Fault reports a bug: > possible bug regarding "Past IP: ..." So recently I looked at the login screen that shows the "Past IP" and all that stuff for a new player named "printses", who also happens to be under the same network as "my-names-is-vaeria". However, when "my-names-is-vaeria" had logged out, and printses joined, it displayed "my-names-is-vaeria" under "Past IP" 9 times for some reason. If I'm not wrong, it should display the name of the account under "Past IP" only once instead of displaying it 9 times Player position: ``` { y = 16.5, x = 1999.2529296875, z = 1194.873046875 } ``` Player look: ``` { y = -0.35347485542297, x = 0.21631050109863, z = -0.91009080410004 } ``` Player information: ``` { min_rtt = 0.17800000309944, max_rtt = 23.264999389648, connection_uptime = 8885, max_jitter = 22.239999771118, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.55099999904633, state = "Active", avg_jitter = 0.34999999403954, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 31593\", \"3d_armor:chestplate_crystal 1 31593\", \"3d_armor:helmet_crystal 1 31653\", \"\", \"\", \"\"}", ["petz:werewolf_vignette_id"] = "10", ["petz:werewolf"] = "0", jointime = "1626766817", yl_commons_player_joined = "1646987679", ["signslib:pos"] = "(2481,3,-1727)", digged_nodes = "119369", died = "168", xp = "107914", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", played_time = "1694536", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 17, [\"x\"] = 1999, [\"z\"] = 1219}, [\"last_heal\"] = 1634989711, [\"last_death_portal\"] = 1646909298}", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["stamina:level"] = "12", punch_count = "7715", arenalib_infobox_arenaID = "0", inflicted_damage = "142088", crafted = "24067", ["petz:werewolf_clan_idx"] = "3", yl_commons_thankyou = "46", partypvp = "true", placed_nodes = "72314", hud_state = "on", repellant = "0", yl_commons_player_created = "1626766817" } } ``` Log identifier ``` [MOD] yl_report log identifier = ygpbTWqyYg4Xz1pZCG5UjtN9FR8XsKpM ``` Profiler save: ``` profile-20220311T120214.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=879834, max_lag=2.72042, clients={evil123, Aero, my-names-is-vaeria, Segmentation_Fault, wishingirl, Bailiff, AliasAlreadyTaken, Service, flux, guestxmart} ``` Teleport command: ``` /teleport xyz 1999 17 1195 ``` Compass command: ``` /give_compass Construction ygpbTWqyYg4Xz1pZCG5UjtN9FR8XsKpM D2691E 1999 17 1195 ```

AliasAlreadyTaken was assigned by yourland-report

2022-03-11 11:02:17 +00:00

AliasAlreadyTaken added the

1. kind/bug

label 2022-03-12 02:47:39 +00:00

AliasAlreadyTaken commented

2022-03-12 02:48:03 +00:00

I saw that, too. It happens for other players as well, but I didn't manage to reproduce it.

AliasAlreadyTaken added the

4. step/help wanted

label 2022-03-12 02:48:20 +00:00

flux commented

2022-03-13 01:14:22 +00:00

My guess is that they share multiple IPs? Or mnv connected from multiple IPs, but printses only connected from one?

flux commented

2022-03-13 01:22:11 +00:00

Once i've got the smartshop update tested out to my satisfaction, i'll work on fixing some of the rough edges of verbana. It might not be worth fixing this if it's going to be replaced.

AliasAlreadyTaken commented

2023-06-12 06:06:12 +00:00

The reason is that in string.find(text, s) the "-" seems to have a special meaning. We need to put string.find(text, s, 1, true) to tell lua we really want to find strings instead of doing voodoo.

Fixed in fe37d4ec61

The reason is that in `string.find(text, s)` the "-" seems to have a special meaning. We need to put `string.find(text, s, 1, true)` to tell lua we really want to find strings instead of doing voodoo. Fixed in https://gitea.your-land.de/your-land/yl_commons/commit/fe37d4ec613c2657cfdd5746ac27a74089f4c538

👍 1

AliasAlreadyTaken added this to the 1.1.120 milestone 2023-06-12 06:06:18 +00:00

AliasAlreadyTaken added

4. step/ready to QA test

and removed

4. step/help wanted

labels 2023-06-12 06:06:29 +00:00

AliasAlreadyTaken referenced this issue

2023-08-28 14:15:52 +00:00

1.1.120 #4520

AliasAlreadyTaken added the

ugh/QA OK