Arabella reports: need a chest that can only bec ... #1507
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#1507
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Arabella reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
@osmal players are already confused by the available chests so better not add another one.
shared objects already supports areas just missed checking more than area owners.
Improved areas support in PR your-land/shared!1 but needs testing.
@Bla the problem is they both have different usages, shared limitation has a good reason for it, so that you can use it in public areas and it will still act as locked (safe from stealing), in the other hand this one will serve in cases where u need to make it turn public/locked depending on the protection. that the main reason i didnt choose to just remove that line from shared chest and decided to add another one.
Also the chest initial purpose is for events, so could be accessible to staff only, i just added the craft recipe because i tought would be also useful for us players.
My PR doesnt change that as long as the area isn´t set to open.
The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open.
Not exactly what Arabella requested but yes.
But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area.
I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change.
Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one.
Especially with the bonus that doors/trapdoors also get improved and it adds support for factionareas.
there a difference between "shared" and "public" :D
if u leave your house door open, that doesnt mean anyone passing by could enter & consider it as an invitation xD
afaik that it, at least that what i understood when i asked her before doing it :D
not sure what u mean, since yeah it is also protected outside an area.
i dont have access to see your PR
As i said:
right and if you name your door "Protected" nobody will ever dare to enter even if its open neither try to open it because it´s unlocked.
well nobody reading this issue can know that
not while I tested it with all the other mods but will have another look.
edit: just tested again and opened an issue at your repo.
So without seeing my change you guessed that I just removed some line but still rejected my solution.
Can´t consider something that was added through edit at the same time as I posted my comment. But even "staff only" won´t change my opinion because that way it would be used even less.
the house door example was about IRL actually xD
i got confused, yeah it should be public outside protection
i didnt guess, i was pointing not about your PR but about what i attempted to do at first before figuring out that blue should stay the way it is :D
For reference, there's some related discussion in #1378
this is live