Arabella reports: need a chest that can only bec ... #1507

Closed
opened 2022-02-20 15:06:06 +00:00 by yourland-report · 9 comments

Arabella reports a bug:

need a chest that can only become public once the area has been open - for events thats a huge help

Player position:

{
	y = 10.5,
	x = 10434.217773438,
	z = -5335.7353515625
}

Player look:

{
	y = -0.033155180513859,
	x = 0.98883020877838,
	z = -0.14531204104424
}

Player information:

{
	min_rtt = 0.025000000372529,
	max_rtt = 1.0989999771118,
	connection_uptime = 18636,
	max_jitter = 1.039999961853,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-51cfb57",
	avg_rtt = 0.035999998450279,
	state = "Active",
	avg_jitter = 0.0069999992847443,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"shields:shield_admin\", \"\", \"\", \"\", \"\"}",
		["petz:werewolf_vignette_id"] = "19",
		["petz:werewolf"] = "0",
		jointime = "1624205010",
		yl_commons_player_joined = "1645350972",
		["signslib:pos"] = "(1971,19,1173)",
		digged_nodes = "56659",
		punch_count = "15836",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		played_time = "4338634",
		["petz:lycanthropy"] = "0",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -30080, [\"x\"] = 1978, [\"z\"] = 1534}, [\"last_heal\"] = 1627128051, [\"last_death_portal\"] = 1645184584}",
		placed_nodes = "99357",
		["stamina:level"] = "16",
		xp = "148195",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "1127284",
		crafted = "476",
		["petz:werewolf_clan_idx"] = "1",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		yl_commons_thankyou = "176",
		died = "28",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1624205010"
	}
}

Log identifier


[MOD] yl_report log identifier = Y9bC1lWzM86GOnWfZqAwGIxeM5ZOobml

Profiler save:

profile-20220220T160605.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=345711, max_lag=7.43202, clients={Shreyas, afflatus, Or, LeetPeet, Sandra, Giuseppe, Antonia, tntBOMBER, Imhotheb, Superangers, darealbang, Nibsokube, debian44, Artruc, Feuk80, Boot, bizon, Arabella, tour, guestxmart, Kain, Bishiro, rheo, Bailiff, AliasAlreadyTaken, Service, flux}

Teleport command:

/teleport xyz 10434 11 -5336

Compass command:

/give_compass Construction Y9bC1lWzM86GOnWfZqAwGIxeM5ZOobml D2691E 10434 11 -5336
Arabella reports a bug: > need a chest that can only become public once the area has been open - for events thats a huge help Player position: ``` { y = 10.5, x = 10434.217773438, z = -5335.7353515625 } ``` Player look: ``` { y = -0.033155180513859, x = 0.98883020877838, z = -0.14531204104424 } ``` Player information: ``` { min_rtt = 0.025000000372529, max_rtt = 1.0989999771118, connection_uptime = 18636, max_jitter = 1.039999961853, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-51cfb57", avg_rtt = 0.035999998450279, state = "Active", avg_jitter = 0.0069999992847443, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal\", \"shields:shield_admin\", \"\", \"\", \"\", \"\"}", ["petz:werewolf_vignette_id"] = "19", ["petz:werewolf"] = "0", jointime = "1624205010", yl_commons_player_joined = "1645350972", ["signslib:pos"] = "(1971,19,1173)", digged_nodes = "56659", punch_count = "15836", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", played_time = "4338634", ["petz:lycanthropy"] = "0", yl_church = "return {[\"last_death\"] = {[\"y\"] = -30080, [\"x\"] = 1978, [\"z\"] = 1534}, [\"last_heal\"] = 1627128051, [\"last_death_portal\"] = 1645184584}", placed_nodes = "99357", ["stamina:level"] = "16", xp = "148195", arenalib_infobox_arenaID = "0", inflicted_damage = "1127284", crafted = "476", ["petz:werewolf_clan_idx"] = "1", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", yl_commons_thankyou = "176", died = "28", hud_state = "on", repellant = "0", yl_commons_player_created = "1624205010" } } ``` Log identifier ``` [MOD] yl_report log identifier = Y9bC1lWzM86GOnWfZqAwGIxeM5ZOobml ``` Profiler save: ``` profile-20220220T160605.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=345711, max_lag=7.43202, clients={Shreyas, afflatus, Or, LeetPeet, Sandra, Giuseppe, Antonia, tntBOMBER, Imhotheb, Superangers, darealbang, Nibsokube, debian44, Artruc, Feuk80, Boot, bizon, Arabella, tour, guestxmart, Kain, Bishiro, rheo, Bailiff, AliasAlreadyTaken, Service, flux} ``` Teleport command: ``` /teleport xyz 10434 11 -5336 ``` Compass command: ``` /give_compass Construction Y9bC1lWzM86GOnWfZqAwGIxeM5ZOobml D2691E 10434 11 -5336 ```
AliasAlreadyTaken was assigned by yourland-report 2022-02-20 15:06:06 +00:00
AliasAlreadyTaken added the
1. kind/enhancement
label 2022-02-20 21:37:31 +00:00
- [x] [Requested Chest](https://gitea.your-land.de/osmal/yl_tools) Done :D

@osmal players are already confused by the available chests so better not add another one.

shared objects already supports areas just missed checking more than area owners.
Improved areas support in PR your-land/shared!1 but needs testing.

@osmal players are already confused by the available chests so better not add another one. [shared](https://gitea.your-land.de/your-land/shared) objects already supports [areas](https://gitea.your-land.de/your-land/areas) just missed checking more than area owners. Improved areas support in PR your-land/shared!1 but needs testing.

@Bla the problem is they both have different usages, shared limitation has a good reason for it, so that you can use it in public areas and it will still act as locked (safe from stealing), in the other hand this one will serve in cases where u need to make it turn public/locked depending on the protection. that the main reason i didnt choose to just remove that line from shared chest and decided to add another one.
Also the chest initial purpose is for events, so could be accessible to staff only, i just added the craft recipe because i tought would be also useful for us players.

@Bla the problem is they both have different usages, shared limitation has a good reason for it, so that you can use it in public areas and it will still act as locked (safe from stealing), in the other hand this one will serve in cases where u need to make it turn public/locked depending on the protection. that the main reason i didnt choose to just remove that line from shared chest and decided to add another one. Also the chest initial purpose is for events, so could be accessible to staff only, i just added the craft recipe because i tought would be also useful for us players.

@Bla the problem is they both have different usages,
shared limitation has a good reason for it, so that you can use it in public areas and it will still act as locked (safe from stealing),

My PR doesnt change that as long as the area isn´t set to open.
The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open.

in the other hand this one will serve in cases where u need to make it turn public/locked depending on the protection.

Not exactly what Arabella requested but yes.
But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area.

that the main reason i didnt choose to just remove that line from shared chest and decided to add another one.

I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change.

Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one.
Especially with the bonus that doors/trapdoors also get improved and it adds support for factionareas.

> @Bla the problem is they both have different usages, shared limitation has a good reason for it, so that you can use it in public areas and it will still act as locked (safe from stealing), My PR doesnt change that as long as the area isn´t set to open. The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open. >in the other hand this one will serve in cases where u need to make it turn public/locked depending on the protection. Not exactly what Arabella requested but yes. But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area. >that the main reason i didnt choose to just remove that line from shared chest and decided to add another one. I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change. Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one. Especially with the bonus that doors/trapdoors also get improved and it adds support for factionareas.

The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open.

there a difference between "shared" and "public" :D
if u leave your house door open, that doesnt mean anyone passing by could enter & consider it as an invitation xD

Not exactly what Arabella requested but yes.

afaik that it, at least that what i understood when i asked her before doing it :D

But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area.

not sure what u mean, since yeah it is also protected outside an area.

I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change.

i dont have access to see your PR

Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one.

As i said:

.. could be accessible to staff only ..

> The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open. there a difference between "shared" and "public" :D if u leave your house door open, that doesnt mean anyone passing by could enter & consider it as an invitation xD > Not exactly what Arabella requested but yes. afaik that it, at least that what i understood when i asked her before doing it :D > But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area. not sure what u mean, since yeah it is also protected outside an area. > I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change. i dont have access to see your PR > Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one. As i said: > .. could be accessible to staff only ..

The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open.

there a difference between "shared" and "public" :D
if u leave your house door open, that doesnt mean anyone passing by could enter & consider it as an invitation xD

right and if you name your door "Protected" nobody will ever dare to enter even if its open neither try to open it because it´s unlocked.

Not exactly what Arabella requested but yes.

afaik that it, at least that what i understood when i asked her before doing it :D

well nobody reading this issue can know that

But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area.

not sure what u mean, since yeah it is also protected outside an area.

not while I tested it with all the other mods but will have another look.
edit: just tested again and opened an issue at your repo.

I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change.

i dont have access to see your PR

So without seeing my change you guessed that I just removed some line but still rejected my solution.

Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one.

As i said:

.. could be accessible to staff only ..

Can´t consider something that was added through edit at the same time as I posted my comment. But even "staff only" won´t change my opinion because that way it would be used even less.

> > The shared chest works based on the area and players know that, I also don´t really expect complaints that a chest named "shared" is accesible to everyone after you set an area to open. > > there a difference between "shared" and "public" :D > if u leave your house door open, that doesnt mean anyone passing by could enter & consider it as an invitation xD right and if you name your door "Protected" nobody will ever dare to enter even if its open neither try to open it because it´s unlocked. > > Not exactly what Arabella requested but yes. > > afaik that it, at least that what i understood when i asked her before doing it :D > well nobody reading this issue can know that > > But players will also expect that a "Protected Chest" is also protected outside an area, inside an area you share with other players and in an open area. > > not sure what u mean, since yeah it is also protected outside an area. not while I tested it with all the other mods but will have another look. edit: just tested again and opened an issue at your repo. > > I hope you also noticed the change in Line 14 and not just the deleted unnecessary code because of that change. > > i dont have access to see your PR So without seeing my change you guessed that I just removed some line but still rejected my solution. > > Overall I´m against adding a fifth mod for sharing/protecting chests if the requested feature just needs a small change to an already existing one. > > As i said: > > > .. could be accessible to staff only .. > Can´t consider something that was added through edit at the same time as I posted my comment. But even "staff only" won´t change my opinion because that way it would be used even less.

right and if you name your door "Protected" nobody will ever dare to enter even if its open neither try to open it because it´s unlocked.

the house door example was about IRL actually xD

not while I tested it with all the other mods but will have another look.

i got confused, yeah it should be public outside protection

i dont have access to see your PR

So without seeing my change you guessed that I just removed some line but still rejected my solution.

i didnt guess, i was pointing not about your PR but about what i attempted to do at first before figuring out that blue should stay the way it is :D

> right and if you name your door "Protected" nobody will ever dare to enter even if its open neither try to open it because it´s unlocked. the house door example was about IRL actually xD > not while I tested it with all the other mods but will have another look. i got confused, yeah it should be public outside protection > > i dont have access to see your PR > > So without seeing my change you guessed that I just removed some line but still rejected my solution. i didnt guess, i was pointing not about your PR but about what i attempted to do at first before figuring out that blue should stay the way it is :D
Member

For reference, there's some related discussion in #1378

For reference, there's some related discussion in #1378
flux added this to the flux's TODO list project 2022-07-02 19:50:39 +00:00
Member

this is live

this is live
flux closed this issue 2022-09-15 14:18:53 +00:00
flux removed this from the flux's TODO list project 2022-09-15 14:18:58 +00:00
AliasAlreadyTaken was unassigned by flux 2022-09-15 14:19:00 +00:00
flux added the
5. result/fixed
label 2022-09-15 14:19:12 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1507
No description provided.