Arabella reports: Tested: admin pick can kill a ... #1499
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#1499
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Arabella reports a bug:
Player position:
Player look:
Player information:
Player meta:
Log identifier
Profiler save:
Status:
Teleport command:
Compass command:
That's worrying, there's nothing special about the admin pick other than it deals a huge amount of damage...
This is pvpplus register_on_punchplayer https://gitea.your-land.de/your-land/pvpplus/src/branch/yl_stable/pvp.lua#L128
This is petz register_on_punchplayer https://gitea.your-land.de/your-land/petz/src/branch/yl_stable/petz/misc/lycanthropy.lua#L258
At least on my testsystem, the pvpplus mod gets loaded first, then petz. How do I tell petz to respect the pvpplus on_punch?
Until we can make a real fix, I disabled the on_punchplayer of petz.
f2c61a4911
Hm.
If the pvpplus callback is called first, it should return
true
, which should keep the petz callback from executing.If the petz callback is first, the player is damaged before pvpplus is checked.
I suppose one way to force this is to have petz depend on pvpplus? Which seems a bit wrong.
Another maybe-possible option is to have petz have a
minetest.register_on_player_hpchange
instead ofminetest.register_on_punchplayer
callback. You'd have to checkreason
and see whether the source was a player, to replicate the current behavior, and I'm not sure how reliable that is.Readded in
93fa91002f
reviewing the petz code, it's still broken. i'll work on a PR to switch that behavior to use
register_on_player_hpchange
insteadupstream PR https://github.com/runsy/petz/pull/179
I have a feeling runsy doesn't even review your PRs anymore and simply merges them without a second of hesitation :D
QA
Looks good. Only when both have their pvp enabled, adminpick can kill a werewolf now
this is live