evil123 reports: *Suggestion* I suggest making ... #1477

New Issue

yourland-report · 2022-02-12T14:33:29Z

yourland-report commented

2022-02-12 14:33:29 +00:00

evil123 reports a bug:

Suggestion I suggest making wool into string. Wool is basically just a huge clump of cotton, so it would make sense to make it into string. I suggest that 1 wool = 4 string since a piece of wool = 4 cotton

Player position:

{
	y = 14.5,
	x = 2001.8430175781,
	z = 1153.5550537109
}

Player look:

{
	y = -0.48022350668907,
	x = -0.76724350452423,
	z = 0.42511513829231
}

Player information:

{
	min_rtt = 0.24899999797344,
	max_rtt = 9.3439998626709,
	connection_uptime = 6381,
	max_jitter = 9.0859994888306,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.28099998831749,
	state = "Active",
	avg_jitter = 0.071000009775162,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:chestplate_rainbow 1 1778\", \"3d_armor:helmet_rainbow 1 1778\", \"3d_armor:leggings_rainbow 1 1778\", \"shields:shield_rainbow 1 1778\", \"3d_armor:boots_crystal 1 7320\", \"\"}",
		yl_commons_thankyou = "28",
		jointime = "1612610117",
		yl_commons_player_joined = "1644670063",
		["signslib:pos"] = "(-1086,40,-3105)",
		digged_nodes = "376504",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 16, [\"x\"] = -1267, [\"z\"] = -493}, [\"last_death_portal\"] = 1644628969}",
		["stamina:level"] = "18.725",
		xp = "249826",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "118356",
		crafted = "324186",
		played_time = "2063497",
		punch_count = "8266",
		placed_nodes = "52468",
		died = "217",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1612610117"
	}
}

Log identifier


[MOD] yl_report log identifier = J9H4ZMq2jRjK3oKK0xPPTm0bcVHBl3iy

Profiler save:

profile-20220212T153328.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=22396.9, max_lag=3.10067, clients={upie, Oversword, debian44, LeetPeet, Lupercus, Papi, ingram, evil123, Ravise, bizon, Bailiff, jakob, Noofky, AliasAlreadyTaken, Service}

Teleport command:

/teleport xyz 2002 15 1154

Compass command:

/give_compass Construction J9H4ZMq2jRjK3oKK0xPPTm0bcVHBl3iy D2691E 2002 15 1154

evil123 reports a bug: > *Suggestion* I suggest making wool into string. Wool is basically just a huge clump of cotton, so it would make sense to make it into string. I suggest that 1 wool = 4 string since a piece of wool = 4 cotton Player position: ``` { y = 14.5, x = 2001.8430175781, z = 1153.5550537109 } ``` Player look: ``` { y = -0.48022350668907, x = -0.76724350452423, z = 0.42511513829231 } ``` Player information: ``` { min_rtt = 0.24899999797344, max_rtt = 9.3439998626709, connection_uptime = 6381, max_jitter = 9.0859994888306, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.28099998831749, state = "Active", avg_jitter = 0.071000009775162, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:chestplate_rainbow 1 1778\", \"3d_armor:helmet_rainbow 1 1778\", \"3d_armor:leggings_rainbow 1 1778\", \"shields:shield_rainbow 1 1778\", \"3d_armor:boots_crystal 1 7320\", \"\"}", yl_commons_thankyou = "28", jointime = "1612610117", yl_commons_player_joined = "1644670063", ["signslib:pos"] = "(-1086,40,-3105)", digged_nodes = "376504", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_church = "return {[\"last_death\"] = {[\"y\"] = 16, [\"x\"] = -1267, [\"z\"] = -493}, [\"last_death_portal\"] = 1644628969}", ["stamina:level"] = "18.725", xp = "249826", arenalib_infobox_arenaID = "0", inflicted_damage = "118356", crafted = "324186", played_time = "2063497", punch_count = "8266", placed_nodes = "52468", died = "217", hud_state = "on", repellant = "0", yl_commons_player_created = "1612610117" } } ``` Log identifier ``` [MOD] yl_report log identifier = J9H4ZMq2jRjK3oKK0xPPTm0bcVHBl3iy ``` Profiler save: ``` profile-20220212T153328.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=22396.9, max_lag=3.10067, clients={upie, Oversword, debian44, LeetPeet, Lupercus, Papi, ingram, evil123, Ravise, bizon, Bailiff, jakob, Noofky, AliasAlreadyTaken, Service} ``` Teleport command: ``` /teleport xyz 2002 15 1154 ``` Compass command: ``` /give_compass Construction J9H4ZMq2jRjK3oKK0xPPTm0bcVHBl3iy D2691E 2002 15 1154 ```

👍 1

AliasAlreadyTaken was assigned by yourland-report

2022-02-12 14:33:29 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2022-02-17 10:28:23 +00:00

flux added this to the flux's TODO list project 2022-07-02 19:41:07 +00:00

flux added the

4. step/want approval

label 2022-07-02 19:41:23 +00:00

flux added the

1. kind/balancing

label 2022-10-25 22:03:29 +00:00

flux added the

2. prio/good first issue

label 2022-10-25 22:19:23 +00:00

AtlanteIIV commented

2023-05-07 08:30:07 +00:00

Hello, here is the addition of the recipe for wool:white 1 = farming:string 4.
depends = farming

minetest.register_craft({
	output = "wool:white",
	recipe = {
		{"farming:string", "farming:string"},
		{"farming:string", "farming:string"},
	}
})

Hello, here is the addition of the recipe for wool:white 1 = farming:string 4. depends = farming ``` minetest.register_craft({ output = "wool:white", recipe = { {"farming:string", "farming:string"}, {"farming:string", "farming:string"}, } }) ```

wool_recipe.zip

628 B

AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-07 22:50:51 +00:00

AliasAlreadyTaken commented

2023-05-07 22:50:56 +00:00

I changed the recipe a bit, any wool will now require a stick and return 3 strings. The stick doesn't get used up.

👍 1

AliasAlreadyTaken added the

4. step/ready to QA test

label 2023-05-07 22:51:04 +00:00

AliasAlreadyTaken commented

2023-05-07 23:05:29 +00:00

Added in 55911dd830

Added in https://gitea.your-land.de/your-land/yl_commons/commit/55911dd8303e31eec7b190956595b764d20d8a8b

AliasAlreadyTaken commented

2023-05-09 12:49:22 +00:00

QA:

Since I implemented it, could anyone look at the code or test and greenlight by 👍 ?

QA: Since I implemented it, could anyone look at the code or test and greenlight by 👍 ?

AliasAlreadyTaken added the

ugh/QA OK

label 2023-05-09 12:49:27 +00:00

flux commented

2023-05-10 04:18:31 +00:00

QA:

Since I implemented it, could anyone look at the code or test and greenlight by 👍 ?

looks good to me. one possible very minor improvement would be to make use of craftsystem and group:stick instead of default:stick, but it seems there's not currently anything else in group:stick? and we'd have to register the replacement w/ craftsystem as well

> QA: > > Since I implemented it, could anyone look at the code or test and greenlight by 👍 ? > looks good to me. one possible very minor improvement would be to make use of craftsystem and `group:stick` instead of `default:stick`, but it seems there's not currently anything else in `group:stick`? and we'd have to register the replacement w/ craftsystem as well

AliasAlreadyTaken commented

2023-05-10 04:27:30 +00:00

I tried to find how craftsystem works with replacements, but didn't. Can you point me to a place where I can see how that works? Documentation or an example?