Xonon reports: replace the creative mode shor ... #1425

New Issue

yourland-report · 2022-01-28T23:45:30Z

yourland-report commented

2022-01-28 23:45:30 +00:00

Xonon reports a bug:

replace the creative mode shortcuts in the main inventory screen with direct links to bag inventory screens

Player position:

{
	y = -345.49899291992,
	x = 4121.1987304688,
	z = 2336.6811523438
}

Player look:

{
	y = -0.22648131847382,
	x = 0.27810126543045,
	z = -0.93346983194351
}

Player information:

{
	min_rtt = 0.15500000119209,
	max_rtt = 11.321000099182,
	connection_uptime = 604,
	max_jitter = 11.161999702454,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-40bee27",
	avg_rtt = 0.19099999964237,
	state = "Active",
	avg_jitter = 0.089999988675117,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 140\", \"3d_armor:chestplate_crystal 1 160\", \"shields:shield_crystal 1 200\", \"3d_armor:boots_crystal 1 11440\", \"3d_armor:leggings_crystal 1 60\", \"\"}",
		["petz:werewolf_vignette_id"] = "10",
		["petz:werewolf"] = "0",
		jointime = "1621665541",
		yl_commons_player_joined = "1643412991",
		["signslib:pos"] = "(879,9,2035)",
		digged_nodes = "388554",
		placed_nodes = "196572",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		yl_commons_thankyou = "46",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 45, [\"x\"] = 2256, [\"z\"] = 2225}, [\"last_death_portal\"] = 1643276894}",
		played_time = "3086177",
		["stamina:level"] = "5",
		punch_count = "20474",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "268186",
		crafted = "22663",
		["petz:werewolf_clan_idx"] = "2",
		xp = "431045",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		died = "47",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621665541"
	}
}

Log identifier


[MOD] yl_report log identifier = 2SZhp1anKQcfJXPZdIQS7kbPugaoRjsb

Profiler save:

profile-20220129T004530.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=15162.8, max_lag=4.0088, clients={DangerousDan, shanish, Rex_2000, Xonon, digdeep, Sparkles, LeetPeet, afflatus, flux, Sandra, Futureismine, jj2, Bailiff, PinkPanther, AliasAlreadyTaken, Sokomine, Service, Ernesto, AwesomeAdam54321, Bla}

Teleport command:

/teleport xyz 4121 -345 2337

Compass command:

/give_compass Construction 2SZhp1anKQcfJXPZdIQS7kbPugaoRjsb D2691E 4121 -345 2337

Xonon reports a bug: > replace the creative mode shortcuts in the main inventory screen with direct links to bag inventory screens Player position: ``` { y = -345.49899291992, x = 4121.1987304688, z = 2336.6811523438 } ``` Player look: ``` { y = -0.22648131847382, x = 0.27810126543045, z = -0.93346983194351 } ``` Player information: ``` { min_rtt = 0.15500000119209, max_rtt = 11.321000099182, connection_uptime = 604, max_jitter = 11.161999702454, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-40bee27", avg_rtt = 0.19099999964237, state = "Active", avg_jitter = 0.089999988675117, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 140\", \"3d_armor:chestplate_crystal 1 160\", \"shields:shield_crystal 1 200\", \"3d_armor:boots_crystal 1 11440\", \"3d_armor:leggings_crystal 1 60\", \"\"}", ["petz:werewolf_vignette_id"] = "10", ["petz:werewolf"] = "0", jointime = "1621665541", yl_commons_player_joined = "1643412991", ["signslib:pos"] = "(879,9,2035)", digged_nodes = "388554", placed_nodes = "196572", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", yl_commons_thankyou = "46", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 45, [\"x\"] = 2256, [\"z\"] = 2225}, [\"last_death_portal\"] = 1643276894}", played_time = "3086177", ["stamina:level"] = "5", punch_count = "20474", arenalib_infobox_arenaID = "0", inflicted_damage = "268186", crafted = "22663", ["petz:werewolf_clan_idx"] = "2", xp = "431045", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", died = "47", hud_state = "on", repellant = "0", yl_commons_player_created = "1621665541" } } ``` Log identifier ``` [MOD] yl_report log identifier = 2SZhp1anKQcfJXPZdIQS7kbPugaoRjsb ``` Profiler save: ``` profile-20220129T004530.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=15162.8, max_lag=4.0088, clients={DangerousDan, shanish, Rex_2000, Xonon, digdeep, Sparkles, LeetPeet, afflatus, flux, Sandra, Futureismine, jj2, Bailiff, PinkPanther, AliasAlreadyTaken, Sokomine, Service, Ernesto, AwesomeAdam54321, Bla} ``` Teleport command: ``` /teleport xyz 4121 -345 2337 ``` Compass command: ``` /give_compass Construction 2SZhp1anKQcfJXPZdIQS7kbPugaoRjsb D2691E 4121 -345 2337 ```

AliasAlreadyTaken was assigned by yourland-report

2022-01-28 23:45:30 +00:00

flux commented

2022-01-30 02:06:23 +00:00

it's been a longstanding gripe of mine, that creative-only tabs take up valuable screen real estate in unified_inventory.

flux added this to the (deleted) project 2022-01-30 03:24:25 +00:00

AliasAlreadyTaken was unassigned by flux

2022-01-30 03:24:33 +00:00

flux self-assigned this 2022-01-30 03:24:33 +00:00

flux added the

1. kind/enhancement

label 2022-01-30 03:24:44 +00:00

flux commented

2022-04-17 19:43:41 +00:00

well, the creative mode shortcuts were removed, though direct links to bags are not present

AliasAlreadyTaken commented

2022-04-19 00:30:50 +00:00

How would a direct link to bags look like? One that targets each separate bag?

Or would we only have to redirect the bag button to bag1?

How would players then add new bags?

How would a direct link to bags look like? One that targets each separate bag? Or would we only have to redirect the bag button to bag1? How would players then add new bags?

flux commented

2022-04-19 19:25:00 +00:00

How would a direct link to bags look like? One that targets each separate bag?

Or would we only have to redirect the bag button to bag1?

How would players then add new bags?

these are all very good questions.

> How would a direct link to bags look like? One that targets each separate bag? > > Or would we only have to redirect the bag button to bag1? > > How would players then add new bags? these are all very good questions.

flux commented

2022-06-25 23:02:57 +00:00

put the bag slots on the left side of the grid, below the word "crafting".
submit a PR to unified_inventory to hide disabled buttons instead of making the grey.

1. put the bag slots on the left side of the grid, below the word "crafting". 2. submit a PR to unified_inventory to *hide* disabled buttons instead of making the grey.

👍 1

flux modified the project from (deleted) to flux's TODO list

2022-07-02 19:35:57 +00:00

flux commented

2022-10-25 20:38:00 +00:00

this will be partially resolved when the fix for #2743 goes live, but there's still a couple good ideas here.

flux added the

4. step/partially fixed

label 2022-10-25 20:38:10 +00:00

flux commented

2022-10-25 20:53:05 +00:00

created a PR to hide the useless buttons:

https://github.com/minetest-mods/unified_inventory/pull/217

created a PR to hide the useless buttons: https://github.com/minetest-mods/unified_inventory/pull/217

👍 1

flux added the

4. step/ready to QA test

label 2022-10-26 16:07:15 +00:00

flux commented

2022-10-26 16:08:44 +00:00

PR to hide useless buttons got merged. leaving this open pending what Xonon (or others) think is still needed when UI remembers what you were looking at last.

AliasAlreadyTaken added this to the 1.1.116 milestone 2022-10-26 19:36:47 +00:00

flux removed the

4. step/ready to QA test

label 2022-11-13 17:06:00 +00:00

flux commented

2022-11-13 17:06:37 +00:00

inventory now remembers what you were looking at.