your-land/bugtracker
your-land/bugtracker
40
22
Issues 3.5k Projects 4 Wiki

flux reports: sealed envelopes can only be o ... #1379

New Issue
Open
opened 2022-01-22 17:22:27 +01:00 by yourland-report · 13 comments
yourland-report commented 2022-01-22 17:22:27 +01:00
Member
Copy Link

flux reports a bug:

sealed envelopes can only be opened by the adressee, but that seems to be case sensitive...

Player position:

{
	y = 21.5,
	x = 2190.1960449219,
	z = 1166.4150390625
}

Player look:

{
	y = -0.33380687236786,
	x = -0.89340579509735,
	z = -0.30066433548927
}

Player information:

{
	min_rtt = 0.15000000596046,
	max_rtt = 4.9869999885559,
	connection_uptime = 161652,
	max_jitter = 3.827999830246,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.0",
	avg_rtt = 0.18999999761581,
	state = "Active",
	avg_jitter = 0.15700000524521,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 620\", \"3d_armor:chestplate_nether 1 1240\", \"3d_armor:leggings_nether 1 1240\", \"3d_armor:helmet_nether 1 620\", \"shields:shield_rainbow 1 248\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		yl_commons_thankyou = "61",
		jointime = "1615351173",
		yl_commons_player_joined = "1642706917",
		["signslib:pos"] = "(2269,39,2142)",
		digged_nodes = "819413",
		died = "57",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}",
		partychat = "party",
		punch_count = "28555",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 29822, [\"x\"] = 1949, [\"z\"] = 1608}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1642133272}",
		played_time = "8179783",
		["stamina:level"] = "17.925",
		xp = "915983",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "473460",
		crafted = "27460",
		["petz:werewolf_clan_idx"] = "1",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		["petz:werewolf"] = "1",
		placed_nodes = "299147",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1615351173"
	}
}

Log identifier


[MOD] yl_report log identifier = EOewTTph6MbnmHCi82ewBcI0EloNQZHE

Profiler save:

profile-20220122T172227.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=161794, max_lag=5.67406, clients={rujal, Trice, beastboy4, LeniOwO, Oakenshield, alexandre2005, Mr_Bud_Gaming, hermoine, Arabella, manitari, Bla, YorokobySuTsu, darealbang, Kain, tour, Boot, quim, DRAGONNether, AliasAlreadyTaken, Service, Or, ccady, beelover, flux, shanish, Bailiff, Eilzabella}

Teleport command:

/teleport xyz 2190 22 1166

Compass command:

/give_compass Construction EOewTTph6MbnmHCi82ewBcI0EloNQZHE D2691E 2190 22 1166
flux reports a bug: > sealed envelopes can only be opened by the adressee, but that seems to be case sensitive... Player position: ``` { y = 21.5, x = 2190.1960449219, z = 1166.4150390625 } ``` Player look: ``` { y = -0.33380687236786, x = -0.89340579509735, z = -0.30066433548927 } ``` Player information: ``` { min_rtt = 0.15000000596046, max_rtt = 4.9869999885559, connection_uptime = 161652, max_jitter = 3.827999830246, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.0", avg_rtt = 0.18999999761581, state = "Active", avg_jitter = 0.15700000524521, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 620\", \"3d_armor:chestplate_nether 1 1240\", \"3d_armor:leggings_nether 1 1240\", \"3d_armor:helmet_nether 1 620\", \"shields:shield_rainbow 1 248\", \"\"}", ["petz:werewolf_vignette_id"] = "20", yl_commons_thankyou = "61", jointime = "1615351173", yl_commons_player_joined = "1642706917", ["signslib:pos"] = "(2269,39,2142)", digged_nodes = "819413", died = "57", bitten = "0", ["unified_inventory:bags"] = "return {\"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\", \"water_life:croc_bag\"}", partychat = "party", punch_count = "28555", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 29822, [\"x\"] = 1949, [\"z\"] = 1608}, [\"last_heal\"] = 1615504208, [\"last_death_portal\"] = 1642133272}", played_time = "8179783", ["stamina:level"] = "17.925", xp = "915983", arenalib_infobox_arenaID = "0", inflicted_damage = "473460", crafted = "27460", ["petz:werewolf_clan_idx"] = "1", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", ["petz:werewolf"] = "1", placed_nodes = "299147", hud_state = "on", repellant = "0", yl_commons_player_created = "1615351173" } } ``` Log identifier ``` [MOD] yl_report log identifier = EOewTTph6MbnmHCi82ewBcI0EloNQZHE ``` Profiler save: ``` profile-20220122T172227.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=161794, max_lag=5.67406, clients={rujal, Trice, beastboy4, LeniOwO, Oakenshield, alexandre2005, Mr_Bud_Gaming, hermoine, Arabella, manitari, Bla, YorokobySuTsu, darealbang, Kain, tour, Boot, quim, DRAGONNether, AliasAlreadyTaken, Service, Or, ccady, beelover, flux, shanish, Bailiff, Eilzabella} ``` Teleport command: ``` /teleport xyz 2190 22 1166 ``` Compass command: ``` /give_compass Construction EOewTTph6MbnmHCi82ewBcI0EloNQZHE D2691E 2190 22 1166 ```
AliasAlreadyTaken was assigned by yourland-report 2022-01-22 17:22:27 +01:00
AliasAlreadyTaken added the
1. kind/bug
 label 2022-01-23 05:05:18 +01:00
AliasAlreadyTaken commented 2022-01-23 05:21:27 +01:00
Owner
Copy Link

Since it is not possible to create an account called FlUx or aLIASaLREADYtAKEN, if the accounts flux or AliasAlreadyTaken are present, we should make it that both the ingame mail and the sealed envelopes and any other case sensitive mechanic works case insensitive.

Either we make it that when an email is sent or an envelope is sealed, we search for the correct capitalization and fix it there or we ignore capitalization when it comes to receiving mail. Or both.

ingame mail may be better off to fix it during sending, because its JSON file uses the name as a primary key.

Since it is not possible to create an account called FlUx or aLIASaLREADYtAKEN, if the accounts flux or AliasAlreadyTaken are present, we should make it that both the ingame mail and the sealed envelopes and any other case sensitive mechanic works case insensitive. Either we make it that when an email is sent or an envelope is sealed, we search for the correct capitalization and fix it there or we ignore capitalization when it comes to receiving mail. Or both. ingame mail may be better off to fix it during sending, because its JSON file uses the name as a primary key.
flux added the
4. step/want approval
 label 2022-04-07 21:27:37 +02:00
flux added this to the flux's TODO list project 2022-07-02 21:32:34 +02:00
flux removed the
4. step/want approval
 label 2022-07-03 02:44:55 +02:00
flux commented 2022-10-24 20:18:27 +02:00
Member
Copy Link

sealed envelopes should make use of canonical_name

sealed envelopes should make use of [canonical_name](https://github.com/fluxionary/minetest-canonical_name)
flux added the
2. prio/interesting
 label 2022-10-24 20:18:38 +02:00
flux added the
4. step/ready to QA test
 label 2022-10-25 21:00:55 +02:00
flux self-assigned this 2022-10-25 21:01:03 +02:00
flux added the
3. source/mod upstream
 label 2022-10-25 21:01:10 +02:00
flux commented 2022-10-25 21:01:21 +02:00
Member
Copy Link

upstream PR: https://github.com/archfan7411/minetest-envelopes/pull/3

upstream PR: https://github.com/archfan7411/minetest-envelopes/pull/3
flux added
4. step/blocked
 and removed
4. step/ready to QA test
 labels 2022-10-26 01:50:36 +02:00
whosit commented 2024-01-31 22:46:15 +01:00
Member
Copy Link

Someone sent me a mail addressed "to You" - can't even create that acc because of space. Pretty funny... 🥹

Someone sent me a mail addressed "to You" - can't even create that acc because of space. Pretty funny... 🥹
AliasAlreadyTaken commented 2024-02-01 06:39:55 +01:00
Owner
Copy Link

flux' PR is open for TWO YEARS now?

Let's adopt and release the fork. This is certainly something that bugs not only us. The name of the maintainer, archfan, does ring a bell, but there was no activity on that account since 15.8.2023

Lucky some prolific modmaker fixed that already: https://github.com/fluxionary/minetest-envelopes.git

This fork is now active on the testserver.

flux' PR is open for TWO YEARS now? Let's adopt and release the fork. This is certainly something that bugs not only us. The name of the maintainer, archfan, does ring a bell, but there was no activity on that account since 15.8.2023 Lucky some prolific modmaker fixed that already: https://github.com/fluxionary/minetest-envelopes.git This fork is now active on the testserver.
👍 1
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-02-01 07:01:27 +01:00
AliasAlreadyTaken added
4. step/ready to QA test
 and removed
4. step/blocked
 labels 2024-02-01 07:01:54 +01:00
whosit commented 2024-02-05 16:35:56 +01:00
Member
Copy Link

Test server version prevents me from creating such unopenable letters.

Test server version prevents me from creating such unopenable letters.
👍 1
whosit added the
ugh/QA OK
 label 2024-02-05 16:36:10 +01:00
flux commented 2024-03-27 01:11:31 +01:00
Member
Copy Link

this is NOT live on the main server after the 1.1.123 update. i can address a letter to FLUX and flux can't read it. not sure what labels to change this to.

this is *NOT* live on the main server after the 1.1.123 update. i can address a letter to FLUX and flux can't read it. not sure what labels to change this to.
flux modified the milestone from 1.1.123 to 1.1.123.2 2024-03-27 01:13:07 +01:00
flux modified the milestone from 1.1.123.2 to 1.1.124 2024-03-27 01:13:28 +01:00
flux added
ugh/QA main
 and removed
ugh/QA OK
 labels 2024-03-28 03:20:13 +01:00
AliasAlreadyTaken added
ugh/QA NOK
 and removed
ugh/QA main
 labels 2024-03-29 06:21:00 +01:00
AliasAlreadyTaken modified the milestone from 1.1.124 to 1.1.125 2024-04-22 14:44:43 +02:00
AliasAlreadyTaken removed this from the 1.1.125 milestone 2024-07-30 00:29:01 +02:00
whosit commented 2024-11-06 18:58:03 +01:00
Member
Copy Link

This is somehow still not on main...

This is somehow still not on main...
whosit removed the
ugh/QA NOK
 label 2024-11-09 07:45:59 +01:00
Boot commented 2024-12-29 18:35:52 +01:00
Member
Copy Link

I received an envelope to boot but I can't open it, probably because of the lower case. Ok, one possibility would be to return the envelope to the sender and ask for correct addressing. Is there another possibility?

I received an envelope to boot but I can't open it, probably because of the lower case. Ok, one possibility would be to return the envelope to the sender and ask for correct addressing. Is there another possibility?
AliasAlreadyTaken commented 2025-01-02 18:04:53 +01:00
Owner
Copy Link

Yes, we can "fix" it via worldedit. That's tedious and requires the solution flux proposed.

Yes, we can "fix" it via worldedit. That's tedious and requires the solution flux proposed.
whosit commented 2025-03-29 03:45:18 +01:00
Member
Copy Link

This was fixed forever ago, but somehow never delivered and not in a milestone?

This was fixed forever ago, but somehow never delivered and not in a milestone?
AliasAlreadyTaken added this to the 1.1.128 milestone 2025-03-29 03:46:53 +01:00
AliasAlreadyTaken commented 2025-03-29 03:47:40 +01:00
Owner
Copy Link

Apparently we never delivered flux' flavour of envelopes. Let's do that

Apparently we never delivered flux' flavour of envelopes. Let's do that
AliasAlreadyTaken commented 2025-04-27 18:55:41 +02:00
Owner
Copy Link

QA

This cannot magically correct old ones, but new ones that do have a blank in front or behind can still be opened by their receiver. Also capitalization doesn't prevent opening.

QA This cannot magically correct old ones, but new ones that do have a blank in front or behind can still be opened by their receiver. Also capitalization doesn't prevent opening.
AliasAlreadyTaken added the
ugh/QA OK
 label 2025-04-27 18:55:51 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
source/testserver

Originates on the testserver, no effect on main yet

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
source/testserver
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.128
Projects
Clear projects
No project
flux's TODO list
Assignees
Clear assignees
No Assignees
AliasAlreadyTaken
flux
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1379
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?