alexandre2005 reports: when i clicked on door of have ... #1367

New Issue

yourland-report · 2022-01-17T22:52:57Z

yourland-report commented

2022-01-17 22:52:57 +00:00

alexandre2005 reports a bug:

when i clicked on door of haven townhall (castle doors), with a compass, the compass duped on my potatas and deleted em.

Player position:

{
	y = 18.750999450684,
	x = 1978.8099365234,
	z = 1173.0300292969
}

Player look:

{
	y = -0.64652353525162,
	x = -0.045510329306126,
	z = 0.76153540611267
}

Player information:

{
	min_rtt = 0.014999999664724,
	max_rtt = 0.34400001168251,
	connection_uptime = 50,
	max_jitter = 0.32600000500679,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.01799999922514,
	state = "Active",
	avg_jitter = 0.0019999984651804,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 5300\", \"3d_armor:chestplate_crystal 1 5300\", \"3d_armor:leggings_crystal 1 5300\", \"3d_armor:boots_crystal 1 5300\", \"shields:shield_crystal 1 5300\", \"\"}",
		played_time = "2110989",
		jointime = "1620902771",
		yl_commons_player_joined = "1642459942",
		["signslib:pos"] = "(1551,165,305)",
		digged_nodes = "537650",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "main",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -20493, [\"x\"] = 1376, [\"z\"] = 703}, [\"last_heal\"] = 1638658034, [\"last_death_portal\"] = 1642196603}",
		xp = "554829",
		["stamina:level"] = "16.7",
		punch_count = "28341",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "202036",
		crafted = "37686",
		partypvp = "true",
		yl_commons_thankyou = "34",
		placed_nodes = "246105",
		died = "122",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1620902771"
	}
}

Log identifier


[MOD] yl_report log identifier = VdtByToTbgBZfMLT4wxVXsymVX5UTVYX

Profiler save:

profile-20220117T235256.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=219346, max_lag=4.88216, clients={alexandre2005, Ypsilon, AliasAlreadyTaken, Granum, Dreamer_idkk, MicaelStarfire, Arcanus, Lucien_II, ccady, darealbang, karlbrock, Bla, shanish, Sokomine, guestxmart, Boot, Bailiff, flux}

Teleport command:

/teleport xyz 1979 19 1173

Compass command:

/give_compass Construction VdtByToTbgBZfMLT4wxVXsymVX5UTVYX D2691E 1979 19 1173

alexandre2005 reports a bug: > when i clicked on door of haven townhall (castle doors), with a compass, the compass duped on my potatas and deleted em. Player position: ``` { y = 18.750999450684, x = 1978.8099365234, z = 1173.0300292969 } ``` Player look: ``` { y = -0.64652353525162, x = -0.045510329306126, z = 0.76153540611267 } ``` Player information: ``` { min_rtt = 0.014999999664724, max_rtt = 0.34400001168251, connection_uptime = 50, max_jitter = 0.32600000500679, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.01799999922514, state = "Active", avg_jitter = 0.0019999984651804, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_crystal 1 5300\", \"3d_armor:chestplate_crystal 1 5300\", \"3d_armor:leggings_crystal 1 5300\", \"3d_armor:boots_crystal 1 5300\", \"shields:shield_crystal 1 5300\", \"\"}", played_time = "2110989", jointime = "1620902771", yl_commons_player_joined = "1642459942", ["signslib:pos"] = "(1551,165,305)", digged_nodes = "537650", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "main", yl_church = "return {[\"last_death\"] = {[\"y\"] = -20493, [\"x\"] = 1376, [\"z\"] = 703}, [\"last_heal\"] = 1638658034, [\"last_death_portal\"] = 1642196603}", xp = "554829", ["stamina:level"] = "16.7", punch_count = "28341", arenalib_infobox_arenaID = "0", inflicted_damage = "202036", crafted = "37686", partypvp = "true", yl_commons_thankyou = "34", placed_nodes = "246105", died = "122", hud_state = "on", repellant = "0", yl_commons_player_created = "1620902771" } } ``` Log identifier ``` [MOD] yl_report log identifier = VdtByToTbgBZfMLT4wxVXsymVX5UTVYX ``` Profiler save: ``` profile-20220117T235256.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=219346, max_lag=4.88216, clients={alexandre2005, Ypsilon, AliasAlreadyTaken, Granum, Dreamer_idkk, MicaelStarfire, Arcanus, Lucien_II, ccady, darealbang, karlbrock, Bla, shanish, Sokomine, guestxmart, Boot, Bailiff, flux} ``` Teleport command: ``` /teleport xyz 1979 19 1173 ``` Compass command: ``` /give_compass Construction VdtByToTbgBZfMLT4wxVXsymVX5UTVYX D2691E 1979 19 1173 ```

AliasAlreadyTaken was assigned by yourland-report

2022-01-17 22:52:57 +00:00

Styxcolor added the

1. kind/bug

label 2022-01-18 09:17:10 +00:00

Styxcolor commented

2022-01-18 09:17:42 +00:00

This is a weird bug, confirmed this happens, I also saw Alias hand out replacement of the lost items to alexandre ingame. Now we got to find out what happened there and why it happend.

AliasAlreadyTaken commented

2022-01-24 07:53:53 +00:00

Cannot reproduce. Sounds odd as hell :D

There is a copy mechanic in the compass, but only by means of crafting.

Aloha.

I cannot reproduce the incident. Can you maybe show me what exactly you did?

Greetings, Alias

Cannot reproduce. Sounds odd as hell :D There is a copy mechanic in the compass, but only by means of crafting. > Aloha. > I cannot reproduce the incident. Can you maybe show me what exactly you did? > Greetings, Alias

AliasAlreadyTaken added the

4. step/help wanted

label 2022-01-24 07:54:08 +00:00

flux commented

2022-10-25 16:02:54 +00:00

i figured out how to replicate this, it's (basically) the same issue that leads to book duping in #891. castle doors are not involved.

how to duplicate:

use your own compass
right click to open up the compass formspec
before the formspec shows, select a different inventory slot
when the formspec appears, click "save"
whatever was in that slot is now replaced by a compass.

i figured out how to replicate this, it's (basically) the same issue that leads to book duping in #891. castle doors are not involved. how to duplicate: * use your own compass * right click to open up the compass formspec * before the formspec shows, select a different inventory slot * when the formspec appears, click "save" * whatever was in that slot is now replaced by a compass.

flux added

3. source/mod upstream

and removed

4. step/help wanted

labels 2022-10-25 16:03:10 +00:00

flux commented

2022-10-25 16:08:30 +00:00

hm upstream is https://gitea.your-land.de/whosit/waypoint_compass...

flux referenced this issue

2022-10-30 17:55:15 +00:00

stackable empty compass #2186

whosit self-assigned this 2023-05-12 14:31:03 +00:00

whosit commented

2023-05-12 17:58:00 +00:00

05f47c2445
should prevent duping compasses, but may still overwrite other compass if there is more than one. Too lazy to fix that now :P

https://gitea.your-land.de/whosit/waypoint_compass/commit/05f47c244558cd05bc158655908f1b6304ac3cbd should prevent duping compasses, but may still overwrite other compass if there is more than one. Too lazy to fix that now :P

flux commented

2023-05-12 18:47:57 +00:00

for reference, this is how the issue was solved for books: https://github.com/minetest/minetest_game/pull/2957/files

👀 1

whosit commented

2023-05-24 16:47:57 +00:00

for reference, this is how the issue was solved for books: https://github.com/minetest/minetest_game/pull/2957/files

Updated compass to do same thing:
c01ba435b7

Also would be nice to have "wielded_item" api with on_wield, on_unwield callbacks, and some sort of "show_editing_formspec" function maybe?

> for reference, this is how the issue was solved for books: https://github.com/minetest/minetest_game/pull/2957/files Updated compass to do same thing: https://gitea.your-land.de/whosit/waypoint_compass/commit/c01ba435b7573551f3bf69c467525f3ae51ad931 Also would be nice to have "wielded_item" api with on_wield, on_unwield callbacks, and some sort of "show_editing_formspec" function maybe?

whosit added the

4. step/ready to QA test

label 2023-06-04 08:39:48 +00:00

AliasAlreadyTaken added this to the 1.1.122 milestone 2023-12-06 16:50:14 +00:00

AliasAlreadyTaken commented

2023-12-06 16:50:42 +00:00

QA

I can't get it to dupe when I click doors or gates or portcullis

QA I can't get it to dupe when I click doors or gates or portcullis

AliasAlreadyTaken added the

ugh/QA OK

label 2023-12-06 16:50:50 +00:00

flux commented

2023-12-07 01:00:17 +00:00

QA

I can't get it to dupe when I click doors or gates or portcullis

the issue isn't clicking on doors etc., it's changing the selected item index before the formspec opens. saving the formspec would create a new compass in the currently selected position, and ignore the previous one. this would also destroy any item that might have already been in that position.

> QA > > I can't get it to dupe when I click doors or gates or portcullis the issue isn't clicking on doors etc., it's changing the selected item index before the formspec opens. saving the formspec would create a new compass in the currently selected position, and ignore the previous one. this would also destroy any item that might have already been in that position.

👍 1

AliasAlreadyTaken commented

2023-12-07 23:34:20 +00:00

I completely misunterstood the repro :D

I retested with lag and changing itemslots, it works

I completely misunterstood the repro :D I retested with lag and changing itemslots, it works

flux added the

5. result/fixed

label 2023-12-17 22:40:49 +00:00

AliasAlreadyTaken was unassigned by flux

2023-12-17 22:40:52 +00:00

whosit was unassigned by flux