AliasAlreadyTaken reports: abriglass needs to be saw-able ... #132

New Issue

yourland-report · 2020-12-15T22:51:09Z

yourland-report commented

2020-12-15 22:51:09 +00:00

AliasAlreadyTaken reports a bug:

abriglass needs to be saw-able, at least some of them. The oneway glas must not be cuttable

Player position:

{
	y = 18,
	x = 1987,
	z = 1184
}

Player look:

{
	y = -0.21967592835426,
	x = 0.0051082330755889,
	z = -0.97555953264236
}

Log identifier


[MOD] yl_report log identifier = 4XyQHLgHfrXhLKx90nXOK6WSdsDO3CQn

Profiler save:

profile-20201215T235109.json_pretty

Status:

# Server: version=5.3.0-yl, uptime=79034.9, max_lag=7.79843, clients={Sarah, okka, SEPPO, Elias, Rex_2000, lernpvp, Ronri, Beth, AliasAlreadyTaken, lastBlood, Bailiff}

AliasAlreadyTaken reports a bug: ``` abriglass needs to be saw-able, at least some of them. The oneway glas must not be cuttable ``` Player position: ``` { y = 18, x = 1987, z = 1184 } ``` Player look: ``` { y = -0.21967592835426, x = 0.0051082330755889, z = -0.97555953264236 } ``` Log identifier ``` [MOD] yl_report log identifier = 4XyQHLgHfrXhLKx90nXOK6WSdsDO3CQn ``` Profiler save: ``` profile-20201215T235109.json_pretty ``` Status: ``` # Server: version=5.3.0-yl, uptime=79034.9, max_lag=7.79843, clients={Sarah, okka, SEPPO, Elias, Rex_2000, lernpvp, Ronri, Beth, AliasAlreadyTaken, lastBlood, Bailiff} ```

AliasAlreadyTaken was assigned by yourland-report

2020-12-15 22:51:09 +00:00

AliasAlreadyTaken added the

1. kind/enhancement

label 2020-12-15 23:07:50 +00:00

AliasAlreadyTaken commented

2020-12-15 23:07:58 +00:00

Reporter: Ronri

Skyisblue commented

2020-12-16 14:08:25 +00:00

I think its not sawable cause of the fire function.

flux added the

4. step/want approval

label 2022-04-05 00:41:46 +00:00

flux commented

2022-04-05 00:44:36 +00:00

@AliasAlreadyTaken Xonon wants saw-able "abriglass:oneway_wall_dark" for construction of a statue in my area. This is a fully opaque node, used in the construction of the oneway glass, hence the name. Would you approve a PR (probably to yl_custom) that added that? I'll investigate cutting other abriglass nodes, and the effect on the fire function, at the same time.

flux commented

2022-05-16 22:12:04 +00:00

cut abriglass doesn't support the same fire function, but otherwise it works fine.

flux referenced this issue

2022-05-16 22:20:24 +00:00

noodles reports: the table-saw won't work on cl ... #464

flux commented

2022-05-16 22:59:26 +00:00

e7243ec520 has disabled code that would create 23 variants of 25 abriglass nodes, for a total of 575 new node IDs, which is quite a lot. I'd at least like to get abriglass:oneway_wall_dark and perhaps a few others.

https://gitea.your-land.de/your-land/yl_commons/commit/e7243ec5203c5e6f6b5a9b0d161c3a71b5b411b9 has disabled code that would create 23 variants of 25 abriglass nodes, for a total of 575 new node IDs, which is quite a lot. I'd at least like to get abriglass:oneway_wall_dark and perhaps a few others.

flux commented

2022-05-21 00:14:12 +00:00

@AliasAlreadyTaken can i get approval to add just the 23 varieties for "abriglass:oneway_wall_dark", so that Xonon can finish that statue?

@AliasAlreadyTaken can i get approval to add just the 23 varieties for `"abriglass:oneway_wall_dark"`, so that Xonon can finish that statue?

👍 1

AliasAlreadyTaken added the

4. step/approved

label 2022-05-21 02:15:58 +00:00

AliasAlreadyTaken commented

2022-05-21 02:27:39 +00:00

I'm not too happy to add a one-time/single-project node to the saw that is not widely used.

What's the reason for using this one and not black wool or black baked clay (which are both in the saw already).

Was it not known at the beginning of the project that microblocks would be needed for the statue?

If all fails: Let's add it.

I'm not too happy to add a one-time/single-project node to the saw that is not widely used. What's the reason for using this one and not black wool or black baked clay (which are both in the saw already). Was it not known at the beginning of the project that microblocks would be needed for the statue? If all fails: Let's add it.

flux commented

2022-05-21 15:34:55 +00:00

What's the reason for using this one and not black wool or black baked clay (which are both in the saw already).

Was it not known at the beginning of the project that microblocks would be needed for the statue?

I think it was chosen because it's much darker than either the wool or the clay, by a significant amount (about 1/2 the brightness). When it was halfway built, i told Xonon that it could "probably" be added to the saw.

> What's the reason for using this one and not black wool or black baked clay (which are both in the saw already). > > Was it not known at the beginning of the project that microblocks would be needed for the statue? I think it was chosen because it's much darker than either the wool or the clay, by a significant amount (about 1/2 the brightness). When it was halfway built, i told Xonon that it could "probably" be added to the saw.

flux added the

4. step/at work

label 2022-05-22 01:09:22 +00:00

flux self-assigned this 2022-05-24 16:09:58 +00:00

flux commented

2022-05-24 20:47:07 +00:00

Added 23 cut nodes for just oneway_wall_dark e5c8771ede

Added 23 cut nodes for just oneway_wall_dark https://gitea.your-land.de/your-land/yl_commons/commit/e5c8771ede6ccaef8a76d587cf70f220af48d8f5

flux added

4. step/ready to QA test

and removed

4. step/at work