Xonon reports: ethereal:slab_crystal_block do ... #1255

New Issue

yourland-report · 2022-01-01T01:30:16Z

yourland-report commented

2022-01-01 01:30:16 +00:00

Xonon reports a bug:

ethereal:slab_crystal_block does not glow like the full block.

Player position:

{
	y = 14.5,
	x = 1047.6259765625,
	z = 2076.0690917969
}

Player look:

{
	y = 0.56927955150604,
	x = -0.82109123468399,
	z = 0.04159327968955
}

Player information:

{
	min_rtt = 0.15399999916553,
	max_rtt = 19.608999252319,
	connection_uptime = 11125,
	max_jitter = 19.278999328613,
	minor = 5,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.5.0-dev-40bee27",
	avg_rtt = 0.30099999904633,
	state = "Active",
	avg_jitter = 0.0040000081062317,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 16160\", \"3d_armor:chestplate_rainbow 1 16160\", \"3d_armor:leggings_rainbow 1 16160\", \"3d_armor:boots_crystal 1 20780\", \"shields:shield_rainbow 1 16160\", \"\"}",
		["petz:werewolf_vignette_id"] = "20",
		played_time = "2614005",
		jointime = "1621665541",
		yl_commons_player_joined = "1640989709",
		["signslib:pos"] = "(1038,18,2093)",
		digged_nodes = "353385",
		punch_count = "17140",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "party",
		["petz:werewolf_clan_idx"] = "2",
		["petz:lycanthropy"] = "1",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = 28, [\"x\"] = 3666, [\"z\"] = 2334}, [\"last_death_portal\"] = 1640993668}",
		["petz:werewolf"] = "1",
		["stamina:level"] = "4",
		xp = "395039",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "203096",
		crafted = "22049",
		["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}",
		yl_commons_thankyou = "34",
		died = "36",
		placed_nodes = "169362",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621665541"
	}
}

Log identifier


[MOD] yl_report log identifier = u5sB2MnCrPnLGgMfx7mK8ylgCuYXT9Bo

Profiler save:

profile-20220101T023015.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=80739, max_lag=2.23971, clients={a_happy_chick, meatball, Bailiff, AliasAlreadyTaken, annah, Service, LeetPeet, GrimPixel, turtle, Oakenshield, guestxmart, flux, Xonon}

Teleport command:

/teleport xyz 1048 15 2076

Compass command:

/give_compass Construction u5sB2MnCrPnLGgMfx7mK8ylgCuYXT9Bo D2691E 1048 15 2076

Xonon reports a bug: > ethereal:slab_crystal_block does not glow like the full block. Player position: ``` { y = 14.5, x = 1047.6259765625, z = 2076.0690917969 } ``` Player look: ``` { y = 0.56927955150604, x = -0.82109123468399, z = 0.04159327968955 } ``` Player information: ``` { min_rtt = 0.15399999916553, max_rtt = 19.608999252319, connection_uptime = 11125, max_jitter = 19.278999328613, minor = 5, major = 5, ip_version = 6, formspec_version = 4, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.5.0-dev-40bee27", avg_rtt = 0.30099999904633, state = "Active", avg_jitter = 0.0040000081062317, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:helmet_rainbow 1 16160\", \"3d_armor:chestplate_rainbow 1 16160\", \"3d_armor:leggings_rainbow 1 16160\", \"3d_armor:boots_crystal 1 20780\", \"shields:shield_rainbow 1 16160\", \"\"}", ["petz:werewolf_vignette_id"] = "20", played_time = "2614005", jointime = "1621665541", yl_commons_player_joined = "1640989709", ["signslib:pos"] = "(1038,18,2093)", digged_nodes = "353385", punch_count = "17140", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "party", ["petz:werewolf_clan_idx"] = "2", ["petz:lycanthropy"] = "1", yl_church = "return {[\"last_death\"] = {[\"y\"] = 28, [\"x\"] = 3666, [\"z\"] = 2334}, [\"last_death_portal\"] = 1640993668}", ["petz:werewolf"] = "1", ["stamina:level"] = "4", xp = "395039", arenalib_infobox_arenaID = "0", inflicted_damage = "203096", crafted = "22049", ["petz:old_override_table"] = "return {[\"new_move\"] = true, [\"sneak\"] = true, [\"sneak_glitch\"] = false, [\"jump\"] = 1.5, [\"speed\"] = 2, [\"gravity\"] = 1}", yl_commons_thankyou = "34", died = "36", placed_nodes = "169362", hud_state = "on", repellant = "0", yl_commons_player_created = "1621665541" } } ``` Log identifier ``` [MOD] yl_report log identifier = u5sB2MnCrPnLGgMfx7mK8ylgCuYXT9Bo ``` Profiler save: ``` profile-20220101T023015.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=80739, max_lag=2.23971, clients={a_happy_chick, meatball, Bailiff, AliasAlreadyTaken, annah, Service, LeetPeet, GrimPixel, turtle, Oakenshield, guestxmart, flux, Xonon} ``` Teleport command: ``` /teleport xyz 1048 15 2076 ``` Compass command: ``` /give_compass Construction u5sB2MnCrPnLGgMfx7mK8ylgCuYXT9Bo D2691E 1048 15 2076 ```

AliasAlreadyTaken was assigned by yourland-report

2022-01-01 01:30:16 +00:00

Styxcolor added the

1. kind/bug

label 2022-01-01 08:32:13 +00:00

Styxcolor commented

2022-01-01 08:32:30 +00:00

Marked it as bug but not sure whether this is a bug. After all it is not the full block indeed.

flux commented

2022-01-03 21:41:32 +00:00

slabs of other glowing thing tend to glow, i'd consider this a bug. moreblocks will typically decrease the lightsource by for all microblocks by 1.

ethereal fails to pass the light_source value through to moreblocks:

https://notabug.org/TenPlus1/ethereal/src/master/stairs.lua#L21-L26

compare to e.g. https://gitea.your-land.de/your-land/yl_nether/src/branch/master/moreblock_reg.lua#L17-L24

slabs of other glowing thing tend to glow, i'd consider this a bug. moreblocks will typically decrease the lightsource by for all microblocks by 1. ethereal fails to pass the light_source value through to moreblocks: https://notabug.org/TenPlus1/ethereal/src/master/stairs.lua#L21-L26 compare to e.g. https://gitea.your-land.de/your-land/yl_nether/src/branch/master/moreblock_reg.lua#L17-L24

flux commented

2022-07-02 19:15:14 +00:00

this will be fixed automatically when my moreblocks PR gets accepted.

flux added this to the flux's TODO list project 2022-07-02 19:15:18 +00:00

flux added the

3. source/mod upstream

4. step/ready to QA test

labels 2022-07-02 19:15:34 +00:00

flux added

4. step/blocked

and removed

4. step/ready to QA test