LeetPeet reports: Can you make colored bricks no ... #1201

New Issue

yourland-report · 2021-12-23T11:43:21Z

yourland-report commented

2021-12-23 11:43:21 +00:00

LeetPeet reports a bug:

Can you make colored bricks not rotatable unless you're using a screwdriver? Colored bricks can rotate in weird ways when you place them, unlike regular stone brick.

Player position:

{
	y = 13.5,
	x = 1067.7730712891,
	z = 2051.6420898438
}

Player look:

{
	y = 0.24005861580372,
	x = -0.41087499260902,
	z = 0.87951892614365
}

Player information:

{
	min_rtt = 0.097999997437,
	max_rtt = 1.9349999427795,
	connection_uptime = 1377,
	max_jitter = 1.8279999494553,
	minor = 4,
	major = 5,
	ip_version = 6,
	formspec_version = 4,
	patch = 1,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.4.1",
	avg_rtt = 0.23199999332428,
	state = "Active",
	avg_jitter = 0.11199999600649,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 6600\", \"\", \"\", \"\", \"\", \"\"}",
		played_time = "2132582",
		yl_commons_player_joined = "1640258442",
		["signslib:pos"] = "(1037,15,2108)",
		digged_nodes = "1187991",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		partychat = "main",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -249, [\"x\"] = 789, [\"z\"] = 2120}, [\"last_heal\"] = 1630693112, [\"last_death_portal\"] = 1640129921}",
		["stamina:level"] = "14.425",
		punch_count = "7427",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "66396",
		crafted = "14968",
		xp = "1045980",
		yl_commons_thankyou = "11",
		died = "166",
		placed_nodes = "150851",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1609243939"
	}
}

Log identifier


[MOD] yl_report log identifier = afjTitWQ26XbzNlYmNeokpg9LVdQZrfY

Profiler save:

profile-20211223T124321.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=148889, max_lag=5.55947, clients={XeLNaGa, atomicx, bluattire, GH111, GlobalSilver, LeetPeet, debian44, Dragoni_is_bored, kilvbz, hfjku, ALCOHOL3, kohai, inconu, fire, Flippster, Imhotheb, Pecka, Lemonpurple, Bla, Or, Bailiff, Service, AliasAlreadyTaken}

Teleport command:

/teleport xyz 1068 14 2052

Compass command:

/give_compass Construction afjTitWQ26XbzNlYmNeokpg9LVdQZrfY D2691E 1068 14 2052

LeetPeet reports a bug: > Can you make colored bricks not rotatable unless you're using a screwdriver? Colored bricks can rotate in weird ways when you place them, unlike regular stone brick. Player position: ``` { y = 13.5, x = 1067.7730712891, z = 2051.6420898438 } ``` Player look: ``` { y = 0.24005861580372, x = -0.41087499260902, z = 0.87951892614365 } ``` Player information: ``` { min_rtt = 0.097999997437, max_rtt = 1.9349999427795, connection_uptime = 1377, max_jitter = 1.8279999494553, minor = 4, major = 5, ip_version = 6, formspec_version = 4, patch = 1, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.4.1", avg_rtt = 0.23199999332428, state = "Active", avg_jitter = 0.11199999600649, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 6600\", \"\", \"\", \"\", \"\", \"\"}", played_time = "2132582", yl_commons_player_joined = "1640258442", ["signslib:pos"] = "(1037,15,2108)", digged_nodes = "1187991", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", partychat = "main", yl_church = "return {[\"last_death\"] = {[\"y\"] = -249, [\"x\"] = 789, [\"z\"] = 2120}, [\"last_heal\"] = 1630693112, [\"last_death_portal\"] = 1640129921}", ["stamina:level"] = "14.425", punch_count = "7427", arenalib_infobox_arenaID = "0", inflicted_damage = "66396", crafted = "14968", xp = "1045980", yl_commons_thankyou = "11", died = "166", placed_nodes = "150851", hud_state = "on", repellant = "0", yl_commons_player_created = "1609243939" } } ``` Log identifier ``` [MOD] yl_report log identifier = afjTitWQ26XbzNlYmNeokpg9LVdQZrfY ``` Profiler save: ``` profile-20211223T124321.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=148889, max_lag=5.55947, clients={XeLNaGa, atomicx, bluattire, GH111, GlobalSilver, LeetPeet, debian44, Dragoni_is_bored, kilvbz, hfjku, ALCOHOL3, kohai, inconu, fire, Flippster, Imhotheb, Pecka, Lemonpurple, Bla, Or, Bailiff, Service, AliasAlreadyTaken} ``` Teleport command: ``` /teleport xyz 1068 14 2052 ``` Compass command: ``` /give_compass Construction afjTitWQ26XbzNlYmNeokpg9LVdQZrfY D2691E 1068 14 2052 ```

AliasAlreadyTaken was assigned by yourland-report

2021-12-23 11:43:21 +00:00

Styxcolor added the

1. kind/enhancement

label 2021-12-26 05:30:09 +00:00

Styxcolor added this to the (deleted) project 2022-01-06 21:48:13 +00:00

Styxcolor added the

4. step/question

label 2022-01-06 21:48:35 +00:00

Styxcolor removed this from the (deleted) project 2022-01-28 00:28:25 +00:00

AliasAlreadyTaken commented

2022-05-12 02:43:17 +00:00

Aloha,

I cannot reproduce the issue, can you show me? In my experiments the coloured bricks were set down the way they should.

We're talking of cblocks:stonebrick_magenta and sorts?

Greetings, Alias

Aloha, I cannot reproduce the issue, can you show me? In my experiments the coloured bricks were set down the way they should. We're talking of cblocks:stonebrick_magenta and sorts? Greetings, Alias

AliasAlreadyTaken added

4. step/help wanted

and removed

4. step/question

labels 2022-05-12 02:43:55 +00:00

flux commented

2022-05-12 05:01:50 +00:00

This might depend on your "rhotator settings".

I placed a cblocks:stonebrick_orange on a darkage:basalt_brick w/ param2=0. I rotated it once, so that param2=2.

I then placed another cblocks:stonebrick_orange against the west side of the first cblocks:stonebrick_orange. It set itself w/ param2=18, which is far from expected for any model I can intuit.

I'm not certain where the param2 shenanigans originate, but I suspect rhotator.

This might depend on your "rhotator settings". I placed a `cblocks:stonebrick_orange` on a `darkage:basalt_brick` w/ `param2=0`. I rotated it once, so that `param2=2`. I then placed another `cblocks:stonebrick_orange` against the west side of the first `cblocks:stonebrick_orange`. It set itself w/ `param2=18`, which is far from expected for any model I can intuit. I'm not certain where the param2 shenanigans originate, but I suspect rhotator.

AliasAlreadyTaken commented

2022-05-12 05:06:30 +00:00

Why would rhotator do that? I better not ask. Let's reproduce with and without rhotator, if your suspicion holds true, then this is an upstream rhotator issue. If not, then this is an upstream cblocks issue.

Bla commented

2022-05-12 07:44:11 +00:00

Reproduced flux setup.

memory rhotator off:
same strange rotations like flux & LeetPeet
memory rhotator on:
perfectly works using a previous copied rotation
memory rhotator auto:
nicely rotates to the same param2 as the node you pointed at.

Also tried with default:stonebrick same result except with rhotator off I dont get strange rotations.
So I guess that it isnt rhotators fault but cblocks.

checked cblocks code and in Line 110 there is
on_place = minetest.rotate_node,

I dont totally get what rotate_node does but could that be the culprit?

Reproduced flux setup. * memory rhotator off: same strange rotations like flux & LeetPeet * memory rhotator on: perfectly works using a previous copied rotation * memory rhotator auto: nicely rotates to the same param2 as the node you pointed at. Also tried with default:stonebrick same result except with rhotator off I dont get strange rotations. So I guess that it isnt rhotators fault but cblocks. checked cblocks code and in [Line 110](https://notabug.org/TenPlus1/cblocks/src/master/init.lua#L110) there is `on_place = minetest.rotate_node,` I dont totally get what rotate_node does but could that be the culprit?

flux referenced this issue

2022-05-28 19:04:45 +00:00

Wood rotation #1950

flux added this to the flux's TODO list project 2022-07-02 19:09:41 +00:00

flux added the

4. step/discussion

label 2022-10-25 13:21:45 +00:00

flux referenced this issue

2023-05-18 22:30:05 +00:00

Laylem reports: [node request?] I want a node ... #4454

flux commented

2023-05-18 22:42:25 +00:00

on_place = minetest.rotate_node,
I dont totally get what rotate_node does but could that be the culprit?

ah, yes, that's almost certainly it. however, rhotator does muck w/ nodes that don't define an on_place themselves.

> `on_place = minetest.rotate_node,` > I dont totally get what rotate_node does but could that be the culprit? ah, yes, that's almost certainly it. however, rhotator *does* muck w/ nodes that don't define an `on_place` themselves.

flux referenced this issue

2023-05-18 22:53:51 +00:00

prevent jonez column nodes from rotating when placing them. #4537

flux commented

2023-05-18 23:11:39 +00:00

ah, yes, that's almost certainly it. however, rhotator does muck w/ nodes that don't define an on_place themselves.

though not when rhotator memory is set to off. apparently the engine does the rotation for facedir nodes automatically, unless you set place_param2 = 0

> ah, yes, that's almost certainly it. however, rhotator *does* muck w/ nodes that don't define an `on_place` themselves. though not when rhotator memory is set to off. apparently the engine does the rotation for facedir nodes automatically, unless you set `place_param2 = 0`

AliasAlreadyTaken commented

2024-01-17 11:46:05 +00:00

Are those coloured bricks the only ones that have this?

If they are the only ones, we should disable it on them as well. I'd like to unify how rotation works when placing a block.

Participants in this discussion are only a small fraction of those that use the feature, we could ask the general audience in a demonstration in Haven which way they prefer and then make this available for everyone.

I am opposed to each and every block deciding on their own, how they want to be placed - unless there is a compelling reason they are different?

Are those coloured bricks the only ones that have this? If they are the only ones, we should disable it on them as well. I'd like to unify how rotation works when placing a block. Participants in this discussion are only a small fraction of those that use the feature, we could ask the general audience in a demonstration in Haven which way they prefer and then make this available for everyone. I am opposed to each and every block deciding on their own, how they want to be placed - unless there is a compelling reason they are different?

AliasAlreadyTaken removed the

4. step/discussion

label 2024-01-17 11:46:20 +00:00

flux commented

2024-01-17 22:47:07 +00:00