Can't assign personal player skin when player has underscore in their name #114

Closed
opened 2020-12-10 15:03:50 +00:00 by AliasAlreadyTaken · 17 comments
https://github.com/minetest-mods/skinsdb/issues/54
AliasAlreadyTaken added the
1. kind/bug
3. source/mod upstream
labels 2020-12-10 15:04:01 +00:00
flux added the
2. prio/good first issue
label 2022-09-04 03:50:26 +00:00

https://github.com/blaboing/skinsdb
my attempt at fixing it, works so far but needs testing. feedback appreciated

tested with

  • character_creator
  • sfinv
  • unified_inventory
  • smart_inventory
  • i3
  • 3d_armor
https://github.com/blaboing/skinsdb my attempt at fixing it, works so far but needs testing. feedback appreciated tested with - [x] character_creator - [x] sfinv - [x] unified_inventory - [x] smart_inventory - [x] i3 - [x] 3d_armor
Bla self-assigned this 2023-01-25 23:43:39 +00:00
Member

https://github.com/blaboing/skinsdb
my attempt at fixing it, works so far but needs testing. feedback appreciated

i haven't run it, but the code looks good, it looks ready to PR upstream. thanks for this :)

> https://github.com/blaboing/skinsdb > my attempt at fixing it, works so far but needs testing. feedback appreciated i haven't run it, but the code looks good, it looks ready to PR upstream. thanks for this :)

ty for the feedback but still need to test it with the supported mods.

ty for the feedback but still need to test it with the supported mods.
Author
Owner

Do we want to put this up on the testserver? Of the list, we have at least 3d_armor and unified_inventory.

Do we want to put this up on the testserver? Of the list, we have at least 3d_armor and unified_inventory.

Do we want to put this up on the testserver? Of the list, we have at least 3d_armor and unified_inventory.

Currently doing basic tests locally cause changes can be done quicker and log spamming 😆
But after that a testrun with more skins and player data would be nice.
@daydream already did proof read my english in textures.txt (ty again) but feedback from someone really doing it on a larger scale would be nice too.

> Do we want to put this up on the testserver? Of the list, we have at least 3d_armor and unified_inventory. Currently doing basic tests locally cause changes can be done quicker and log spamming 😆 But after that a testrun with more skins and player data would be nice. @daydream already did proof read my english in textures.txt (ty again) but feedback from someone really doing it on a larger scale would be nice too.

And basic tests done, couldn´t find any problems with any of those mods.

And basic tests done, couldn´t find any problems with any of those mods.
And PR upstream https://github.com/minetest-mods/skinsdb/pull/83
flux added the
4. step/blocked
label 2023-02-20 19:54:14 +00:00
> And PR upstream https://github.com/minetest-mods/skinsdb/pull/83 merged
AliasAlreadyTaken added this to the 1.1.119 milestone 2023-05-10 23:21:07 +00:00
AliasAlreadyTaken added the
4. step/ready to QA test
label 2023-05-10 23:21:20 +00:00
Author
Owner

QA

Nice :) Thank you, Bla!

QA Nice :) Thank you, Bla!
AliasAlreadyTaken added the
ugh/QA OK
label 2023-05-14 20:18:19 +00:00
flux removed the
4. step/blocked
label 2023-05-18 17:56:46 +00:00
Member

how can i test that this is live on the server?

how can i test that this is live on the server?
Author
Owner

Repro:

  1. Have a player account with an underscore in it.
  2. Have a personal skin
    OK: You can see the personal skin, assign it to yourself, it persists over logouts or werewolf transformation

Maybe we should ask a player with a personal skin and an underscore in the name to assist us

Repro: 1. Have a player account with an underscore in it. 2. Have a personal skin OK: You can see the personal skin, assign it to yourself, it persists over logouts or werewolf transformation Maybe we should ask a player with a personal skin and an underscore in the name to assist us
3. Hope that Alias didnt forget https://github.com/minetest-mods/skinsdb/blob/master/textures/readme.txt#L11C1-L13
Author
Owner
  1. Hope that Alias didnt forget https://github.com/minetest-mods/skinsdb/blob/master/textures/readme.txt#L11C1-L13

Nope, Alias didn't forget :D I take notes in the release issue to not overload my smol brain

One thing that is more integration than anything: The werewolf mechanic stores the initial skin with underscores ... so werewolves may get a one-time message that their skin is wrong.

> 3. Hope that Alias didnt forget https://github.com/minetest-mods/skinsdb/blob/master/textures/readme.txt#L11C1-L13 Nope, Alias didn't forget :D I take notes in the release issue to not overload my smol brain One thing that is more integration than anything: The werewolf mechanic stores the initial skin with underscores ... so werewolves may get a one-time message that their skin is wrong.

One thing that is more integration than anything: The werewolf mechanic stores the initial skin with underscores ... so werewolves may get a one-time message that their skin is wrong.

Never tested with petz *incoming ugh/petz"

> One thing that is more integration than anything: The werewolf mechanic stores the initial skin with underscores ... so werewolves may get a one-time message that their skin is wrong. Never tested with petz *incoming ugh/petz"
Member

Repro:

  1. Have a player account with an underscore in it.
  2. Have a personal skin
    OK: You can see the personal skin, assign it to yourself, it persists over logouts or werewolf transformation

Maybe we should ask a player with a personal skin and an underscore in the name to assist us

so could we give flux_testing a personal skin? the same one as flux is fine.

> Repro: > > 1. Have a player account with an underscore in it. > 2. Have a personal skin > OK: You can see the personal skin, assign it to yourself, it persists over logouts or werewolf transformation > > Maybe we should ask a player with a personal skin and an underscore in the name to assist us so could we give flux_testing a personal skin? the same one as flux is fine.
Author
Owner

Done: 92ec9a04be

I'll sneak that into the mods folder so that you have it at next serverstart

Done: https://gitea.your-land.de/your-land/skinsdb/commit/92ec9a04beed2d3dedeebc5477d0584b1ad2ed17 I'll sneak that into the mods folder so that you have it at next serverstart
flux added this to the flux's TODO list project 2023-05-19 03:14:33 +00:00
Author
Owner

It worked nicely on main. Thankyou @Bla

It worked nicely on main. Thankyou @Bla
AliasAlreadyTaken added
5. result/fixed
and removed
4. step/ready to QA test
labels 2023-08-23 14:04:07 +00:00
flux removed this from the flux's TODO list project 2023-11-23 20:37:15 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#114
No description provided.