Can't assign personal player skin when player has underscore in their name #114
Labels
No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: your-land/bugtracker#114
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
https://github.com/minetest-mods/skinsdb/issues/54
https://github.com/blaboing/skinsdb
my attempt at fixing it, works so far but needs testing. feedback appreciated
tested with
i haven't run it, but the code looks good, it looks ready to PR upstream. thanks for this :)
ty for the feedback but still need to test it with the supported mods.
Do we want to put this up on the testserver? Of the list, we have at least 3d_armor and unified_inventory.
Currently doing basic tests locally cause changes can be done quicker and log spamming 😆
But after that a testrun with more skins and player data would be nice.
@daydream already did proof read my english in textures.txt (ty again) but feedback from someone really doing it on a larger scale would be nice too.
And basic tests done, couldn´t find any problems with any of those mods.
And PR upstream https://github.com/minetest-mods/skinsdb/pull/83
merged
QA
Nice :) Thank you, Bla!
how can i test that this is live on the server?
Repro:
OK: You can see the personal skin, assign it to yourself, it persists over logouts or werewolf transformation
Maybe we should ask a player with a personal skin and an underscore in the name to assist us
Nope, Alias didn't forget :D I take notes in the release issue to not overload my smol brain
One thing that is more integration than anything: The werewolf mechanic stores the initial skin with underscores ... so werewolves may get a one-time message that their skin is wrong.
Never tested with petz *incoming ugh/petz"
so could we give flux_testing a personal skin? the same one as flux is fine.
Done:
92ec9a04be
I'll sneak that into the mods folder so that you have it at next serverstart
It worked nicely on main. Thankyou @Bla