your-land/bugtracker
your-land
/
bugtracker
44
20
Code Issues 2.4k Projects 2 Wiki

yo_its_meh reports: ethereal coral and ethereal se ... #1064

New Issue
Closed
opened 2021-11-18 07:27:42 +00:00 by yourland-report · 20 comments
yourland-report commented 2021-11-18 07:27:42 +00:00
Member
Copy Link

yo_its_meh reports a bug:

ethereal coral and ethereal seaweed have for months rendered with an air bubble around them and it looks bad. these corals and seaweeds render fine on other servers, so i know that's not how it's supposed to be. cheers!

Player position:

{
	y = 8.3559999465942,
	x = 1671.3660888672,
	z = 2255.2919921875
}

Player look:

{
	y = -0.22971002757549,
	x = 0.48073327541351,
	z = -0.84624391794205
}

Player information:

{
	min_rtt = 0.083999998867512,
	max_rtt = 3.0499999523163,
	connection_uptime = 590,
	max_jitter = 2.8659999370575,
	minor = 3,
	major = 5,
	ip_version = 6,
	formspec_version = 3,
	patch = 0,
	protocol_version = 39,
	serialization_version = 28,
	lang_code = "",
	version_string = "5.3.0",
	avg_rtt = 0.097999997437,
	state = "Active",
	avg_jitter = 0.037000007927418,
	min_jitter = 0
}

Player meta:

{
	fields = {
		["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 24280\", \"3d_armor:helmet_mithril 1 24080\", \"3d_armor:leggings_mithril 1 24080\", \"shields:shield_mithril 1 24080\", \"3d_armor:chestplate_mithril 1 24080\", \"\"}",
		played_time = "312862",
		jointime = "1621741671",
		yl_commons_player_joined = "1637219895",
		["signslib:pos"] = "(1893,41,2127)",
		digged_nodes = "19718",
		bitten = "0",
		["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}",
		yl_church = "return {[\"last_death\"] = {[\"y\"] = -784, [\"x\"] = 2944, [\"z\"] = 3200}, [\"last_death_portal\"] = 1637017355}",
		["stamina:level"] = "12",
		punch_count = "3297",
		arenalib_infobox_arenaID = "0",
		inflicted_damage = "38900",
		crafted = "421",
		xp = "11536",
		placed_nodes = "691",
		yl_commons_thankyou = "3",
		died = "31",
		hud_state = "on",
		repellant = "0",
		yl_commons_player_created = "1621741671"
	}
}

Log identifier


[MOD] yl_report log identifier = 0cJlJqgm2vyjnRFDTZGfPVFkR8fJJ41F

Profiler save:

profile-20211118T082742.json_pretty

Status:

# Server: version=5.4.1-yl, uptime=359988, max_lag=1.271, clients={yo_its_meh, wishingirl, Service, AliasAlreadyTaken, Bailiff, katiebee, Diaeresis}

Teleport command:

/teleport xyz 1671 8 2255

Compass command:

/give_compass Construction 0cJlJqgm2vyjnRFDTZGfPVFkR8fJJ41F D2691E 1671 8 2255
yo_its_meh reports a bug: > ethereal coral and ethereal seaweed have for months rendered with an air bubble around them and it looks bad. these corals and seaweeds render fine on other servers, so i know that's not how it's supposed to be. cheers! Player position: ``` { y = 8.3559999465942, x = 1671.3660888672, z = 2255.2919921875 } ``` Player look: ``` { y = -0.22971002757549, x = 0.48073327541351, z = -0.84624391794205 } ``` Player information: ``` { min_rtt = 0.083999998867512, max_rtt = 3.0499999523163, connection_uptime = 590, max_jitter = 2.8659999370575, minor = 3, major = 5, ip_version = 6, formspec_version = 3, patch = 0, protocol_version = 39, serialization_version = 28, lang_code = "", version_string = "5.3.0", avg_rtt = 0.097999997437, state = "Active", avg_jitter = 0.037000007927418, min_jitter = 0 } ``` Player meta: ``` { fields = { ["3d_armor_inventory"] = "return {\"3d_armor:boots_crystal 1 24280\", \"3d_armor:helmet_mithril 1 24080\", \"3d_armor:leggings_mithril 1 24080\", \"shields:shield_mithril 1 24080\", \"3d_armor:chestplate_mithril 1 24080\", \"\"}", played_time = "312862", jointime = "1621741671", yl_commons_player_joined = "1637219895", ["signslib:pos"] = "(1893,41,2127)", digged_nodes = "19718", bitten = "0", ["unified_inventory:bags"] = "return {\"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\", \"unified_inventory:bag_large\"}", yl_church = "return {[\"last_death\"] = {[\"y\"] = -784, [\"x\"] = 2944, [\"z\"] = 3200}, [\"last_death_portal\"] = 1637017355}", ["stamina:level"] = "12", punch_count = "3297", arenalib_infobox_arenaID = "0", inflicted_damage = "38900", crafted = "421", xp = "11536", placed_nodes = "691", yl_commons_thankyou = "3", died = "31", hud_state = "on", repellant = "0", yl_commons_player_created = "1621741671" } } ``` Log identifier ``` [MOD] yl_report log identifier = 0cJlJqgm2vyjnRFDTZGfPVFkR8fJJ41F ``` Profiler save: ``` profile-20211118T082742.json_pretty ``` Status: ``` # Server: version=5.4.1-yl, uptime=359988, max_lag=1.271, clients={yo_its_meh, wishingirl, Service, AliasAlreadyTaken, Bailiff, katiebee, Diaeresis} ``` Teleport command: ``` /teleport xyz 1671 8 2255 ``` Compass command: ``` /give_compass Construction 0cJlJqgm2vyjnRFDTZGfPVFkR8fJJ41F D2691E 1671 8 2255 ```
AliasAlreadyTaken was assigned by yourland-report 2021-11-18 07:27:42 +00:00
Styxcolor added the
1. kind/bug
 label 2021-11-18 13:21:44 +00:00
Styxcolor commented 2021-11-18 13:22:25 +00:00
Owner
Copy Link

Sister issue : #607 where the fake air bubble kills diving players who rely on breathing it.

Sister issue : #607 where the fake air bubble kills diving players who rely on breathing it.
Styxcolor commented 2021-11-20 17:42:12 +00:00
Owner
Copy Link

I'm not entirely sure this is all about ethereal though, today I saw a bridge's pillar down to the sea floor being surrounded by that same weird air bubble and I don't think that were ethereal blocks, but I could be wrong.

I'm not entirely sure this is all about ethereal though, today I saw a bridge's pillar down to the sea floor being surrounded by that same weird air bubble and I don't think that were ethereal blocks, but I could be wrong.
Styxcolor added spent time 2021-11-23 02:02:59 +00:00
2h
Styxcolor commented 2021-11-23 02:03:48 +00:00
Owner
Copy Link

attempted fixing with water_life kelp green as inspiration. Did not work. I know more about the plantlike_rooted drawtype now though. Will tackle again later.

attempted fixing with water_life kelp green as inspiration. Did not work. I know more about the plantlike_rooted drawtype now though. Will tackle again later.
Styxcolor added the
4. step/help wanted
4. step/at work
 labels 2021-11-23 02:04:59 +00:00
Styxcolor commented 2021-11-23 02:06:30 +00:00
Owner
Copy Link

current problem: setting the drawtype to plantlike_rooted does indeed do away with the fake water bubbles, but instead we get an ugly bright bottom plane to the bottom texture of the ethereal seaweed that manages to even look worse.

current problem: setting the drawtype to plantlike_rooted does indeed do away with the fake water bubbles, but instead we get an ugly bright bottom plane to the bottom texture of the ethereal seaweed that manages to even look worse.
Styxcolor commented 2021-12-12 12:38:20 +00:00
Owner
Copy Link

a mod that has possibly solved this problem

https://github.com/acmgit/aqua_farming

https://forum.minetest.net/viewtopic.php?t=24352

but it comes with it's own issues, integration needed

aqua farming and bonemeal clashing in the past:

https://forum.minetest.net/viewtopic.php?p=384537#p384537

I have to check whether the situation has changed since then!

a mod that has possibly solved this problem https://github.com/acmgit/aqua_farming https://forum.minetest.net/viewtopic.php?t=24352 but it comes with it's own issues, integration needed aqua farming and bonemeal clashing in the past: https://forum.minetest.net/viewtopic.php?p=384537#p384537 I have to check whether the situation has changed since then!
Styxcolor removed the
4. step/help wanted
 label 2021-12-12 14:44:56 +00:00
Styxcolor commented 2021-12-13 05:47:08 +00:00
Owner
Copy Link

under a minute of testing and all the issues are gone. I closed my testing environment and had to sit down for a moment, then I remembered that I was sitting already.

Once I have collected myself I will inspect the code and see how to adapt this. The bonemeal issue seems to have been fixed in the meantime. Now I'm curious how they solved the airbubble problem.

under a minute of testing and all the issues are gone. I closed my testing environment and had to sit down for a moment, then I remembered that I was sitting already. Once I have collected myself I will inspect the code and see how to adapt this. The bonemeal issue seems to have been fixed in the meantime. Now I'm curious how they solved the airbubble problem.
Styxcolor commented 2021-12-13 05:57:55 +00:00
Owner
Copy Link

Hm, I still need help by Alias for this one.

Hm, I still need help by Alias for this one.
Styxcolor added the
4. step/help wanted
 label 2021-12-13 05:58:05 +00:00
Styxcolor commented 2021-12-13 18:19:20 +00:00
Owner
Copy Link

my bad,further testing revealed ethereal seaweed still has an air bubble.

my bad,further testing revealed ethereal seaweed still has an air bubble.
Styxcolor added this to the (deleted) project 2022-01-06 22:04:53 +00:00
Styxcolor removed this from the (deleted) project 2022-01-28 00:27:29 +00:00
flux removed the
4. step/at work
 label 2022-09-30 21:42:04 +00:00
flux commented 2022-10-25 01:09:59 +00:00
Member
Copy Link

only totally redoing the nodes and setting the drawtype to plantlike_rooted can fix this.

only totally redoing the nodes and setting the drawtype to `plantlike_rooted` can fix this.
👍 1
Niklp commented 2024-03-02 12:28:54 +00:00
Collaborator
Copy Link

I fixed this 2 months ago btw
see https://codeberg.org/tenplus1/ethereal/pulls/6 and https://codeberg.org/tenplus1/ethereal/pulls/5

I fixed this 2 months ago btw see https://codeberg.org/tenplus1/ethereal/pulls/6 and https://codeberg.org/tenplus1/ethereal/pulls/5
👍 2
AliasAlreadyTaken added the
4. step/ready to QA test
 label 2024-03-02 14:32:53 +00:00
AliasAlreadyTaken added this to the 1.1.123 milestone 2024-03-02 14:32:56 +00:00
AliasAlreadyTaken commented 2024-03-02 17:24:43 +00:00
Owner
Copy Link

QA

The new seaweed appears to not have that ugly airbubble anymore. The old seaweed is not converted to the new one automatically. So ... half a win?

QA The new seaweed appears to not have that ugly airbubble anymore. The old seaweed is not converted to the new one automatically. So ... half a win?
DragonWrangler commented 2024-03-02 23:20:40 +00:00
Copy Link

hm. Would it work to make an lbm to change them over ?

hm. Would it work to make an lbm to change them over ?
AliasAlreadyTaken commented 2024-03-03 01:02:18 +00:00
Owner
Copy Link

hm. Would it work to make an lbm to change them over ?

Probably, I haven't tried it yet.

> hm. Would it work to make an lbm to change them over ? Probably, I haven't tried it yet.
Niklp commented 2024-03-03 16:03:43 +00:00
Collaborator
Copy Link

The old seaweed is not converted to the new one automatically

you may want to read the code, there is a LBM (works at least on my server in prod w/o any issues)
1e67afe05e/sealife.lua (L116-L146)

> The old seaweed is not converted to the new one automatically you may want to read the code, there is a LBM (works at least on my server in prod w/o any issues) https://codeberg.org/tenplus1/ethereal/src/commit/1e67afe05e6911bc00150df95874fe69cf4a111b/sealife.lua#L116-L146
AliasAlreadyTaken commented 2024-03-05 00:32:00 +00:00
Owner
Copy Link

For some reason it only works if I set run_at_every_load = true and even then there seems to be an issue with block borders:

grafik

Also, why are the corals not done as well ? :D

For some reason it only works if I set `run_at_every_load = true` and even then there seems to be an issue with block borders: ![grafik](/attachments/7ee92849-089d-4cf8-8ba9-5a100078b04c) Also, why are the corals not done as well ? :D
grafik.png
280 KiB
AliasAlreadyTaken added the
ugh/QA NOK
 label 2024-03-05 00:37:56 +00:00
Niklp commented 2024-03-06 16:33:56 +00:00
Collaborator
Copy Link

Also, why are the corals not done as well ? :D

Read the code again please, corals are fully done too.

For some reason it only works if I set run_at_every_load = true

that's weird, should work w/o run_every_load...

there seems to be an issue with block borders

ugh, never had an issue w/ block borders on Archtec, but yeah there's a chance that the mapblock above isn't loaded

> Also, why are the corals not done as well ? :D Read the code again please, corals are fully done too. > For some reason it only works if I set run_at_every_load = true that's weird, should work w/o run_every_load... > there seems to be an issue with block borders ugh, never had an issue w/ block borders on Archtec, but yeah there's a chance that the mapblock above isn't loaded
AliasAlreadyTaken commented 2024-03-07 07:50:46 +00:00
Owner
Copy Link

Also, why are the corals not done as well ? :D

Read the code again please, corals are fully done too.

Nice :) But if I place a new coral or if they grow by themselves they look good. Somehow the LBM doesn't convert the existing ones.

For some reason it only works if I set run_at_every_load = true

that's weird, should work w/o run_every_load...

I have no theory why it doesn't

there seems to be an issue with block borders

ugh, never had an issue w/ block borders on Archtec, but yeah there's a chance that the mapblock above isn't loaded

Most likely because our loading is way slower than Archtec's

> > Also, why are the corals not done as well ? :D > > Read the code again please, corals are fully done too. Nice :) But if I place a new coral or if they grow by themselves they look good. Somehow the LBM doesn't convert the existing ones. > > For some reason it only works if I set run_at_every_load = true > > that's weird, should work w/o run_every_load... I have no theory why it doesn't > > there seems to be an issue with block borders > > ugh, never had an issue w/ block borders on Archtec, but yeah there's a chance that the mapblock above isn't loaded Most likely because our loading is way slower than Archtec's
flux commented 2024-03-09 04:13:31 +00:00
Member
Copy Link

For some reason it only works if I set run_at_every_load = true

possibly the LBM got triggered before it was ready; you can manually edit the LBM times in env_meta.txt in the world directory.

i've written some one-once LBMs that got triggered when the logic was wrong. either you remove the reference in that file, or you change the LBM ID. either option works.

> For some reason it only works if I set run_at_every_load = true possibly the LBM got triggered before it was ready; you can manually edit the LBM times in `env_meta.txt` in the world directory. i've written some one-once LBMs that got triggered when the logic was wrong. either you remove the reference in that file, or you change the LBM ID. either option works.
👍 1
AliasAlreadyTaken commented 2024-03-09 10:55:49 +00:00
Owner
Copy Link

QA

Excellent, that did the trick :)

QA Excellent, that did the trick :)
🎉 1
AliasAlreadyTaken added
ugh/QA OK
 and removed
ugh/QA NOK
 labels 2024-03-09 10:55:55 +00:00
flux added
5. result/fixed
 and removed
4. step/ready to QA test
 labels 2024-03-27 00:05:54 +00:00
AliasAlreadyTaken was unassigned by flux 2024-03-27 00:05:57 +00:00
flux commented 2024-03-27 00:06:02 +00:00
Member
Copy Link

live

live
flux closed this issue 2024-03-27 00:06:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
1. kind/balancing

Depends on balancing

  
1. kind/breaking

something that alters or disables an existing game mechanic

  
1. kind/bug

Something is not working

  
1. kind/construction

A build needs fixing

  
1. kind/documentation

Needs proper documentation

  
1. kind/enhancement

New feature

  
1. kind/griefing

players despoiling builds or nature

  
1. kind/invalid

Not a valid report, e.g. created by mistake with no content.

  
1. kind/meme

issue is mostly a joke

  
1. kind/node limit

something which works for or against the node limit

  
1. kind/other

Something not within the other kinds

  
1. kind/protocol

something concerning how staff should react to player requests, or how players should treat each other

  
2. prio/controversial

not likely to happen w/out a lot of discussion

  
2. prio/critical

Very important

  
2. prio/elevated

something players are eager to have fixed

  
2. prio/good first issue

the resolution to this is could be done by a new minetest contributor, who doesn't yet understand the mod ecosystem

  
2. prio/interesting

one of us has real interest in getting this implemented or fixed. however, more research might be needed.

  
2. prio/low

Not so important

  
3. source/art

art needs to be created or found for this to exist. includes sound, 3d modelling, and in-game building.

  
3. source/client

Issue is with the minetest client, or with player client configuration or the technical details of their setup

  
3. source/engine

Issue is due to a bug or feature of the minetest engine

  
3. source/ingame

Problem and solution exist in-game, e.g. builds or player moderation

  
3. source/integration

Two or more nonbuggy mechanics conflict, or our attempts to rectify conflicting mechanics have created a new bug

  
3. source/lag

A problem which is caused or made worse by lag, due to server processing issues, client processing issues, or network issues

  
3. source/license

A licensing problem is involved

  
3. source/mod upstream

Problem is upstream (not engine/client)

  
3. source/unknown

   
3. source/website

Affects the website

  
4. step/approved

Alias has approved this feature, someone should implement it

  
4. step/at work

Being worked on

  
4. step/blocked

we plan to do this, but other work has to be finished first

  
4. step/discussion

issue is under discussion, a solution has not been dictated or agreed upon

  
4. step/help wanted

Need some help

  
4. step/needs confirmation

   
4. step/partially fixed

this is mitigated or partially solved, but more work needs to be done

  
4. step/question

More information is needed

  
4. step/ready to deploy

has been QA tested by another person. has no outstanding issues. might be installed on prod, but needs final testing

  
4. step/ready to QA test

the code is supposedly fixed, but needs to be tested.

  
4. step/want approval

Someone can quickly implement this if Alias approves the change/feature

  
5. result/cannot reproduce

   
5. result/duplicate

This issue or pull request already exists

  
5. result/fixed

problem is fixed

  
5. result/maybe

not planned currently, but maybe some day

  
5. result/wontfix

the reported issue won't be changed, whether it's intentional or not.

  
ugh/petz

yet another petz bugz.

  
ugh/QA main

That's something we can only wait and see whether it hapens again: On the main server

  
ugh/QA NOK

Fix didn't yield the expected results

  
ugh/QA OK

tested

No Label
1. kind/balancing
1. kind/breaking
1. kind/bug
1. kind/construction
1. kind/documentation
1. kind/enhancement
1. kind/griefing
1. kind/invalid
1. kind/meme
1. kind/node limit
1. kind/other
1. kind/protocol
2. prio/controversial
2. prio/critical
2. prio/elevated
2. prio/good first issue
2. prio/interesting
2. prio/low
3. source/art
3. source/client
3. source/engine
3. source/ingame
3. source/integration
3. source/lag
3. source/license
3. source/mod upstream
3. source/unknown
3. source/website
4. step/approved
4. step/at work
4. step/blocked
4. step/discussion
4. step/help wanted
4. step/needs confirmation
4. step/partially fixed
4. step/question
4. step/ready to deploy
4. step/ready to QA test
4. step/want approval
5. result/cannot reproduce
5. result/duplicate
5. result/fixed
5. result/maybe
5. result/wontfix
ugh/petz
ugh/QA main
ugh/QA NOK
ugh/QA OK
Milestone
Clear milestone
No items
No Milestone
1.1.123
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Total Time Spent: 2 hours
Styxcolor
2 hours
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: your-land/bugtracker#1064
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?