From 62cfd61e8a0170c7c23125b2d7bbfdba47655e5e Mon Sep 17 00:00:00 2001 From: Sokomine Date: Sat, 12 Jun 2021 17:36:15 +0200 Subject: [PATCH] took care of undeclared globals --- fs_edit_effects.lua | 1 - fs_edit_general.lua | 2 +- fs_edit_preconditions.lua | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs_edit_effects.lua b/fs_edit_effects.lua index 5e3291f..93fcf87 100644 --- a/fs_edit_effects.lua +++ b/fs_edit_effects.lua @@ -553,7 +553,6 @@ yl_speak_up.execute_effect = function(player, n_id, o_id, r) doors.trapdoor_toggle(r.r_pos, node, nil) --, clicker) yl_speak_up.debug_msg(player, n_id, o_id, tostring(r.r_id).." ".. "block: Opened/closed trapdoor at "..pos_str..".") - -- TODO: not sure if right-clicking a block (as an npc) is possible without bugs elseif(minetest.registered_nodes[node.name] and minetest.registered_nodes[node.name].on_rightclick(r.r_pos, node, nil)) then minetest.registered_nodes[node.name].on_rightclick(r.r_pos, node, nil) diff --git a/fs_edit_general.lua b/fs_edit_general.lua index 5dab35a..5a5f155 100644 --- a/fs_edit_general.lua +++ b/fs_edit_general.lua @@ -59,7 +59,7 @@ minetest.register_chatcommand( 'npc_talk_debug', { end minetest.chat_send_player(pname, text) return - elseif(not(yl_speak_up.may_edit_npc(minetest.get_player_by_name(pname), n_id))) then + elseif(not(yl_speak_up.may_edit_npc(minetest.get_player_by_name(pname), param))) then minetest.chat_send_player(pname, "You do not have the necessary privs to ".. "edit that NPC.") return diff --git a/fs_edit_preconditions.lua b/fs_edit_preconditions.lua index e92e5c1..403f7ea 100644 --- a/fs_edit_preconditions.lua +++ b/fs_edit_preconditions.lua @@ -197,13 +197,13 @@ end -- *both* the condition and its inverse condition may be -- true (or false). yl_speak_up.eval_all_preconditions = function(player, prereq, o_id) + local pname = player:get_player_name() + local n_id = yl_speak_up.speak_to[pname].n_id if(not(prereq)) then yl_speak_up.debug_msg(player, n_id, o_id, "No preconditions given.") -- no prerequirements? then they are automaticly fulfilled return true end - local pname = player:get_player_name() - local n_id = yl_speak_up.speak_to[pname].n_id yl_speak_up.debug_msg(player, n_id, o_id, "Checking preconditions..") for k, p in pairs(prereq) do yl_speak_up.debug_msg(player, n_id, o_id, "..checking "..