Sokomine
/
npc_talk
3
1
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

player mesh default missing check for optional player_api #1

New Issue
Closed
opened 2024-02-05 15:34:58 +00:00 by Bla · 1 comment
Bla commented 2024-02-05 15:34:58 +00:00
Collaborator
Copy Link

e0216e418e/talking_npc.lua (L5)
mod.conf has player_api as optional_depend but you default to its character.b3d mesh, you should check if its even available and throw an error if none of the supported meshes from player_api/3d_armor/skinsdb is available

https://gitea.your-land.de/Sokomine/npc_talk/src/commit/e0216e418eefed88b7e9c9a7ad1d80830e643617/talking_npc.lua#L5 mod.conf has player_api as optional_depend but you default to its `character.b3d` mesh, you should check if its even available and throw an error if none of the supported meshes from player_api/3d_armor/skinsdb is available
Sokomine commented 2024-02-14 21:16:15 +00:00
Owner
Copy Link

After talking in IRC about the issue, the following warning message has now been added:

[npc_talk] Optional dependency "player_api" not found. NPC npc_talk:talking_npc will not work if there is no other mod providing character.b3d and character.png.

After talking in IRC about the issue, the following warning message has now been added: [npc_talk] Optional dependency "player_api" not found. NPC npc_talk:talking_npc will not work if there is no other mod providing character.b3d and character.png.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Sokomine/npc_talk#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?