added snow covers for homedecor roofs; imporoved code

depends.txt

@@ -0,0 +1,2 @@
+default
+homedecor?

init.lua

@@ -1,6 +1,69 @@
 
 moresnow = {}
 
+
+-- TODO: only place special nodes on top if facedir < 4 (at least for roof nodes); else treat them like nodeboxes
+-- TODO: some shapes of rotated stairs and slabs are aequivalent to a solid node; check that?
+moresnow.on_construct = function( pos )
+	
+	local posb = {x=pos.x, y=pos.y-1, z=pos.z};
+	local node  = minetest.get_node( posb );
+	if( node and node.name and minetest.registered_nodes[ node.name ] ) then
+
+		local suggested = moresnow.snow_cover[ minetest.get_content_id( node.name )];
+		-- if it is some solid node, keep the snow cover
+		if( not( suggested )) then
+			-- change the node below if it's some kind of dirt
+			if( node.name == 'default:dirt_with_grass' or node.name == 'default:dirt' ) then
+				minetest.set_node( posb, {name="default:dirt_with_snow"});
+			end
+			return;
+		end
+
+		suggested = minetest.get_name_from_content_id( suggested );
+
+		-- snow_top is a special node suitable for nodeboxes; BUT: it only looks acceptable if the
+		-- node below that nodebox/torch/fence/etc is a solid one
+		if( suggested and suggested == 'moresnow:snow_top' ) then
+			local node2      = minetest.get_node( {x=pos.x, y=pos.y-2, z=pos.z});
+			-- no information about the node below available - we don't know what to do
+			if( not( node2 ) or node2.name == 'air' or node2.name == 'ignore' ) then
+				-- in such a case it helps to drop the snow and let it fall until it hits something
+				if( node2 and node2.name == 'air' ) then
+					minetest.remove_node( pos );
+					spawn_falling_node( {x=pos.x, y=pos.y-2, z=pos.z}, {name="default:snow"})
+				-- else we did not find a sane place for this snow; give up and remove the snow
+				else
+					minetest.remove_node( pos );
+				end
+				return;
+			end
+			local suggested2 = moresnow.snow_cover[ minetest.get_content_id( node2.name )];
+			-- give up
+			if( not( suggested2 )) then
+				minetest.remove_node( pos );
+				return;
+			end
+			suggested2 = minetest.get_name_from_content_id( suggested2 );
+			-- if the node below this one can't handle a normal snow cover, we can't put a snow top on our node either
+			if( suggested2 ~= 'default:snow' ) then
+				minetest.remove_node( pos );
+				return;
+			end
+			
+		end 
+
+		if( suggested ) then
+			local old = minetest.get_node( pos );
+			if( old and old.name and (old.name ~= suggested or ( node.param2 and old.param2 ~= node.param2))) then
+				minetest.set_node( pos, { name = suggested, param2 = node.param2} );
+			end
+		end
+	end
+end
+
+minetest.registered_nodes[ 'default:snow' ].on_construct = moresnow.on_construct;
+
 -- the nodebox for this snow node lies one node DEEPER than the node the snow is in;
 -- thus, nodebox-like nodes covered by snow may look less strange
 minetest.register_node("moresnow:snow_top", {
@@ -27,6 +90,7 @@ minetest.register_node("moresnow:snow_top", {
 		footstep = {name="default_snow_footstep", gain=0.25},
 		dug = {name="default_snow_footstep", gain=0.75},
 	}),
+	on_construct = moresnow.on_construct,
 })
 
 
@@ -58,12 +122,12 @@ minetest.register_node("moresnow:snow_stair_top", {
 		footstep = {name="default_snow_footstep", gain=0.25},
 		dug = {name="default_snow_footstep", gain=0.75},
 	}),
+	on_construct = moresnow.on_construct,
 })
 
 
 minetest.register_node("moresnow:snow_slab_top", {
 	description = "Snow",
---	tiles = {"default_snow.png","default_snow.png","default_ice.png","default_snow.png"},
 	tiles = {"default_snow.png"},
 	inventory_image = "default_snowball.png",
 	wield_image = "default_snowball.png",
@@ -86,9 +150,81 @@ minetest.register_node("moresnow:snow_slab_top", {
 		footstep = {name="default_snow_footstep", gain=0.25},
 		dug = {name="default_snow_footstep", gain=0.75},
 	}),
+	on_construct = moresnow.on_construct,
 })
 
 
+
+moresnow.register_shape = function( shape, new_name, valid_for )
+	
+	-- actually, that would be homedecor.detail, but we don't want to exaggerate; 16 certainly is enough
+	local detail = 16;
+
+	local slopeboxedge = {};
+	for i = 0, detail-1 do
+
+		if(     shape==1 ) then -- slope; normal roof shingles
+			slopeboxedge[i+1]={                      -0.5,  (i/detail)-1.5+(1.25/detail),            (i/detail)-0.5,
+			                                          0.5,  (i/detail)-1.5+(1.25/detail)+(1/detail), (i/detail)-0.5+(1/detail)};
+
+		elseif( shape==2 ) then -- outer corner
+			slopeboxedge[i+1]={                      -0.5,  (i/detail)-1.5+(1.25/detail),            (i/detail)-0.5,
+			                               0.5-(i/detail),  (i/detail)-1.5+(1.25/detail)+(1/detail), (i/detail)-0.5+(1/detail)};
+
+			slopeboxedge[i+detail*1]={     0.5-(i/detail),  (i/detail)-1.5+(1.25/detail)-(1/detail), 0.5,
+			                    0.5-(i/detail)+(1/detail),  (i/detail)-1.5+(1.25/detail),            -0.5+(i/detail)           };
+
+
+		elseif( shape==3 ) then -- inner corner
+			local v = detail-i;
+			slopeboxedge[i+1]={            (i/detail)-0.5,  (v/detail)-1.5+(1.25/detail)-(1/detail), -0.5+(1/detail-(1/detail)), 
+			                    (i/detail)-0.5+(1/detail),  (v/detail)-1.5+(1.25/detail),            0.5-(i/detail)            };
+
+			slopeboxedge[i+detail*1]={                0.5,  (v/detail)-1.5+(1.25/detail),            0.5-(i/detail),
+			                              -0.5+(i/detail),  (v/detail)-1.5+(1.25/detail)+(1/detail), 0.5-(i/detail)+(1/detail) };
+		end
+        end
+
+	minetest.register_node( new_name, {
+		description = "Snow",
+		tiles = {"default_snow.png"},
+		inventory_image = "default_snowball.png",
+		wield_image = "default_snowball.png",
+		is_ground_content = true,
+		paramtype = "light",
+		paramtype2 = "facedir",
+		buildable_to = true,
+		leveled = 7,
+		drawtype = "nodebox",
+		freezemelt = "default:water_flowing",
+		node_box = {
+			type = "fixed",
+			fixed = slopeboxedge,
+		},
+		drop = "default:snow",
+		groups = {crumbly=3,falling_node=1, melts=1, float=1},
+		sounds = default.node_sound_dirt_defaults({
+			footstep = {name="default_snow_footstep", gain=0.25},
+			dug = {name="default_snow_footstep", gain=0.75},
+		}),
+		on_construct = moresnow.on_construct,
+	})
+
+	local c_new_snow_node = minetest.get_content_id( new_name );
+	local c_ignore        = minetest.get_content_id( 'ignore' );
+	if( not( c_new_snow_node )) then
+		return;
+	end
+	for _,v in ipairs( valid_for ) do
+		local id = minetest.get_content_id( v );
+		-- the node has to be registered at this point; thus, the soft-dependency on homedecor and technic
+		if( id and id ~= c_ignore ) then
+			moresnow.snow_cover[ id ] = c_new_snow_node;
+		end
+	end
+end
+
+
 -- find out which nodes are stairs and which are slabs (those are handled diffrently by our snow here);
 -- this is necessary in order to determine which shape the snow on top of the node will take
 -- (of course this only works for a few shapes and does not even take rotation into consideration)
@@ -106,7 +242,18 @@ moresnow.identify_stairs_and_slabs = function()
 
 		local id = minetest.get_content_id( n );
 
-		if( v and v.drawtype and v.drawtype == 'nodebox' and v.node_box
+		if( not( id ) or moresnow.snow_cover[ id ] ) then
+
+			-- do nothing; the node has been dealt with
+
+		elseif( n and minetest.registered_nodes[ n ]
+		      and minetest.registered_nodes[ n ].drop 
+		      and minetest.registered_nodes[ n ].drop == 'default:snow' ) then
+
+			-- no snow on snow
+			
+
+		elseif( v and v.drawtype and v.drawtype == 'nodebox' and v.node_box
 		      and v.node_box.type and v.node_box.type=='fixed'
 		      and v.node_box.fixed ) then
 
@@ -165,51 +312,25 @@ moresnow.identify_stairs_and_slabs = function()
 	end
 end
 
+
+-- TODO: only add these if either technic (with its cnc machine) or homedecor (with shingles) are installed
+-- TODO: add fitting nodes from cnc machine from technic
+moresnow.register_shape( 1, 'moresnow:snow_ramp_top',
+		{'homedecor:shingle_side_terracotta',
+		 'homedecor:shingle_side_wood',
+		 'homedecor:shingle_side_asphalt' });
+
+moresnow.register_shape( 2, 'moresnow:snow_ramp_outer_top',
+		{'homedecor:shingle_outer_corner_terracotta',
+		 'homedecor:shingle_outer_corner_wood',
+		 'homedecor:shingle_outer_corner_asphalt'});
+
+moresnow.register_shape( 3, 'moresnow:snow_ramp_inner_top',
+		{'homedecor:shingle_inner_corner_terracotta',
+		 'homedecor:shingle_inner_corner_wood',
+		 'homedecor:shingle_inner_corner_asphalt'});
+
 -- search for stairs and slabs after all nodes have been generated
 minetest.after( 0, moresnow.identify_stairs_and_slabs );
 
-minetest.registered_nodes[ 'default:snow' ].on_construct = function( pos )
-	
-	local posb = {x=pos.x, y=pos.y-1, z=pos.z};
-	local node  = minetest.get_node( posb );
-	if( node and node.name and minetest.registered_nodes[ node.name ] ) then
 
-		local suggested = moresnow.snow_cover[ minetest.get_content_id( node.name )];
-		-- if it is some solid node, keep the snow cover
-		if( not( suggested )) then
-			-- change the node below if it's some kind of dirt
-			if( node.name == 'default:dirt_with_grass' or node.name == 'default:dirt' ) then
-				minetest.set_node( posb, {name="default:dirt_with_snow"});
-			end
-			return;
-		end
-
-		suggested = minetest.get_name_from_content_id( suggested );
-
-		-- snow_top is a special node suitable for nodeboxes; BUT: it only looks acceptable if the
-		-- node below that nodebox/torch/fence/etc is a solid one
-		if( suggested and suggested == 'moresnow:snow_top' ) then
-			local node2      = minetest.get_node( {x=pos.x, y=pos.y-2, z=pos.z});
-			-- no information about the node below available - we don't know what to do
-			if( not( node ) or node.name == 'air' or node.name == 'ignore' ) then
-				-- TODO: in such a case it would help to drop the node and let it fall until it hits something
-				return;
-			end
-			local suggested2 = moresnow.snow_cover[ minetest.get_content_id( node2.name )];
-			-- give up
-			if( not( suggested2 )) then
-				return;
-			end
-			suggested2 = minetest.get_name_from_content_id( suggested2 );
-			-- if the node below this one can't handle a normal snow cover, we can't put a snow top on our node either
-			if( suggested2 ~= 'default:snow' ) then
-				return;
-			end
-			
-		end 
-
-		if( suggested and suggested ~= 'default:snow') then
-			minetest.set_node( pos, { name = suggested, param2 = node.param2} );
-		end
-	end
-end